* Re: [PATCH] stripper: Strip any PIE executables [not found] <20220630132115.8247-1-michael.tremer@ipfire.org> @ 2022-07-01 8:51 ` Peter Müller 2022-07-06 9:56 ` Peter Müller 0 siblings, 1 reply; 6+ messages in thread From: Peter Müller @ 2022-07-01 8:51 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 604 bytes --] Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org> > Fixes: #12894 > Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org> > --- > src/stripper | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/stripper b/src/stripper > index fadbc514b..4014f03a4 100755 > --- a/src/stripper > +++ b/src/stripper > @@ -38,6 +38,10 @@ function _strip() { > args+=( "--strip-all" ) > ;; > > + *Type:*"DYN (Position-Independent Executable file)"*) > + args+=( "--strip-all" ) > + ;; > + > # Binaries > *Type:*"EXEC (Executable file)"*) > args+=( "--strip-all" ) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stripper: Strip any PIE executables 2022-07-01 8:51 ` [PATCH] stripper: Strip any PIE executables Peter Müller @ 2022-07-06 9:56 ` Peter Müller 2022-07-06 9:57 ` Michael Tremer 0 siblings, 1 reply; 6+ messages in thread From: Peter Müller @ 2022-07-06 9:56 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 1067 bytes --] Hello Michael, just a short follow-up question on this: Do we need to re-ship all affected packages again? Or is it fine to let users benefit from stripped PIE executables when we update affected components anyway? Thanks, and best regards, Peter Müller > Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org> > >> Fixes: #12894 >> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org> >> --- >> src/stripper | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/src/stripper b/src/stripper >> index fadbc514b..4014f03a4 100755 >> --- a/src/stripper >> +++ b/src/stripper >> @@ -38,6 +38,10 @@ function _strip() { >> args+=( "--strip-all" ) >> ;; >> + *Type:*"DYN (Position-Independent Executable file)"*) >> + args+=( "--strip-all" ) >> + ;; >> + >> # Binaries >> *Type:*"EXEC (Executable file)"*) >> args+=( "--strip-all" ) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stripper: Strip any PIE executables 2022-07-06 9:56 ` Peter Müller @ 2022-07-06 9:57 ` Michael Tremer 2022-07-06 10:00 ` Peter Müller 0 siblings, 1 reply; 6+ messages in thread From: Michael Tremer @ 2022-07-06 9:57 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 1362 bytes --] Good question. I did not even think about this. I could not find many executables that fell into this category. Maybe about 10. Out of those, dnsdist was the largest one - by far. So I would say, it isn’t worth it except for dnsdist. -Michael > On 6 Jul 2022, at 10:56, Peter Müller <peter.mueller(a)ipfire.org> wrote: > > Hello Michael, > > just a short follow-up question on this: Do we need to re-ship all affected packages again? > Or is it fine to let users benefit from stripped PIE executables when we update affected > components anyway? > > Thanks, and best regards, > Peter Müller > > >> Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org> >> >>> Fixes: #12894 >>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org> >>> --- >>> src/stripper | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/src/stripper b/src/stripper >>> index fadbc514b..4014f03a4 100755 >>> --- a/src/stripper >>> +++ b/src/stripper >>> @@ -38,6 +38,10 @@ function _strip() { >>> args+=( "--strip-all" ) >>> ;; >>> + *Type:*"DYN (Position-Independent Executable file)"*) >>> + args+=( "--strip-all" ) >>> + ;; >>> + >>> # Binaries >>> *Type:*"EXEC (Executable file)"*) >>> args+=( "--strip-all" ) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stripper: Strip any PIE executables 2022-07-06 9:57 ` Michael Tremer @ 2022-07-06 10:00 ` Peter Müller 2022-07-06 10:20 ` Michael Tremer 0 siblings, 1 reply; 6+ messages in thread From: Peter Müller @ 2022-07-06 10:00 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 1556 bytes --] Hello Michael, thanks for your swift response. Okay, I will then just bump the version number of dnsdist. All the best, Peter Müller > Good question. I did not even think about this. > > I could not find many executables that fell into this category. Maybe about 10. Out of those, dnsdist was the largest one - by far. > > So I would say, it isn’t worth it except for dnsdist. > > -Michael > >> On 6 Jul 2022, at 10:56, Peter Müller <peter.mueller(a)ipfire.org> wrote: >> >> Hello Michael, >> >> just a short follow-up question on this: Do we need to re-ship all affected packages again? >> Or is it fine to let users benefit from stripped PIE executables when we update affected >> components anyway? >> >> Thanks, and best regards, >> Peter Müller >> >> >>> Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org> >>> >>>> Fixes: #12894 >>>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org> >>>> --- >>>> src/stripper | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/src/stripper b/src/stripper >>>> index fadbc514b..4014f03a4 100755 >>>> --- a/src/stripper >>>> +++ b/src/stripper >>>> @@ -38,6 +38,10 @@ function _strip() { >>>> args+=( "--strip-all" ) >>>> ;; >>>> + *Type:*"DYN (Position-Independent Executable file)"*) >>>> + args+=( "--strip-all" ) >>>> + ;; >>>> + >>>> # Binaries >>>> *Type:*"EXEC (Executable file)"*) >>>> args+=( "--strip-all" ) > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stripper: Strip any PIE executables 2022-07-06 10:00 ` Peter Müller @ 2022-07-06 10:20 ` Michael Tremer 2022-07-06 12:34 ` Peter Müller 0 siblings, 1 reply; 6+ messages in thread From: Michael Tremer @ 2022-07-06 10:20 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 1759 bytes --] Did I not submit an update to that somewhere anyways? > On 6 Jul 2022, at 11:00, Peter Müller <peter.mueller(a)ipfire.org> wrote: > > Hello Michael, > > thanks for your swift response. > > Okay, I will then just bump the version number of dnsdist. > > All the best, > Peter Müller > > >> Good question. I did not even think about this. >> >> I could not find many executables that fell into this category. Maybe about 10. Out of those, dnsdist was the largest one - by far. >> >> So I would say, it isn’t worth it except for dnsdist. >> >> -Michael >> >>> On 6 Jul 2022, at 10:56, Peter Müller <peter.mueller(a)ipfire.org> wrote: >>> >>> Hello Michael, >>> >>> just a short follow-up question on this: Do we need to re-ship all affected packages again? >>> Or is it fine to let users benefit from stripped PIE executables when we update affected >>> components anyway? >>> >>> Thanks, and best regards, >>> Peter Müller >>> >>> >>>> Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org> >>>> >>>>> Fixes: #12894 >>>>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org> >>>>> --- >>>>> src/stripper | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/src/stripper b/src/stripper >>>>> index fadbc514b..4014f03a4 100755 >>>>> --- a/src/stripper >>>>> +++ b/src/stripper >>>>> @@ -38,6 +38,10 @@ function _strip() { >>>>> args+=( "--strip-all" ) >>>>> ;; >>>>> + *Type:*"DYN (Position-Independent Executable file)"*) >>>>> + args+=( "--strip-all" ) >>>>> + ;; >>>>> + >>>>> # Binaries >>>>> *Type:*"EXEC (Executable file)"*) >>>>> args+=( "--strip-all" ) >> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stripper: Strip any PIE executables 2022-07-06 10:20 ` Michael Tremer @ 2022-07-06 12:34 ` Peter Müller 0 siblings, 0 replies; 6+ messages in thread From: Peter Müller @ 2022-07-06 12:34 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 2134 bytes --] Hello Michael, > Did I not submit an update to that somewhere anyways? yes, you did: https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=bf7bfc3df6a3fc4e55908a9b80bcf06e51e3b46b This fell through the cracks when compiling the changelog for C169 - thanks for bringing this up. As for C170, bumping the package version is required nevertheless. All the best, Peter Müller > >> On 6 Jul 2022, at 11:00, Peter Müller <peter.mueller(a)ipfire.org> wrote: >> >> Hello Michael, >> >> thanks for your swift response. >> >> Okay, I will then just bump the version number of dnsdist. >> >> All the best, >> Peter Müller >> >> >>> Good question. I did not even think about this. >>> >>> I could not find many executables that fell into this category. Maybe about 10. Out of those, dnsdist was the largest one - by far. >>> >>> So I would say, it isn’t worth it except for dnsdist. >>> >>> -Michael >>> >>>> On 6 Jul 2022, at 10:56, Peter Müller <peter.mueller(a)ipfire.org> wrote: >>>> >>>> Hello Michael, >>>> >>>> just a short follow-up question on this: Do we need to re-ship all affected packages again? >>>> Or is it fine to let users benefit from stripped PIE executables when we update affected >>>> components anyway? >>>> >>>> Thanks, and best regards, >>>> Peter Müller >>>> >>>> >>>>> Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org> >>>>> >>>>>> Fixes: #12894 >>>>>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org> >>>>>> --- >>>>>> src/stripper | 4 ++++ >>>>>> 1 file changed, 4 insertions(+) >>>>>> >>>>>> diff --git a/src/stripper b/src/stripper >>>>>> index fadbc514b..4014f03a4 100755 >>>>>> --- a/src/stripper >>>>>> +++ b/src/stripper >>>>>> @@ -38,6 +38,10 @@ function _strip() { >>>>>> args+=( "--strip-all" ) >>>>>> ;; >>>>>> + *Type:*"DYN (Position-Independent Executable file)"*) >>>>>> + args+=( "--strip-all" ) >>>>>> + ;; >>>>>> + >>>>>> # Binaries >>>>>> *Type:*"EXEC (Executable file)"*) >>>>>> args+=( "--strip-all" ) >>> > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-06 12:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220630132115.8247-1-michael.tremer@ipfire.org>
2022-07-01 8:51 ` [PATCH] stripper: Strip any PIE executables Peter Müller
2022-07-06 9:56 ` Peter Müller
2022-07-06 9:57 ` Michael Tremer
2022-07-06 10:00 ` Peter Müller
2022-07-06 10:20 ` Michael Tremer
2022-07-06 12:34 ` Peter Müller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox