Re: Migrating fireinfo to Python 3

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2351 bytes --]

Hello,

Thanks for the feedback.

I will tag a release then and schedule it to be included in 158.

Best,
-Michael

> On 17 May 2021, at 14:59, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> I ran the python3 fireinfo on my vm testbed system and can confirm that the id stayed the same as with the original python2 files. Both links also worked and gave me the same web page in terms of system details.
> 
> Regards,
> 
> Adolf.
> 
> On 14/05/2021 14:13, Michael Tremer wrote:
>> Hello,
>> You can use Stefan’s build if you are on x86_64:
>>   https://people.ipfire.org/~stevee/fireinfo_python3_x86_64.tar.gz
>> He was even very smart and renamed the “sendprofile” command into “sendprofile3” so that you can run both versions and compare.
>> I didn’t upload a binary version here because I do not want to encourage to download and extract tarballs as root on the firewall. But it should be fine on a development system :)
>> -Michael
>>> On 14 May 2021, at 13:10, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> Hi All,
>>> 
>>> On 07/05/2021 13:16, Michael Tremer wrote:
>>>> Hello,
>>>> 
>>>> I went ahead and converted fireinfo to Python 3.
>>>> 
>>>> This was a little bit more work than usual because it has a little
>>>> helper module written in C.
>>>> 
>>>> I could mainly use 2to3, but some things needed some manual attention. I
>>>> split those into individual commits.
>>>> 
>>>> I would now like to invite everyone to manually install this version on
>>>> their systems and let me know if it
>>> 
>>> The patches are for application to the build system. I can do the patching and then do a clean build but what do I then need to manually install. Is it just the fireinfo.cgi file that I need to install or are there other files I need to copy/replace into my testbed system?
>>> 
>>> 
>>> Regards,
>>> 
>>> Adolf.
>>> 
>>>>   a) works
>>>> 
>>>> and
>>>> 
>>>>   b) does it keep the same ID?
>>>> 
>>>> The ID is being generated by a number of factors and if one bit in those
>>>> changes, the system would receive a different ID which is something we
>>>> would like to avoid.
>>>> 
>>>> It worked fine on my system, but I would like to have some larger sample
>>>> size to be sure.
>>>> 
>>>> Best,
>>>> -Michael
>>>> 
>>>>