From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: Migrating fireinfo to Python 3 Date: Tue, 18 May 2021 11:29:51 +0100 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6903251936652228575==" List-Id: --===============6903251936652228575== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, Thanks for the feedback. I will tag a release then and schedule it to be included in 158. Best, -Michael > On 17 May 2021, at 14:59, Adolf Belka wrote: >=20 > Hi Michael, >=20 > I ran the python3 fireinfo on my vm testbed system and can confirm that the= id stayed the same as with the original python2 files. Both links also worke= d and gave me the same web page in terms of system details. >=20 > Regards, >=20 > Adolf. >=20 > On 14/05/2021 14:13, Michael Tremer wrote: >> Hello, >> You can use Stefan=E2=80=99s build if you are on x86_64: >> https://people.ipfire.org/~stevee/fireinfo_python3_x86_64.tar.gz >> He was even very smart and renamed the =E2=80=9Csendprofile=E2=80=9D comma= nd into =E2=80=9Csendprofile3=E2=80=9D so that you can run both versions and = compare. >> I didn=E2=80=99t upload a binary version here because I do not want to enc= ourage to download and extract tarballs as root on the firewall. But it shoul= d be fine on a development system :) >> -Michael >>> On 14 May 2021, at 13:10, Adolf Belka wrote: >>>=20 >>> Hi All, >>>=20 >>> On 07/05/2021 13:16, Michael Tremer wrote: >>>> Hello, >>>>=20 >>>> I went ahead and converted fireinfo to Python 3. >>>>=20 >>>> This was a little bit more work than usual because it has a little >>>> helper module written in C. >>>>=20 >>>> I could mainly use 2to3, but some things needed some manual attention. I >>>> split those into individual commits. >>>>=20 >>>> I would now like to invite everyone to manually install this version on >>>> their systems and let me know if it >>>=20 >>> The patches are for application to the build system. I can do the patchin= g and then do a clean build but what do I then need to manually install. Is i= t just the fireinfo.cgi file that I need to install or are there other files = I need to copy/replace into my testbed system? >>>=20 >>>=20 >>> Regards, >>>=20 >>> Adolf. >>>=20 >>>> a) works >>>>=20 >>>> and >>>>=20 >>>> b) does it keep the same ID? >>>>=20 >>>> The ID is being generated by a number of factors and if one bit in those >>>> changes, the system would receive a different ID which is something we >>>> would like to avoid. >>>>=20 >>>> It worked fine on my system, but I would like to have some larger sample >>>> size to be sure. >>>>=20 >>>> Best, >>>> -Michael >>>>=20 >>>>=20 --===============6903251936652228575==--