Re: [PATCH] samba: allow to configure server protocol version

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]

Hello Arne,

This patch does not make sense to me because of two reasons:

1) There is no UI to configure this

2) Why would a user want to change this? You stated they are dangerous. Why would a user be qualified to change this? If the goal is to enable SMBv1, then I would suggest to rather have a checkbox with a big big warning sign that someone is doing something really really stupid.

If you just want to have a place to add some custom configuration options, why don’t we add a smb.conf.local file?

Best,
-Michael

> On 1 Nov 2020, at 16:38, Arne Fitzenreiter <arne_f(a)ipfire.org> wrote:
> 
> add entries for server min/max protocol in /var/ipfire/samba/settings.
> This settings may be dangerous but sometimes they are needed so it will
> not showed in the cgi.
> 
> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
> ---
> html/cgi-bin/samba.cgi | 9 +++++++++
> 1 file changed, 9 insertions(+)
> 
> diff --git a/html/cgi-bin/samba.cgi b/html/cgi-bin/samba.cgi
> index ec41adc5d..4b57c1add 100644
> --- a/html/cgi-bin/samba.cgi
> +++ b/html/cgi-bin/samba.cgi
> @@ -835,7 +835,16 @@ if ($sambasettings{'ENCRYPTION'} =~ m/(desired|required)/) {
> 	print FILE "smb encrypt = $1\n";
> }
> 
> +if ($sambasettings{'SERVER_MIN_PROTOCOL'} ne "" ) {
> +	print FILE "server min protocol = $sambasettings{'SERVER_MIN_PROTOCOL'}\n";
> +}
> +
> +if ($sambasettings{'SERVER_MAX_PROTOCOL'} ne "" ) {
> +	print FILE "server max protocol = $sambasettings{'SERVER_MAX_PROTOCOL'}\n";
> +}
> +
> print FILE <<END;
> +
> # Export all printers
> [printers]
> path = /var/spool/samba/
> -- 
> 2.17.1
>