From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] samba: allow to configure server protocol version
Date: Mon, 02 Nov 2020 10:31:44 +0000
Message-ID: <F08C4DC5-C258-437F-BCD7-EA2E2EEB4D0A@ipfire.org>
In-Reply-To: <20201101163856.4742-1-arne_f@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6439577682046487751=="
List-Id: <development.lists.ipfire.org>

--===============6439577682046487751==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Arne,

This patch does not make sense to me because of two reasons:

1) There is no UI to configure this

2) Why would a user want to change this? You stated they are dangerous. Why w=
ould a user be qualified to change this? If the goal is to enable SMBv1, then=
 I would suggest to rather have a checkbox with a big big warning sign that s=
omeone is doing something really really stupid.

If you just want to have a place to add some custom configuration options, wh=
y don=E2=80=99t we add a smb.conf.local file?

Best,
-Michael

> On 1 Nov 2020, at 16:38, Arne Fitzenreiter <arne_f(a)ipfire.org> wrote:
>=20
> add entries for server min/max protocol in /var/ipfire/samba/settings.
> This settings may be dangerous but sometimes they are needed so it will
> not showed in the cgi.
>=20
> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
> ---
> html/cgi-bin/samba.cgi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>=20
> diff --git a/html/cgi-bin/samba.cgi b/html/cgi-bin/samba.cgi
> index ec41adc5d..4b57c1add 100644
> --- a/html/cgi-bin/samba.cgi
> +++ b/html/cgi-bin/samba.cgi
> @@ -835,7 +835,16 @@ if ($sambasettings{'ENCRYPTION'} =3D~ m/(desired|requi=
red)/) {
> 	print FILE "smb encrypt =3D $1\n";
> }
>=20
> +if ($sambasettings{'SERVER_MIN_PROTOCOL'} ne "" ) {
> +	print FILE "server min protocol =3D $sambasettings{'SERVER_MIN_PROTOCOL'}=
\n";
> +}
> +
> +if ($sambasettings{'SERVER_MAX_PROTOCOL'} ne "" ) {
> +	print FILE "server max protocol =3D $sambasettings{'SERVER_MAX_PROTOCOL'}=
\n";
> +}
> +
> print FILE <<END;
> +
> # Export all printers
> [printers]
> path =3D /var/spool/samba/
> --=20
> 2.17.1
>=20


--===============6439577682046487751==--