From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Feedback on Core Update 154 testing
Date: Tue, 16 Feb 2021 15:02:04 +0000 [thread overview]
Message-ID: <F15EB7A2-1DE8-40E7-9A8E-59C14D52AF56@ipfire.org> (raw)
In-Reply-To: <92699267-80d9-111e-ef6b-06c2a04af9fc@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
Ignore the question from my earlier email.
This has to go into master :)
-Michael
> On 16 Feb 2021, at 12:59, Adolf Belka (ipfire-dev) <adolf.belka(a)ipfire.org> wrote:
>
> Hi All,
>
> After working on a new bug (#10628), my code was not working as I expected it to. After investigating I realised that when I provided https://patchwork.ipfire.org/patch/3724/ to add Deny Known Client capability to dhcp.cgi I had placed a curly bracket in the wrong place.
>
> It is not syntactically wrong so there is no Internal Error message coming up but if the Deny Known Clients is not checked then there is no check made for a valid Default Lease Time.
>
>
> I made an error when I inserted my code into dhcp.cgi for the Deny Known Clients fix.
>
>
> I will raise a patch to correct this.
>
>
> Regards,
>
> Adolf.
>
next prev parent reply other threads:[~2021-02-16 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 12:59 Adolf Belka (ipfire-dev)
2021-02-16 15:02 ` Michael Tremer [this message]
2021-02-17 13:21 ` Adolf Belka (ipfire-dev)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F15EB7A2-1DE8-40E7-9A8E-59C14D52AF56@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox