From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: Feedback on Core Update 154 testing Date: Tue, 16 Feb 2021 15:02:04 +0000 Message-ID: In-Reply-To: <92699267-80d9-111e-ef6b-06c2a04af9fc@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7479193146033020001==" List-Id: --===============7479193146033020001== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Ignore the question from my earlier email. This has to go into master :) -Michael > On 16 Feb 2021, at 12:59, Adolf Belka (ipfire-dev) wrote: >=20 > Hi All, >=20 > After working on a new bug (#10628), my code was not working as I expected = it to. After investigating I realised that when I provided https://patchwork.= ipfire.org/patch/3724/ to add Deny Known Client capability to dhcp.cgi I had = placed a curly bracket in the wrong place. >=20 > It is not syntactically wrong so there is no Internal Error message coming = up but if the Deny Known Clients is not checked then there is no check made f= or a valid Default Lease Time. >=20 >=20 > I made an error when I inserted my code into dhcp.cgi for the Deny Known Cl= ients fix. >=20 >=20 > I will raise a patch to correct this. >=20 >=20 > Regards, >=20 > Adolf. >=20 --===============7479193146033020001==--