From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] wirelessclient.cgi: Fix for bug #12571
Date: Fri, 12 Feb 2021 11:48:07 +0000
Message-ID: <F1FE6E19-8FCA-403B-B2CE-762BF22DE112@ipfire.org>
In-Reply-To: <20210211124129.3661993-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8256310776873845012=="
List-Id: <development.lists.ipfire.org>

--===============8256310776873845012==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

This patch looks good.

What would help me a little bit more when writing the change log is to put wh=
at it does in the subject line (i.e. first line of the Git message).

In this case it could have been something along the lines of (Correct order o=
f priority).

I noticed this when I wrote the change log for Core Update 154 and I had to g=
o and lookup the bug number which took me some extra time.

So, not a big issue here, but it is easier to spot what the patch does when i=
t is in the headline.

The bug number should be in the body with in a =E2=80=9CFixes: #12571=E2=80=
=9D style.

Best,
-Michael

> On 11 Feb 2021, at 12:41, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>=20
> - Wirelessclient shows priority 0 to be most preferred and priority 4 as
> least preferred. Based on forum posters experience and the wpa_supplicant
> man page it is the other way round.
> - This patch moves the least preferred title to priority 0 and vice versa
> - Will ask bug reporter to test out the patch and confirm it works. The page
> is only shown if you have a wifi connection on red.
>=20
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> html/cgi-bin/wirelessclient.cgi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/html/cgi-bin/wirelessclient.cgi b/html/cgi-bin/wirelessclient.=
cgi
> index e8c3c9628..b1679c128 100644
> --- a/html/cgi-bin/wirelessclient.cgi
> +++ b/html/cgi-bin/wirelessclient.cgi
> @@ -602,11 +602,11 @@ sub showEditBox() {
> 					</td>
> 					<td width=3D'40%'>
> 						<select name=3D'PRIO'>
> -							<option value=3D"0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'most prefe=
rred'})</option>
> +							<option value=3D"0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'least pref=
erred'})</option>
> 							<option value=3D"1" $selected{'PRIO'}{'1'}>1</option>
> 							<option value=3D"2" $selected{'PRIO'}{'2'}>2</option>
> 							<option value=3D"3" $selected{'PRIO'}{'3'}>3</option>
> -							<option value=3D"4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'least pref=
erred'})</option>
> +							<option value=3D"4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'most prefe=
rred'})</option>
> 						</select>
> 					</td>
> 					<td colspan=3D"2" width=3D'40%'></td>
> --=20
> 2.30.1
>=20


--===============8256310776873845012==--