* [PATCH] wirelessclient.cgi: Fix for bug #12571
@ 2021-02-11 12:41 Adolf Belka
2021-02-12 11:48 ` Michael Tremer
0 siblings, 1 reply; 4+ messages in thread
From: Adolf Belka @ 2021-02-11 12:41 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
- Wirelessclient shows priority 0 to be most preferred and priority 4 as
least preferred. Based on forum posters experience and the wpa_supplicant
man page it is the other way round.
- This patch moves the least preferred title to priority 0 and vice versa
- Will ask bug reporter to test out the patch and confirm it works. The page
is only shown if you have a wifi connection on red.
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
html/cgi-bin/wirelessclient.cgi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/html/cgi-bin/wirelessclient.cgi b/html/cgi-bin/wirelessclient.cgi
index e8c3c9628..b1679c128 100644
--- a/html/cgi-bin/wirelessclient.cgi
+++ b/html/cgi-bin/wirelessclient.cgi
@@ -602,11 +602,11 @@ sub showEditBox() {
</td>
<td width='40%'>
<select name='PRIO'>
- <option value="0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'most preferred'})</option>
+ <option value="0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'least preferred'})</option>
<option value="1" $selected{'PRIO'}{'1'}>1</option>
<option value="2" $selected{'PRIO'}{'2'}>2</option>
<option value="3" $selected{'PRIO'}{'3'}>3</option>
- <option value="4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'least preferred'})</option>
+ <option value="4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'most preferred'})</option>
</select>
</td>
<td colspan="2" width='40%'></td>
--
2.30.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] wirelessclient.cgi: Fix for bug #12571
2021-02-11 12:41 [PATCH] wirelessclient.cgi: Fix for bug #12571 Adolf Belka
@ 2021-02-12 11:48 ` Michael Tremer
2021-02-12 12:05 ` Adolf Belka (ipfire-dev)
0 siblings, 1 reply; 4+ messages in thread
From: Michael Tremer @ 2021-02-12 11:48 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2235 bytes --]
Hi,
This patch looks good.
What would help me a little bit more when writing the change log is to put what it does in the subject line (i.e. first line of the Git message).
In this case it could have been something along the lines of (Correct order of priority).
I noticed this when I wrote the change log for Core Update 154 and I had to go and lookup the bug number which took me some extra time.
So, not a big issue here, but it is easier to spot what the patch does when it is in the headline.
The bug number should be in the body with in a “Fixes: #12571” style.
Best,
-Michael
> On 11 Feb 2021, at 12:41, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>
> - Wirelessclient shows priority 0 to be most preferred and priority 4 as
> least preferred. Based on forum posters experience and the wpa_supplicant
> man page it is the other way round.
> - This patch moves the least preferred title to priority 0 and vice versa
> - Will ask bug reporter to test out the patch and confirm it works. The page
> is only shown if you have a wifi connection on red.
>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> html/cgi-bin/wirelessclient.cgi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/html/cgi-bin/wirelessclient.cgi b/html/cgi-bin/wirelessclient.cgi
> index e8c3c9628..b1679c128 100644
> --- a/html/cgi-bin/wirelessclient.cgi
> +++ b/html/cgi-bin/wirelessclient.cgi
> @@ -602,11 +602,11 @@ sub showEditBox() {
> </td>
> <td width='40%'>
> <select name='PRIO'>
> - <option value="0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'most preferred'})</option>
> + <option value="0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'least preferred'})</option>
> <option value="1" $selected{'PRIO'}{'1'}>1</option>
> <option value="2" $selected{'PRIO'}{'2'}>2</option>
> <option value="3" $selected{'PRIO'}{'3'}>3</option>
> - <option value="4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'least preferred'})</option>
> + <option value="4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'most preferred'})</option>
> </select>
> </td>
> <td colspan="2" width='40%'></td>
> --
> 2.30.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] wirelessclient.cgi: Fix for bug #12571
2021-02-12 11:48 ` Michael Tremer
@ 2021-02-12 12:05 ` Adolf Belka (ipfire-dev)
2021-02-12 12:11 ` Michael Tremer
0 siblings, 1 reply; 4+ messages in thread
From: Adolf Belka (ipfire-dev) @ 2021-02-12 12:05 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2573 bytes --]
Hi Michael,
On 12/02/2021 12:48, Michael Tremer wrote:
> Hi,
>
> This patch looks good.
>
> What would help me a little bit more when writing the change log is to put what it does in the subject line (i.e. first line of the Git message).
>
> In this case it could have been something along the lines of (Correct order of priority).
>
> I noticed this when I wrote the change log for Core Update 154 and I had to go and lookup the bug number which took me some extra time.
>
> So, not a big issue here, but it is easier to spot what the patch does when it is in the headline.
>
> The bug number should be in the body with in a “Fixes: #12571” style.
Makes sense. If you have a few bug fixes in the update you don't want to have to go to bugzilla for each one to find out what it does.
I will keep that in mind.
Thanks for the input.
Regards,
Adolf.
>
> Best,
> -Michael
>
>> On 11 Feb 2021, at 12:41, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> - Wirelessclient shows priority 0 to be most preferred and priority 4 as
>> least preferred. Based on forum posters experience and the wpa_supplicant
>> man page it is the other way round.
>> - This patch moves the least preferred title to priority 0 and vice versa
>> - Will ask bug reporter to test out the patch and confirm it works. The page
>> is only shown if you have a wifi connection on red.
>>
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>> html/cgi-bin/wirelessclient.cgi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/html/cgi-bin/wirelessclient.cgi b/html/cgi-bin/wirelessclient.cgi
>> index e8c3c9628..b1679c128 100644
>> --- a/html/cgi-bin/wirelessclient.cgi
>> +++ b/html/cgi-bin/wirelessclient.cgi
>> @@ -602,11 +602,11 @@ sub showEditBox() {
>> </td>
>> <td width='40%'>
>> <select name='PRIO'>
>> - <option value="0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'most preferred'})</option>
>> + <option value="0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'least preferred'})</option>
>> <option value="1" $selected{'PRIO'}{'1'}>1</option>
>> <option value="2" $selected{'PRIO'}{'2'}>2</option>
>> <option value="3" $selected{'PRIO'}{'3'}>3</option>
>> - <option value="4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'least preferred'})</option>
>> + <option value="4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'most preferred'})</option>
>> </select>
>> </td>
>> <td colspan="2" width='40%'></td>
>> --
>> 2.30.1
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] wirelessclient.cgi: Fix for bug #12571
2021-02-12 12:05 ` Adolf Belka (ipfire-dev)
@ 2021-02-12 12:11 ` Michael Tremer
0 siblings, 0 replies; 4+ messages in thread
From: Michael Tremer @ 2021-02-12 12:11 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2802 bytes --]
Yes, and I suppose other people who read the git change log do not need to do the same thing :)
> On 12 Feb 2021, at 12:05, Adolf Belka (ipfire-dev) <adolf.belka(a)ipfire.org> wrote:
>
> Hi Michael,
>
> On 12/02/2021 12:48, Michael Tremer wrote:
>> Hi,
>> This patch looks good.
>> What would help me a little bit more when writing the change log is to put what it does in the subject line (i.e. first line of the Git message).
>> In this case it could have been something along the lines of (Correct order of priority).
>> I noticed this when I wrote the change log for Core Update 154 and I had to go and lookup the bug number which took me some extra time.
>> So, not a big issue here, but it is easier to spot what the patch does when it is in the headline.
>> The bug number should be in the body with in a “Fixes: #12571” style.
>
> Makes sense. If you have a few bug fixes in the update you don't want to have to go to bugzilla for each one to find out what it does.
>
> I will keep that in mind.
>
> Thanks for the input.
>
> Regards,
> Adolf.
>> Best,
>> -Michael
>>> On 11 Feb 2021, at 12:41, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>
>>> - Wirelessclient shows priority 0 to be most preferred and priority 4 as
>>> least preferred. Based on forum posters experience and the wpa_supplicant
>>> man page it is the other way round.
>>> - This patch moves the least preferred title to priority 0 and vice versa
>>> - Will ask bug reporter to test out the patch and confirm it works. The page
>>> is only shown if you have a wifi connection on red.
>>>
>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>> ---
>>> html/cgi-bin/wirelessclient.cgi | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/html/cgi-bin/wirelessclient.cgi b/html/cgi-bin/wirelessclient.cgi
>>> index e8c3c9628..b1679c128 100644
>>> --- a/html/cgi-bin/wirelessclient.cgi
>>> +++ b/html/cgi-bin/wirelessclient.cgi
>>> @@ -602,11 +602,11 @@ sub showEditBox() {
>>> </td>
>>> <td width='40%'>
>>> <select name='PRIO'>
>>> - <option value="0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'most preferred'})</option>
>>> + <option value="0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'least preferred'})</option>
>>> <option value="1" $selected{'PRIO'}{'1'}>1</option>
>>> <option value="2" $selected{'PRIO'}{'2'}>2</option>
>>> <option value="3" $selected{'PRIO'}{'3'}>3</option>
>>> - <option value="4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'least preferred'})</option>
>>> + <option value="4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'most preferred'})</option>
>>> </select>
>>> </td>
>>> <td colspan="2" width='40%'></td>
>>> --
>>> 2.30.1
>>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-12 12:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11 12:41 [PATCH] wirelessclient.cgi: Fix for bug #12571 Adolf Belka
2021-02-12 11:48 ` Michael Tremer
2021-02-12 12:05 ` Adolf Belka (ipfire-dev)
2021-02-12 12:11 ` Michael Tremer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox