From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer <michael.tremer@ipfire.org> To: development@lists.ipfire.org Subject: Re: [PATCH 0/2] buildprocess: additional pak metadata Date: Sat, 26 Jun 2021 13:09:37 +0100 Message-ID: <F3E719B4-A9FA-4BB3-8224-8ED583FA91D4@ipfire.org> In-Reply-To: <b800c22e26ece5c28e255b0d6a943be616b0aba6.camel@disroot.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7820235181412075213==" List-Id: <development.lists.ipfire.org> --===============7820235181412075213== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, > On 25 Jun 2021, at 00:04, Robin Roevens <robin.roevens(a)disroot.org> wrote: >=20 > It seems patch 2/2 of this set is rejected by the mailserver: >=20 > 554 5.7.1 Rejected due to policy violation: Contains blacklisted URL. Yes, our mail server seems to do that a lot recently. > For as far as I can see, the patch does not contain any URL's of any > sort. >=20 > How should I proceed from here? Is there an alternative way to submit > this patch-set? Or can it be checked what triggers this mailserver > error ? You have done the right thing by copying postmaster. Peter and I had a brief discussion about this yesterday. Let=E2=80=99s see wh= at he says after looking at some logs. Best, -Michael >=20 > Regards > Robin >=20 > Robin Roevens schreef op vr 25-06-2021 om 00:50 [+0200]: >> Hi >>=20 >> As discussed earlier, I hereby submit a patchset adding extra metadata=20 >> to all pak's. >>=20 >> First patch adds the new metadata fields "Summary" and "Services" to >> the=20 >> meta-file templates and introduces the new macro INSTALL_INITSCRIPTS=20 >> accepting a space seperated list of initscripts to install to avoid >> duplicating the list of service initscripts. (Once in the new SERVICES >> meta-data field and once by calling INSTALL_INITSCRIPT for each of=20 >> them). >> The original INSTALL_INITSCRIPT macro is kept (and called by the new >> macro) for corner cases where non-service initscripts need to be=20 >> installed and for use by non-pak lfs files as they currently don't have >> a SERVICES variable.=20 >>=20 >> The second patch adds the new metadata for all pak's in their >> respective >> lfs files.=20 >> As I went over all pak lfs files, I did not encounter any corner cases >> hence all calls to INSTALL_INITSCRIPT are replaced by calls to the new >> INSTALL_INITSCRIPTS passing the SERVICES variable as argument. >> The only special case maybe worth mentioning is Icinga, where a service >> initscript is installed by a make rule of the source. Hence no call to >> INSTALL_INITSCRIPT or INSTALL_INITSCRIPTS is required. But the service >> is included in the SERVICES variable to have it recorded in the meta- >> file. >>=20 >> This set does not yet contain changes in pakfire or services.cgi to >> actually do something with the new meta-data. >> Those changes will be posted shortly. >>=20 >> Regards >>=20 >> Robin >>=20 >>=20 >=20 >=20 > --=20 > Dit bericht is gescanned op virussen en andere gevaarlijke > inhoud door MailScanner en lijkt schoon te zijn. >=20 --===============7820235181412075213==--