From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4bS7Ck5kqcz330j for ; Wed, 25 Jun 2025 16:52:34 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature RSA-PSS (4096 bits)) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4bS7Cg1cMTz2xLw for ; Wed, 25 Jun 2025 16:52:31 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4bS7Cf3Phwz5v; Wed, 25 Jun 2025 16:52:30 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1750870350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8WsjO9bKqlKbJzkgfkh3o4G/GGlC3BU4dmrZJyy8+zs=; b=uYyZsqJ+/gqg7FF0Gi+hQOcyFQJQj44fAaYWParwnh2UUQ9v763kv3UG7Xu93iTFnLy/DD 8ItMbuIuz+5XlkDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1750870350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8WsjO9bKqlKbJzkgfkh3o4G/GGlC3BU4dmrZJyy8+zs=; b=Ksssf2acm5c2pJm8L4G+e8nu31kY7eixuKU/exakvfrt1IkG3XgUt0JufOu1nM+2bZm0ed TtGBydDmoOWqY0tuTRzKk1YxeejOY8iJolheh3PhCGCztVkgCqv7QNOEdkm1p8gIxSddoY yPmgvK/fvbLhSycpLzlPnHqGPjKkua/adw5vbRjzNDrAHBADP8SXMBtJiFauo5+zH+sYCc P5jzsUEHiz6cM0rtb8Me/M+Vik3/tHfdxb1OZVUNIk9dwI1gYOiKVcUzfqzmdo8XAFGbnT JzphOqWhNib7QsDBJNMAoaQo0BL1Qea4wGRz7GLvcYEYTfYCVL4TzW4Tz7pVNw== Content-Type: text/plain; charset=utf-8 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: Mime-Version: 1.0 Subject: Re: [PATCH 4/5] fwhosts.cgi: Move the tooltip into the usage counter From: Michael Tremer In-Reply-To: <2bf6ef30-c057-4d39-98d5-8ef4ea35edea@ipfire.org> Date: Wed, 25 Jun 2025 17:52:29 +0100 Cc: "IPFire: Development-List" , dietzmann@brecht-schule.hamburg Content-Transfer-Encoding: quoted-printable Message-Id: References: <20250623171658.530138-1-michael.tremer@ipfire.org> <20250623171658.530138-4-michael.tremer@ipfire.org> <2bf6ef30-c057-4d39-98d5-8ef4ea35edea@ipfire.org> To: Adolf Belka Hello Adolf, Thank you for the feedback. It is indeed not obvious. On the other hand, the large icon is not = really a solution either in my opinion. It is simply too large and = distracting for a feature that won=E2=80=99t be used *that* much. I would however love some visual hint, but I cannot really think of = anything between the two options that we have for now. -Michael > On 25 Jun 2025, at 17:40, Adolf Belka wrote: >=20 > Tested-by: Adolf Belka >=20 > I actually found the i in a blue circle icon very helpful for this. I = was able to figure out where I should place my mouse pointer for the = info. >=20 > With this patch applied, which was the first way I tested it, I had no = idea where to place the mouse pointer as nothing looked different to the = existing situation. I did try placing it over the usage counter a couple = of times but obviously not for long enough in my first tries as I never = saw anything get shown. >=20 > Reading the title of this patch more carefully I went back and now = held the mouse pointer over the usage counter and waited for 1 to 2 = seconds and now the info was shown. Typically I found it takes a = minimum of 1 second and sometimes around 1.5 seconds before anything is = shown and first time around I was obviously not waiting long enough at = any one location. >=20 > If the usage counter is to stay as the location to place the mouse = pointer onto for the info then I think this will need to be explained = very clearly in the wiki documentation otherwise users might not = discover this useful function directly on the WUI page. >=20 >=20 > On 23/06/2025 19:16, Michael Tremer wrote: >> This will clutter the page less as we don't have any good icon sets. >> Signed-off-by: Michael Tremer >> --- >> html/cgi-bin/fwhosts.cgi | 42 = +++++++++++----------------------------- >> 1 file changed, 11 insertions(+), 31 deletions(-) >> diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi >> index 69970a840..953f81e5f 100644 >> --- a/html/cgi-bin/fwhosts.cgi >> +++ b/html/cgi-bin/fwhosts.cgi >> @@ -1932,7 +1932,7 @@ sub viewtablenet >> }else{ >> print<> >> - >> + >> END >> } >> my $count=3D0; >> @@ -1953,11 +1953,7 @@ END >> my = $colnet=3D"$customnetwork{$key}[1]/".&General::subtocidr($customnetwork{$k= ey}[2]); >> my $netcount=3D&getnetcount($customnetwork{$key}[0]); >> my $netusedin=3D&getusedin($customnetwork{$key}[0]); >> - my $htmlparttouse=3D""; >> - if ($netusedin) { >> - $htmlparttouse =3D ""; >> - } >> - print""; >> + print""; >> print<>
$Lang::tr{'name'}$Lang::tr{'fwhost netaddress'}$Lang::tr{'remark'}$Lang::tr{'used'}
$Lang::tr{'name'}$Lang::tr{'fwhost netaddress'}$Lang::tr{'remark'}$Lang::tr{'used'}
$customnetwork{$key}[0]
".&getcolor($colnet)."$customnetwork{$key}[3]$netcount = x$htmlparttouse$customnetwork{$key}[0]".&getcolor($colnet)."$customnetwork{$key}[3]$netcount x >> >> @@ -2091,7 +2087,7 @@ sub viewtablehost >> }else{ >> print<> >> - >> + >> END >> } >> my $count=3D0; >> @@ -2112,12 +2108,9 @@ END >> my $hostcount=3D0; >> $hostcount=3D&gethostcount($customhost{$key}[0]); >> my $hostusedin=3D&getusedin($customhost{$key}[0]); >> - my $htmlparttouse=3D""; >> - if ($hostusedin) { >> - $htmlparttouse =3D ""; >> - } >> - print""; >> - print<> + my $color =3D &getcolor($ip); >> + print <> + >>
$Lang::tr{'name'}$Lang::tr{'fwhost ip_mac'}$Lang::tr{'remark'}$Lang::tr{'used'}
$Lang::tr{'name'}$Lang::tr{'fwhost ip_mac'}$Lang::tr{'remark'}$Lang::tr{'used'}
$customhost{$key}[0]".&getcolor($ip)."$customhost{$key}[3]$hostcount x$htmlparttouse$customhost{$key}[0]$color$customhost{$key}[3]$hostcount x >> >> >> @@ -2192,11 +2185,8 @@ sub viewtablegrp >> print "
$grpname   "; >> print " $Lang::tr{'remark'}:  $remark   " if = ($remark ne ''); >> my $netgrpcount=3D&getnetcount($grpname); >> - print "$Lang::tr{'used'}: $netgrpcount x "; >> my $groupusedin=3D&getusedin($grpname); >> - if ($groupusedin) { >> - print ""; >> - } >> + print "$Lang::tr{'used'}: $netgrpcount x"; >> if($netgrpcount =3D=3D '0') >> { >> print""; >> @@ -2335,10 +2325,7 @@ sub viewtablelocationgrp >> # Get group count. >> my $locationgrpcount=3D&getlocationcount($grpname); >> my $locationusedin=3D&getlocusedin($grpname); >> - print "$Lang::tr{'used'}: $locationgrpcount x "; >> - if ($locationusedin) { >> - print ""; >> - } >> + print "$Lang::tr{'used'}: $locationgrpcount x"; >> # Only display delete icon, if the group is not used by a firewall = rule. >> if($locationgrpcount =3D=3D '0') { >> print"
\n"; >> @@ -2459,7 +2446,7 @@ sub viewtableservice >> &General::readhasharray("$fwconfigout", \%fwout); >> print<> >> - >> + >> END >> my $col=3D''; >> foreach my $key (sort { = ncmp($customservice{$a}[0],$customservice{$b}[0])} keys %customservice) >> @@ -2481,14 +2468,10 @@ END >> #Neuer count >> $srvcount=3D&getsrvcount($customservice{$key}[0]); >> my $serviceusedin=3D&getsrvusedin($customservice{$key}[0]); >> - my $htmlparttouse=3D""; >> - if ($serviceusedin) { >> - $htmlparttouse=3D""; >> - } >> if($customservice{$key}[3] eq 'All ICMP-Types'){print = $Lang::tr{'fwdfw all icmp'};} >> elsif($customservice{$key}[3] ne 'BLANK'){print = $customservice{$key}[3];} >> print<> - >> + >>
$Lang::tr{'fwhost = srv_name'}$Lang::tr{'fwhost = prot'}$Lang::tr{'fwhost = port'}ICMP$Lang::tr{'fwhost = used'}
$Lang::tr{'fwhost = srv_name'}$Lang::tr{'fwhost = prot'}$Lang::tr{'fwhost = port'}ICMP$Lang::tr{'fwhost used'}
$srvcount = x$htmlparttouse$srvcount x >> >> >> @@ -2560,11 +2543,8 @@ sub viewtableservicegrp >> if($count >0){print"
";$count=3D1;} >> print "
$grpname    "; >> print "$Lang::tr{'remark'}:  $remark " if ($remark ne = ''); >> - print "  $Lang::tr{'used'}: $grpcount x "; >> my $srvgrpusedin=3D&getsrvusedin($customservicegrp{$key}[0]); >> - if ($srvgrpusedin) { >> - print ""; >> - } >> + print "  $Lang::tr{'used'}: $grpcount x"; >> if($grpcount =3D=3D '0') >> { >> print""; >=20