From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 3/3] perl-Net-SMTP-SSL: Update to 1.04
Date: Mon, 22 Mar 2021 11:19:50 +0000
Message-ID: <F8D2D80E-1F16-4D42-AAD2-CC89206443ED@ipfire.org>
In-Reply-To: <9ad0a1f3-2b2d-8fcd-7141-8b22f2f7d710@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6143384026557045757=="
List-Id: <development.lists.ipfire.org>

--===============6143384026557045757==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

I merged it, because we need Git for development purposes.

I am writing CGI scripts on the systems and commit small changes. Copying fil=
es back and forth would be error-prone and waste time.

I do not think that Git needs documentation on the wiki. There is some stuff =
in the development section.

If we can replace this module by a newer version, that would definitely help =
in the future :)

-Michael

> On 22 Mar 2021, at 07:44, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>=20
> Hi All,
>=20
> When updating this dependency of git I saw that it was now deprecated. I ha=
d a look at the replacement library and while I could create it as a new addo=
n, it was not clear to me if just defining it as a dependency of git would ma=
ke git correctly use it.
>=20
> I am also not sure why anyone would want to run git on a firewall. This add=
on is not listed in the wiki.
>=20
> I am therefore not sure if this patch set should be merged or if it should =
be updated with the new library (and how) or if git should still be left in I=
PFire as an addon and hence this library.
>=20
> I am open to whatever decision you think is appropriate for this patch set.
>=20
> Regards,
> Adolf.
>=20
> On 22/03/2021 08:33, Adolf Belka wrote:
>> - Update from 1.02 to 1.04
>> - Update of rootfile not required
>> - This is a dependency of git addon package
>> - Changelog
>>    1.04    2016-10-09
>>     - mark this library deprecated, suggest newer Net::SMTP instead
>>    1.03    2015-06-20
>>     - $net_smtp_ssl->isa('Net::SMTP') is now true
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>>  lfs/perl-Net-SMTP-SSL | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> diff --git a/lfs/perl-Net-SMTP-SSL b/lfs/perl-Net-SMTP-SSL
>> index 90e8a2260..2bb00a808 100644
>> --- a/lfs/perl-Net-SMTP-SSL
>> +++ b/lfs/perl-Net-SMTP-SSL
>> @@ -24,7 +24,7 @@
>>    include Config
>>  -VER        =3D 1.02
>> +VER        =3D 1.04
>>    THISAPP    =3D Net-SMTP-SSL-$(VER)
>>  DL_FILE    =3D ${THISAPP}.tar.gz
>> @@ -33,7 +33,7 @@ DIR_APP    =3D $(DIR_SRC)/$(THISAPP)
>>  TARGET     =3D $(DIR_INFO)/$(THISAPP)
>>  PROG       =3D perl-Net-SMTP-SSL
>>  DEPS       =3D
>> -PAK_VER    =3D 2
>> +PAK_VER    =3D 3
>>    #######################################################################=
########
>>  # Top-level Rules
>> @@ -43,7 +43,7 @@ objects =3D $(DL_FILE)
>>    $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>  -$(DL_FILE)_MD5 =3D e67b4d842a51b9a453aeeaeed45fb8e1
>> +$(DL_FILE)_MD5 =3D 62b49c961043898b43b041dafbc1b389
>>    install : $(TARGET)
>> =20
>=20
> --=20
> Sent from my laptop


--===============6143384026557045757==--