From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: Test of cleanup branch Date: Fri, 02 Aug 2024 18:13:19 +0100 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2427040313493364626==" List-Id: --===============2427040313493364626== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The package numbers should be back now. I simply used a wrong variable name: https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3Ddf84336ef8f7c= 20f7337a0d078f198a135815db1 -Michael > On 1 Aug 2024, at 16:01, Adolf Belka wrote: >=20 > Hi Michael, >=20 > Additional note written after all of the feedback below the dashed line was= written. I did a shutdown of the vm with CU188 to check something in the CU1= 86 vm then went back to the CU188 version and things had changed. Most of the= longer boxes are no longer longer and don't overlap other elements. The miss= ing colours are back for IPSec, OpenVPN etc. >=20 > The graph period selection previously was in a horizontal line under the gr= aph. Now it was still under the graph but it is now a vertical selection choi= ce which can't have been intended as it takes far too much space. However the= key thing is that rebooting seems to be making things change, which shouldn'= t be happening. I have started to take screenshots of things to have some evi= dence. >=20 > Attached is a screenshot showing the graph period selectors which are now v= ertically positioned at the bottom of the graphs. >=20 > Also attached is a screenshot of the pakfire page that is still missing the= pak_ver numbers. >=20 > I don't know what is going on here. >=20 > ---------------------------------------------- >=20 > Okay, here is the feedback from reviewing a vm that actually included the c= leanup branch changes. >=20 > The home and ssh items look better with the change. They now use alternatin= g shades of grey to highlight each line. >=20 > All graphs have new selection buttons for Hour, Day, Weekly etc that show i= n red when selected. This looks better. The default is the Day selection but = when you start with a graph it does not indicate that it is using the Day opt= ion, ie all buttons are showing grey. >=20 > Net-Traffic and ExtraHD have the same tables but instead of being centred o= n the page they are now on the Left Hand Side of the WUI page. >=20 > The Zone Config page looks much busier now. Previously the dropdown box for= native or vlan selection was next to the vlan id box and the space was good = enough for that. Now they are placed one above the other, so wider, which is = not needed but they now fill the whole space of the section before the next n= ic interface starts. I think the previous version looked clearer. >=20 > The IPS page and the Services page no longer show the red or green backgrou= nd for running or stopped. You still see the words but they are now in white = on a light grey background or white on a slightly darker grey. >=20 > On the Services page the first graph which should be titled Processes is la= belled 100%. >=20 > On the System page the graphs have no name at all. On the vm I used they sh= ould have been labelled CPU and Load Avg. >=20 > On the Pakfire page the list of available or installed addons do not show t= he pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20 >=20 > The IPSec and OpenVPN pages no longer show the green, red or blue colours f= or the connection status. >=20 > On the Firewall Rules page the table has no colours for Accept, Reject or D= rop for any of the rules. The alternate grey shading has got mixed up as it i= s considering that if there is a remark line for a firewall rule that is a se= parate line and the grey shading has to be changed. Definitely not right. Som= e of the Destinations have not had the right colour code applied for the zone= colour - left grey. The boxes giving the policy applied for each firewall se= ction are not colour coded for Allow or Blocked. >=20 > On the actual firewall creation page, there are longer boxes that overlap l= abels or other elements. There is no colour in the Drop, Reject, Accept selec= tion box just one shade of grey. >=20 > The vulnerabilities page has the left hand section now in black background = with white lettering. Different but probably okay. >=20 > The following menu items showed longer entry boxes that overlap labels or o= ther elements > DHCP > DNS Forward > Static Routes > Wake on LAN > Time Server > Log Settings > Proxy Logs >=20 >=20 > The following menu items showed longer entry boxes that did not overlap oth= er elements but you end up with a much longer box length than is needed for a= day number for example > Firewall Groups > Firewall Options > Blue Access > Log Summary > Dynamic DNS > Proxy reports > Firewall logs > Firewall graphs - IP, Port & Country > IPS Logs > IP Address blocklist logs > OpenVPN RW logs > URL Filter Logs > System Logs > Captive portal > Connection Scheduler > Assign MAC Address >=20 >=20 > The following menu items showed no change/issues except maybe for the graph= period selection buttons . > Backup > Shutdown > Credits > Mailservice > Memory > Media > Network External, Internal and Other > OpenVPN RW and N2N Statistics > WIO > Hardware graphs > Connections > Mdstat > DNS > Web Proxy > URL Filter > Update Accelerator > Edit Hosts > QOS > IP Address Blocklist > Location Block > IPTables >=20 > I am really sorry for giving false hope that the cleanup branch had gone re= ally well. >=20 > Regards, >=20 > Adolf. >=20 > On 01/08/2024 12:50, Adolf Belka wrote: >> Hi Michael, >>=20 >> On 25/07/2024 12:28, Adolf Belka wrote: >>> Hi Michael, >>>=20 >>> On 25/07/2024 10:44, Michael Tremer wrote: >>>> Hello Adolf, >>>>=20 >>>> Thank you for getting back on this so quickly. >>>>=20 >> Maybe I got back too quickly!! >>=20 >> I have just done a build with next for a bugfix patch and installed it int= o my vm and the pages look quite different with some things missing, like the= green and red colours for if services are running or not and some graph titl= es are incorrect. >>=20 >> I took the iso from the latest directory in the nightly build but it looks= like it was still linked to the previous version when I downloaded it as the= b2 sum is for build 6460dbbf from the day before. >>=20 >> Downloading the iso today from the latest directory gives me the build ed2= c97b7. >>=20 >> I am going to install that version now but I suspect it will show the same= as I found with my build. >>=20 >> So it looks like my original review was based on the version before the cl= eanup branch changes were included. >>=20 >> I will come back with new feedback of what I find from the latest branch t= hat I have now downloaded. >>=20 >> Sorry. In future maybe I should wait till the following day, or download f= rom the build named directory instead of the directory named latest. >>=20 >> Regards, >>=20 >> Adolf >>=20 >>>> I suppose this also means that the ISO in the next branch boots just fin= e, too? >>>=20 >>> Yes, that is correct. I used the iso from the nightly next latest directo= ry. No problems with the install at all. >>> This tested out raid and all 4 interfaces. >>>=20 >>> Regards, >>> Adolf. >>>=20 >>>>=20 >>>> Best, >>>> -Michael >>>>=20 >>>>> On 25 Jul 2024, at 09:07, Adolf Belka wrote: >>>>>=20 >>>>> Hi Michael, >>>>>=20 >>>>> I installed CU188 from the nightly onto a vm system and looked though a= ll the WUI pages and everything looked fine. >>>>>=20 >>>>> I then restored a CU187 backup from my testing and then checked the Ope= nVPN RW and N2N. Both worked fine with no problems. Also the logging for that= all worked with no problems. >>>>>=20 >>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS= ... >>>>>=20 >>>>> Everything I have looked at shows no impact from the cleanup branch cha= nges. It looks good to me. >>>>>=20 >>>>> Of course good for others to also evaluate. >>>>>=20 >>>>> Regards, >>>>>=20 >>>>> Adolf. >>>>>=20 > --===============2427040313493364626==--