Re: [PATCH] Add button spacing on 'Firewall/Firewall Groups' page.

[Michael Tremer <michael.tremer@ipfire.org>]

Hello Stephen,

Apologies, I have been working on the mailing list system and last week, something must have locked up in Mailman as it used to do. Adolf also have a lot of patches stuck in the queue.

This was simply because mailman refused to accept any emails and they got stuck in the Postfix queue.

Emails should usually be showing up in the archive pretty much instantaneously and patchwork sometimes takes an extra ten seconds on so.

I have marked the other patches in patchwork so that they won’t show up any more and we can look at the latest one.

Best,
-Michael

> On 5 Mar 2025, at 15:15, Stephen Cuka <stephen@firemypi.org> wrote:
> 
> Hello Michael,
> 
> I did have a problem submitting the patch.  When I first submitted it, I checked patchworks and did not see it posted there.  I figured that it might take some time so I waited about a day and when it still hadn't posted, resent it.  I waited a while again it still didn't show up.  I was trying to figure out what I had done wrong and  realized that all of the other patch descriptions started with the component name in the description.  So, thinking that maybe that was needed for the patch to be uploaded, added that and resent it.  It still didn't show up so I stopped at that point and checked again, maybe a day later, and saw that all of the emails that I sent had been uploaded at once.  I think it was 3 days later that all of them showed up.  I didn't realize that it would take that long.
> 
> Anyway, the patch with the description starting with "fwhosts.cgi:" is the one to look at.  The others can be deleted or cancelled.
> 
> Regards,
> 
> Stephen
> 
> 
> 
> On 3/5/25 04:56, Michael Tremer wrote:
>> Hello Stephen,
>> 
>> Thank you for the patch. I am seeing three emails here which all seem to be almost identical?
>> 
>> Was there a problem submitting the patch or are there actually any changes here which I have missed?
>> 
>> -Michael
>> 
>>> On 27 Feb 2025, at 20:43, Stephen Cuka <stephen@firemypi.org> wrote:
>>> 
>>> Add spacing between showmenu() buttons on Firewall/Firewall Groups page to improve the look of the page.
>>> 
>>> No changes to the functions of the page.
>>> 
>>> Signed-off-by: Stephen Cuka <stephen@firemypi.org>
>>> ---
>>> html/cgi-bin/fwhosts.cgi | 27 +++++++++++++++++++++++----
>>> 1 file changed, 23 insertions(+), 4 deletions(-)
>>> 
>>> diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
>>> index d6be6c40e..d29940b8d 100644
>>> --- a/html/cgi-bin/fwhosts.cgi
>>> +++ b/html/cgi-bin/fwhosts.cgi
>>> @@ -1320,10 +1320,29 @@ sub showmenu {
>>> &Header::openbox('100%', 'left',);
>>> print "$Lang::tr{'fwhost welcome'}";
>>> print<<END;
>>> - <br><br><table border='0' width='100%'>
>>> - <tr><td><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}' ></form></td>
>>> - <td align='right'><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}' ></form></td></tr>
>>> - <tr><td colspan='6'></td></tr></table>
>>> + <br><br>
>>> + <table border='0' width='100%'>
>>> + <tr>
>>> + <td>
>>> + <form method='post'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}'>
>>> + </form>
>>> + </td>
>>> + <td align='right'>
>>> + <form method='post'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}'>
>>> + </form>
>>> + </td>
>>> + </tr>
>>> + <tr>
>>> + <td colspan='6'>
>>> + </td>
>>> + </tr>
>>> + </table>
>>> END
>>> &Header::closebox();
>>> 
>>> -- 
>>> 2.43.0
>>>