Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI for better usability

[Adolf Belka <adolf.belka@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]

Hi Matthias,

On 22/05/2021 16:53, Matthias Fischer wrote:
> Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
>
> Hi,
>
> in the meantime I worked on this - a bit - again. Currently, this CGI is
> running here under Core 156 with no seen problems.
>
> I've made several changes and adjustments.
>
> First:
> - I kept the icons - buttons didn't look as I hoped they would. ;-)
>
> - I kept the old icon order "Download - Delete - Save".
>
> Changelog:
> - Cleaned up the code a bit, some if-queries were unnessecary (if
> ($cgiparams{'ACTION'} eq...).
>
> - Therefore, some lang strings became obsolete ('downloadaddon' and
> 'downloadiso'.
>
> - Separated the ISO files from the IPF files for better overview.
>
> - Added query for deleting a backup file (onclick=\"return confirm...).
>
> - Added 'onclick' feature => deleting a file must be acknowledged.
>
> Biggest change:
> - Added tables - as MT mentioned.
>
> Details can be seen in the attached screenshots.
>
> Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)

It looks okay to me. Alternating shades of grey for the rows as mentioned by Michael would also be fine.

Any chance of a diff so I can try it out on a testbed system?

By the way, FYI there is another backup umbrella bug https://bugzilla.ipfire.org/show_bug.cgi?id=11320

Regards,

Adolf.

> Best,
> Matthias
>