From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI
 for better usability
Date: Wed, 26 May 2021 13:01:39 +0200
Message-ID: <a1bf7fb7-7317-0403-ccf1-da774eb39e77@ipfire.org>
In-Reply-To: <167e8e93-3c40-f85c-9cb5-a552ca1ff9d5@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5992682108716575721=="
List-Id: <development.lists.ipfire.org>

--===============5992682108716575721==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Matthias,

On 22/05/2021 16:53, Matthias Fischer wrote:
> Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=3D12588
>
> Hi,
>
> in the meantime I worked on this - a bit - again. Currently, this CGI is
> running here under Core 156 with no seen problems.
>
> I've made several changes and adjustments.
>
> First:
> - I kept the icons - buttons didn't look as I hoped they would. ;-)
>
> - I kept the old icon order "Download - Delete - Save".
>
> Changelog:
> - Cleaned up the code a bit, some if-queries were unnessecary (if
> ($cgiparams{'ACTION'} eq...).
>
> - Therefore, some lang strings became obsolete ('downloadaddon' and
> 'downloadiso'.
>
> - Separated the ISO files from the IPF files for better overview.
>
> - Added query for deleting a backup file (onclick=3D\"return confirm...).
>
> - Added 'onclick' feature =3D> deleting a file must be acknowledged.
>
> Biggest change:
> - Added tables - as MT mentioned.
>
> Details can be seen in the attached screenshots.
>
> Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)

It looks okay to me. Alternating shades of grey for the rows as mentioned by =
Michael would also be fine.

Any chance of a diff so I can try it out on a testbed system?

By the way, FYI there is another backup umbrella bug https://bugzilla.ipfire.=
org/show_bug.cgi?id=3D11320

Regards,

Adolf.

> Best,
> Matthias
>

--===============5992682108716575721==--