From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcel Lorenz <marcel.lorenz@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH 2/3] dhcp: update lfs file after gzip update to fix build fail
Date: Tue, 08 Mar 2016 18:03:51 +0100
Message-ID: <a1d53b8c882539340a81ef1bdcbdb1b5@mail01.ipfire.org>
In-Reply-To: <1457447211.6973.126.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8924166806138504959=="
List-Id: <development.lists.ipfire.org>

--===============8924166806138504959==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Am 2016-03-08 15:26, schrieb Michael Tremer:
> Hi,
> 
> what is the build issue you are trying to solve here?
> 
> Copying in a highly outdated version of the bind libs is from my point
> of view a big security risk.
> 
> -Michael
> 
> On Tue, 2016-03-08 at 11:09 +0100, Marcel Lorenz wrote:
>> Signed-off-by: Marcel Lorenz <marcel.lorenz(a)ipfire.org>
Hi,

you have right, the old bind is a security risk!

This is the current lfs file without patch:
*****
	cd $(DIR_APP) && patch -Np1 < 
$(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch

	# Remove bundled BIND stuff.
	# (requires newer autoconf)
	#rm -rfv $(DIR_APP)/bind/bind.tar.gz
	#cd $(DIR_APP) && autoreconf --verbose --force --install

	cd $(DIR_APP) && \
*****

The error in log is "use tar axf to extract..."

The old bind is extracted while make runs. After gzip update this not 
working more automatic.
They only need some files from bind archive to built the isc-dhcp 
package. Bind itself is not used.
(When i understood this correct)

The: "cd $(DIR_APP)/bind && tar -axf bind.tar.gz" extract this before 
make runs.. That's all..

Greetings,
Marcel


>> 
>> ---
>>  lfs/dhcp | 10 ++--------
>>  1 file changed, 2 insertions(+), 8 deletions(-)
>> 
>> diff --git a/lfs/dhcp b/lfs/dhcp
>> index 9a89d40..cec8628 100644
>> --- a/lfs/dhcp
>> +++ b/lfs/dhcp
>> @@ -99,17 +99,11 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>>  	cd $(DIR_APP) && patch -Np1 <
>> $(DIR_SRC)/src/patches/dhcp/dhcp-gpxe-cid.patch
>>  	cd $(DIR_APP) && patch -Np1 <
>> $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch
>>  
>> -	# Remove bundled BIND stuff.
>> -	# (requires newer autoconf)
>> -	#rm -rfv $(DIR_APP)/bind/bind.tar.gz
>> -	#cd $(DIR_APP) && autoreconf --verbose --force --install
>> -
>> -	cd $(DIR_APP) && \
>> -		./configure \
>> +	cd $(DIR_APP)/bind && tar -axf bind.tar.gz
>> +	cd $(DIR_APP) && ./configure \
>>  			--prefix=/usr \
>>  			--sysconfdir=/etc/dhcp \
>>  			--with-srv-lease-
>> file=/var/state/dhcp/dhcpd.leases \
>> -			--disable-static \
>>  			--enable-paranoia \
>>  			--enable-early-chroot \
>>  			--disable-dhcpv6


--===============8924166806138504959==--