From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim FitzGeorge <ipfr@tfitzgeorge.me.uk>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/3] network-functions.pl : Compare correct variables in
 network_equal
Date: Sat, 28 Dec 2019 20:57:32 +0000
Message-ID: <a2fbd02c-9c20-351f-54b2-5f236d1f583a@tfitzgeorge.me.uk>
In-Reply-To: <EFE3EFA0-3D9A-4098-997C-A1BEBCC3EBCC@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2826205798938046575=="
List-Id: <development.lists.ipfire.org>

--===============2826205798938046575==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

On 24/12/2019 13:04, Michael Tremer wrote:
> Hello,
>=20
> I am still not sure what you are trying to solve here.
>=20
> &network2bin() has two possible return values:
>=20
> 1) An array with two values
>=20
> Or
>=20
> 2) Undefined

No. It's called in array context so the return value in the latter case
is the list ( undef ).

>=20
> You are now checking if you have an array with any length but two, but this=
 won=E2=80=99t work for undefined. That should at least print a warning that =
you are trying to determine the length of an undefined array.
>=20
> So why is this change needed?

Partly because the return value is an array and partly because the
original code checked the scalar variables $bin1 and $bin2 rather than
the arrays @bin1 and @bin2 containing the return values; since these
scalars aren't used anywhere, network_equal() always returned undef,
which is actually the root cause of my original problem.

Tim

>=20
> -Michael
>=20
>> On 24 Dec 2019, at 13:56, Tim FitzGeorge <ipfr(a)tfitzgeorge.me.uk> wrote:
>>
>> Check result of network2bin is correct rather than checking non-existent
>> variable.
>>
>> Signed-off-by: Tim FitzGeorge <ipfr(a)tfitzgeorge.me.uk>
>> ---
>> config/cfgroot/network-functions.pl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-=
functions.pl
>> index 56b4bceb7..a3f574760 100644
>> --- a/config/cfgroot/network-functions.pl
>> +++ b/config/cfgroot/network-functions.pl
>> @@ -111,7 +111,7 @@ sub network_equal {
>> 	my @bin1 =3D &network2bin($network1);
>> 	my @bin2 =3D &network2bin($network2);
>>
>> -	if (!defined $bin1 || !defined $bin2) {
>> +	if (@bin1 !=3D 2 || @bin2 !=3D 2) {
>> 		return undef;
>> 	}
>>
>> --=20
>> 2.16.4
>>
>=20


--===============2826205798938046575==--