public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript
Date: Tue, 04 Jul 2023 14:52:27 +0200	[thread overview]
Message-ID: <a317cd17-7e8d-3d5d-bc79-f248b2cc75bf@ipfire.org> (raw)
In-Reply-To: <E7AEE500-4A6D-4DA9-BDD0-57CD40471F02@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

So next thing is to see if this updated version works for Peter and Arne or if I have more work to do. :-)

Regards,
Adolf.

On 04/07/2023 11:08, Michael Tremer wrote:
> Thanks. This looks good to me.
> 
> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
> 
>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> - This patch goes together with the patch for the ppp update to 2.5.0
>> - The rp-pppoe.so option is no longer available. There is only the pppoe.so available now
>>
>> Fixes: Bug#13164
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>> src/initscripts/networking/red | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red
>> index 16d48f3ac..75a17bd5a 100644
>> --- a/src/initscripts/networking/red
>> +++ b/src/initscripts/networking/red
>> @@ -365,7 +365,7 @@ case "${1}" in
>> #
>> if [ "$TYPE" == "pppoe" ]; then
>> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \
>> - PLUGOPTS="plugin rp-pppoe.so"
>> + PLUGOPTS="plugin pppoe.so"
>> fi
>>
>> ### Synchronous Mode
>> -- 
>> 2.41.0
>>
> 

  reply	other threads:[~2023-07-04 12:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04  9:04 Adolf Belka
2023-07-04  9:08 ` Michael Tremer
2023-07-04 12:52   ` Adolf Belka [this message]
2023-08-02 14:14     ` Adolf Belka
2023-08-07  9:30       ` Michael Tremer
2023-08-07 10:48         ` Adolf Belka
2023-08-07 14:10           ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a317cd17-7e8d-3d5d-bc79-f248b2cc75bf@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox