From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] Revert "proxy.cgi: Fix for Bug #12826 'squid >=5 crashes on literal IPv6 addresses'" Date: Mon, 08 Jan 2024 18:31:00 +0000 Message-ID: In-Reply-To: <20240108164248.3794991-1-michael.tremer@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0487127632830047810==" List-Id: --===============0487127632830047810== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Acked-by: Peter M=C3=BCller > This reverts commit e0be9eab47d621545e5498c32c0fef39f7ef84a9. >=20 > This change is now producing problems on IPv6-enabled systems as it will > deny access to any website that is IPv6-enabled as well, even if the > client connected using IPv4. >=20 > I have tested if squid is now running on fine on systems where IPv6 is > disabled and can confirm that its running just fine. >=20 > Signed-off-by: Michael Tremer > --- > html/cgi-bin/proxy.cgi | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) >=20 > diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi > index 71be315f6..c8e3576df 100644 > --- a/html/cgi-bin/proxy.cgi > +++ b/html/cgi-bin/proxy.cgi > @@ -3525,19 +3525,9 @@ END > $_ =3D~ s/__PROXY_PORT__/$proxysettings{'PROXY_PORT'}/; > print FILE $_; > } > - print FILE "\n#End of custom includes\n\n"; > + print FILE "\n#End of custom includes\n"; > close (ACL); > } > - > - print FILE < -# Prevent ipv6 requests to avoid crash in squid > 5.x > -acl to_ipv6 dst ipv6 > -acl from_ipv6 src ipv6 > -http_access deny to_ipv6 > -http_access deny from_ipv6 > -END > - ; > - > if ((!-z $extgrp) && ($proxysettings{'AUTH_METHOD'} eq 'ncsa') && ($proxy= settings{'NCSA_BYPASS_REDIR'} eq 'on')) { print FILE "\nredirector_access den= y for_extended_users\n"; } > =20 > # Check if squidclamav is enabled. --===============0487127632830047810==--