public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] WIO: first addon release v1.3.1
Date: Sat, 15 Jul 2017 11:00:36 +0200	[thread overview]
Message-ID: <a4f1fca6-ff93-4fdf-2123-3b4d29ed8a43@ipfire.org> (raw)
In-Reply-To: <1500028015-2271-1-git-send-email-sfeddersen@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

Hi,

On 14.07.2017 12:26, Stephan Feddersen wrote:
> ---
>  config/rootfiles/packages/wio      |   45 +
>  lfs/wio                            |   65 ++
>  ...

Build with and installed on Core111 - running. Thanks, Stefan. ;-)

One thing (nitpicking):

Could you change line 67 in 'wiographs.cgi' from:

print"<table width='100%'><tr><td><a href='/cgi-bin/wio.cgi'><img src='/images/wio/back.png' alt='$Lang::tr{'wio_back'}' title='$Lang::tr{'wio_back'}' /></a></td></tr></table>";

To:
print"<table width='100%'><tr><td align='center'><a href='/cgi-bin/wio.cgi'><img src='/images/wio/back.png' alt='$Lang::tr{'wio_back'}' title='$Lang::tr{'wio_back'}' /></a></td></tr></table>";

This way the 'back.png'-image is centered as in 'showrequestfromip.dat' (e.g.).

Best,
Matthias

  reply	other threads:[~2017-07-15  9:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-14 10:26 Stephan Feddersen
2017-07-15  9:00 ` Matthias Fischer [this message]
2017-07-15  9:04 ` Matthias Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4f1fca6-ff93-4fdf-2123-3b4d29ed8a43@ipfire.org \
    --to=matthias.fischer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox