From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript Date: Mon, 07 Aug 2023 12:48:31 +0200 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4337410727267280806==" List-Id: --===============4337410727267280806== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 07/08/2023 11:30, Michael Tremer wrote: > Hello Adolf, >=20 > As the update has been released, I would say this counts as the testing bei= ng done. Neither this change to the red initscript nor the change of ppp version=20 from 2.4.9 to 2.5.0 have been merged into CU177 or into next. The last video call feedback was that the change of ppp from 2.4.9 to=20 2.5.0 was significant enough that we had to be careful because it could=20 cause people to fail to have a connection. So the decision was that it would be tested within the devs first before=20 releasing it into a Testing release. Regards, Adolf. >=20 > -Michael >=20 >> On 2 Aug 2023, at 16:14, Adolf Belka wrote: >> >> Hi All, >> >> On 04/07/2023 14:52, Adolf Belka wrote: >>> So next thing is to see if this updated version works for Peter and Arne = or if I have more work to do. :-) >>> >> At the last video conf call Peter and Arne mentioned that they are able to= test a pppoe connection with the ppp version update patch I submitted at the= beginning of July. >> >> https://lists.ipfire.org/pipermail/development/2023-July/016101.html >> >> Any progress on the testing. Just let me know if there are any issues that= I need to work on. >> >> Regards, >> Adolf. >> >>> Regards, >>> Adolf. >>> >>> On 04/07/2023 11:08, Michael Tremer wrote: >>>> Thanks. This looks good to me. >>>> >>>> Reviewed-by: Michael Tremer >>>> >>>>> On 4 Jul 2023, at 10:04, Adolf Belka wrote: >>>>> >>>>> - This patch goes together with the patch for the ppp update to 2.5.0 >>>>> - The rp-pppoe.so option is no longer available. There is only the pppo= e.so available now >>>>> >>>>> Fixes: Bug#13164 >>>>> Signed-off-by: Adolf Belka >>>>> --- >>>>> src/initscripts/networking/red | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/src/initscripts/networking/red b/src/initscripts/networkin= g/red >>>>> index 16d48f3ac..75a17bd5a 100644 >>>>> --- a/src/initscripts/networking/red >>>>> +++ b/src/initscripts/networking/red >>>>> @@ -365,7 +365,7 @@ case "${1}" in >>>>> # >>>>> if [ "$TYPE" =3D=3D "pppoe" ]; then >>>>> [ "${METHOD}" =3D=3D "PPPOE_PLUGIN" ] && \ >>>>> - PLUGOPTS=3D"plugin rp-pppoe.so" >>>>> + PLUGOPTS=3D"plugin pppoe.so" >>>>> fi >>>>> >>>>> ### Synchronous Mode >>>>> --=20 >>>>> 2.41.0 >>>>> >>>> >> >> --=20 >> Sent from my laptop >=20 >=20 --=20 Sent from my laptop --===============4337410727267280806==--