[PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript

[PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 769 bytes --]

- This patch goes together with the patch for the ppp update to 2.5.0
- The rp-pppoe.so option is no longer available. There is only the pppoe.so available now

Fixes: Bug#13164
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
 src/initscripts/networking/red | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red
index 16d48f3ac..75a17bd5a 100644
--- a/src/initscripts/networking/red
+++ b/src/initscripts/networking/red
@@ -365,7 +365,7 @@ case "${1}" in
 			#
 			if [ "$TYPE" == "pppoe" ]; then
 				[ "${METHOD}" == "PPPOE_PLUGIN" ] && \
-					PLUGOPTS="plugin rp-pppoe.so"
+					PLUGOPTS="plugin pppoe.so"
 			fi
 
 			### Synchronous Mode
-- 
2.41.0

Re: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

Thanks. This looks good to me.

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> - This patch goes together with the patch for the ppp update to 2.5.0
> - The rp-pppoe.so option is no longer available. There is only the pppoe.so available now
> 
> Fixes: Bug#13164
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> src/initscripts/networking/red | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red
> index 16d48f3ac..75a17bd5a 100644
> --- a/src/initscripts/networking/red
> +++ b/src/initscripts/networking/red
> @@ -365,7 +365,7 @@ case "${1}" in
> #
> if [ "$TYPE" == "pppoe" ]; then
> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \
> - PLUGOPTS="plugin rp-pppoe.so"
> + PLUGOPTS="plugin pppoe.so"
> fi
> 
> ### Synchronous Mode
> -- 
> 2.41.0
> 

Re: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

So next thing is to see if this updated version works for Peter and Arne or if I have more work to do. :-)

Regards,
Adolf.

On 04/07/2023 11:08, Michael Tremer wrote:
> Thanks. This looks good to me.
> 
> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
> 
>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> - This patch goes together with the patch for the ppp update to 2.5.0
>> - The rp-pppoe.so option is no longer available. There is only the pppoe.so available now
>>
>> Fixes: Bug#13164
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>> src/initscripts/networking/red | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red
>> index 16d48f3ac..75a17bd5a 100644
>> --- a/src/initscripts/networking/red
>> +++ b/src/initscripts/networking/red
>> @@ -365,7 +365,7 @@ case "${1}" in
>> #
>> if [ "$TYPE" == "pppoe" ]; then
>> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \
>> - PLUGOPTS="plugin rp-pppoe.so"
>> + PLUGOPTS="plugin pppoe.so"
>> fi
>>
>> ### Synchronous Mode
>> -- 
>> 2.41.0
>>
> 

Re: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

Hi All,

On 04/07/2023 14:52, Adolf Belka wrote:
> So next thing is to see if this updated version works for Peter and 
> Arne or if I have more work to do. :-)
>
At the last video conf call Peter and Arne mentioned that they are able 
to test a pppoe connection with the ppp version update patch I submitted 
at the beginning of July.

https://lists.ipfire.org/pipermail/development/2023-July/016101.html

Any progress on the testing. Just let me know if there are any issues 
that I need to work on.

Regards,
Adolf.

> Regards,
> Adolf.
>
> On 04/07/2023 11:08, Michael Tremer wrote:
>> Thanks. This looks good to me.
>>
>> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>
>>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>
>>> - This patch goes together with the patch for the ppp update to 2.5.0
>>> - The rp-pppoe.so option is no longer available. There is only the 
>>> pppoe.so available now
>>>
>>> Fixes: Bug#13164
>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>> ---
>>> src/initscripts/networking/red | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/initscripts/networking/red 
>>> b/src/initscripts/networking/red
>>> index 16d48f3ac..75a17bd5a 100644
>>> --- a/src/initscripts/networking/red
>>> +++ b/src/initscripts/networking/red
>>> @@ -365,7 +365,7 @@ case "${1}" in
>>> #
>>> if [ "$TYPE" == "pppoe" ]; then
>>> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \
>>> - PLUGOPTS="plugin rp-pppoe.so"
>>> + PLUGOPTS="plugin pppoe.so"
>>> fi
>>>
>>> ### Synchronous Mode
>>> -- 
>>> 2.41.0
>>>
>>

-- 
Sent from my laptop

Re: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1925 bytes --]

Hello Adolf,

As the update has been released, I would say this counts as the testing being done.

-Michael

> On 2 Aug 2023, at 16:14, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi All,
> 
> On 04/07/2023 14:52, Adolf Belka wrote:
>> So next thing is to see if this updated version works for Peter and Arne or if I have more work to do. :-)
>> 
> At the last video conf call Peter and Arne mentioned that they are able to test a pppoe connection with the ppp version update patch I submitted at the beginning of July.
> 
> https://lists.ipfire.org/pipermail/development/2023-July/016101.html
> 
> Any progress on the testing. Just let me know if there are any issues that I need to work on.
> 
> Regards,
> Adolf.
> 
>> Regards,
>> Adolf.
>> 
>> On 04/07/2023 11:08, Michael Tremer wrote:
>>> Thanks. This looks good to me.
>>> 
>>> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>> 
>>>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>> 
>>>> - This patch goes together with the patch for the ppp update to 2.5.0
>>>> - The rp-pppoe.so option is no longer available. There is only the pppoe.so available now
>>>> 
>>>> Fixes: Bug#13164
>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>> ---
>>>> src/initscripts/networking/red | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>> 
>>>> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red
>>>> index 16d48f3ac..75a17bd5a 100644
>>>> --- a/src/initscripts/networking/red
>>>> +++ b/src/initscripts/networking/red
>>>> @@ -365,7 +365,7 @@ case "${1}" in
>>>> #
>>>> if [ "$TYPE" == "pppoe" ]; then
>>>> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \
>>>> - PLUGOPTS="plugin rp-pppoe.so"
>>>> + PLUGOPTS="plugin pppoe.so"
>>>> fi
>>>> 
>>>> ### Synchronous Mode
>>>> -- 
>>>> 2.41.0
>>>> 
>>> 
> 
> -- 
> Sent from my laptop

Re: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 2530 bytes --]

Hi Michael,

On 07/08/2023 11:30, Michael Tremer wrote:
> Hello Adolf,
> 
> As the update has been released, I would say this counts as the testing being done.
Neither this change to the red initscript nor the change of ppp version 
from 2.4.9 to 2.5.0 have been merged into CU177 or into next.

The last video call feedback was that the change of ppp from 2.4.9 to 
2.5.0 was significant enough that we had to be careful because it could 
cause people to fail to have a connection.
So the decision was that it would be tested within the devs first before 
releasing it into a Testing release.

Regards,

Adolf.
> 
> -Michael
> 
>> On 2 Aug 2023, at 16:14, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> Hi All,
>>
>> On 04/07/2023 14:52, Adolf Belka wrote:
>>> So next thing is to see if this updated version works for Peter and Arne or if I have more work to do. :-)
>>>
>> At the last video conf call Peter and Arne mentioned that they are able to test a pppoe connection with the ppp version update patch I submitted at the beginning of July.
>>
>> https://lists.ipfire.org/pipermail/development/2023-July/016101.html
>>
>> Any progress on the testing. Just let me know if there are any issues that I need to work on.
>>
>> Regards,
>> Adolf.
>>
>>> Regards,
>>> Adolf.
>>>
>>> On 04/07/2023 11:08, Michael Tremer wrote:
>>>> Thanks. This looks good to me.
>>>>
>>>> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>>>
>>>>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>
>>>>> - This patch goes together with the patch for the ppp update to 2.5.0
>>>>> - The rp-pppoe.so option is no longer available. There is only the pppoe.so available now
>>>>>
>>>>> Fixes: Bug#13164
>>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>>> ---
>>>>> src/initscripts/networking/red | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red
>>>>> index 16d48f3ac..75a17bd5a 100644
>>>>> --- a/src/initscripts/networking/red
>>>>> +++ b/src/initscripts/networking/red
>>>>> @@ -365,7 +365,7 @@ case "${1}" in
>>>>> #
>>>>> if [ "$TYPE" == "pppoe" ]; then
>>>>> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \
>>>>> - PLUGOPTS="plugin rp-pppoe.so"
>>>>> + PLUGOPTS="plugin pppoe.so"
>>>>> fi
>>>>>
>>>>> ### Synchronous Mode
>>>>> -- 
>>>>> 2.41.0
>>>>>
>>>>
>>
>> -- 
>> Sent from my laptop
> 
> 

-- 
Sent from my laptop

Re: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 2816 bytes --]

Ah, that is not good then.

Where did those patches go? I will dig them up and merge them into the next update.

-Michael

> On 7 Aug 2023, at 12:48, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> On 07/08/2023 11:30, Michael Tremer wrote:
>> Hello Adolf,
>> As the update has been released, I would say this counts as the testing being done.
> Neither this change to the red initscript nor the change of ppp version from 2.4.9 to 2.5.0 have been merged into CU177 or into next.
> 
> The last video call feedback was that the change of ppp from 2.4.9 to 2.5.0 was significant enough that we had to be careful because it could cause people to fail to have a connection.
> So the decision was that it would be tested within the devs first before releasing it into a Testing release.
> 
> Regards,
> 
> Adolf.
>> -Michael
>>> On 2 Aug 2023, at 16:14, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> Hi All,
>>> 
>>> On 04/07/2023 14:52, Adolf Belka wrote:
>>>> So next thing is to see if this updated version works for Peter and Arne or if I have more work to do. :-)
>>>> 
>>> At the last video conf call Peter and Arne mentioned that they are able to test a pppoe connection with the ppp version update patch I submitted at the beginning of July.
>>> 
>>> https://lists.ipfire.org/pipermail/development/2023-July/016101.html
>>> 
>>> Any progress on the testing. Just let me know if there are any issues that I need to work on.
>>> 
>>> Regards,
>>> Adolf.
>>> 
>>>> Regards,
>>>> Adolf.
>>>> 
>>>> On 04/07/2023 11:08, Michael Tremer wrote:
>>>>> Thanks. This looks good to me.
>>>>> 
>>>>> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>>>> 
>>>>>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>> 
>>>>>> - This patch goes together with the patch for the ppp update to 2.5.0
>>>>>> - The rp-pppoe.so option is no longer available. There is only the pppoe.so available now
>>>>>> 
>>>>>> Fixes: Bug#13164
>>>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>>>> ---
>>>>>> src/initscripts/networking/red | 2 +-
>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>> 
>>>>>> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red
>>>>>> index 16d48f3ac..75a17bd5a 100644
>>>>>> --- a/src/initscripts/networking/red
>>>>>> +++ b/src/initscripts/networking/red
>>>>>> @@ -365,7 +365,7 @@ case "${1}" in
>>>>>> #
>>>>>> if [ "$TYPE" == "pppoe" ]; then
>>>>>> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \
>>>>>> - PLUGOPTS="plugin rp-pppoe.so"
>>>>>> + PLUGOPTS="plugin pppoe.so"
>>>>>> fi
>>>>>> 
>>>>>> ### Synchronous Mode
>>>>>> -- 
>>>>>> 2.41.0
>>>>>> 
>>>>> 
>>> 
>>> -- 
>>> Sent from my laptop
> 
> -- 
> Sent from my laptop