From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Lorenz To: development@lists.ipfire.org Subject: Re: [PATCH] libtirpc: change from package to common Date: Thu, 07 Jul 2016 21:02:36 +0200 Message-ID: In-Reply-To: <1467710815.1574.0@mail01.ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5969599365454186987==" List-Id: --===============5969599365454186987== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Jonatan, thx for support me... :) i make my patches, if it working on IPFire, identical to Linux from=20 Scratch. For this lib:=20 http://www.linuxfromscratch.org/blfs/view/svn/basicnet/libtirpc.html if their other notions have, please tell me share this with. So I can create the patch as desired. For me it is important that it=20 just works ... (google translator) if you wish, i make it new without --prefix=3D/usr and mv -v=20 /usr/lib/libtirpc.so regards Marcel Am 2016-07-05 11:26, schrieb Jonatan Schlag: > Hi, >=20 > Am So, 26. Jun, 2016 um 10:23 schrieb Marcel Lorenz > : >=20 >> This patch changes the lib from a package to common lsof 4.98 need >> this lib for working. The lib are moved to /lib. This is the >> recommendation from: >> http://www.linuxfromscratch.org/blfs/view/svn/basicnet/libtirpc.html >> Signed-off-by: Marcel Lorenz --- >> config/rootfiles/{packages =3D> common}/libtirpc | 7 +++---- >> lfs/libtirpc | 21 ++++++++++----------- 2 files changed, 13 >> insertions(+), 15 deletions(-) rename config/rootfiles/{packages =3D> >> common}/libtirpc (95%) diff --git >> a/config/rootfiles/packages/libtirpc >> b/config/rootfiles/common/libtirpc similarity index 95% rename from >> config/rootfiles/packages/libtirpc rename to >> config/rootfiles/common/libtirpc index e197563..02cf846 100644 --- >> a/config/rootfiles/packages/libtirpc +++ >> b/config/rootfiles/common/libtirpc @@ -1,4 +1,6 @@ etc/netconfig >> +lib/libtirpc.so.3 +lib/libtirpc.so.3.0.0 #usr/include/tirpc >> #usr/include/tirpc/netconfig.h #usr/include/tirpc/rpc @@ -33,11 >> +35,8 @@ etc/netconfig #usr/include/tirpc/rpcsvc >> #usr/include/tirpc/rpcsvc/crypt.h #usr/include/tirpc/rpcsvc/crypt.x >> -#usr/lib/libtirpc.a #usr/lib/libtirpc.la -#usr/lib/libtirpc.so >> -usr/lib/libtirpc.so.3 -usr/lib/libtirpc.so.3.0.0 >> +usr/lib/libtirpc.so #usr/lib/pkgconfig/libtirpc.pc >> #usr/share/man/man3/bindresvport.3t #usr/share/man/man3/des_crypt.3t >> diff --git a/lfs/libtirpc b/lfs/libtirpc index 382d7e5..65466d0 >> 100644 --- a/lfs/libtirpc +++ b/lfs/libtirpc @@ -1,7 +1,7 @@ >>=20 > ###########################################################################= #### >> # # # IPFire.org - A linux based firewall # -# Copyright (C) 2016 >> IPFire Team # +# Copyright (C) 2016 IPFire Team >> # # # # This program is free software: you can >> redistribute it and/or modify # # it under the terms of the GNU >> General Public License as published by # @@ -31,10 +31,6 @@ DL_FILE >> =3D $(THISAPP).tar.bz2 DL_FROM =3D $(URL_IPFIRE) DIR_APP =3D >> $(DIR_SRC)/$(THISAPP) TARGET =3D $(DIR_INFO)/$(THISAPP) -PROG =3D >> libtirpc -PAK_VER =3D 1 - -DEPS =3D "" >>=20 > ###########################################################################= #### >> # Top-level Rules @@ -54,9 +50,6 @@ download :$(patsubst >> %,$(DIR_DL)/%,$(objects)) md5 : $(subst %,%_MD5,$(objects)) -dist: - >> @$(PAK) - >>=20 > ###########################################################################= #### >> # Downloading, checking, md5sum >>=20 > ###########################################################################= #### >> @@ -76,9 +69,15 @@ $(subst %,%_MD5,$(objects)) : $(TARGET) : >> $(patsubst %,$(DIR_DL)/%,$(objects)) @$(PREBUILD) - @rm -rf >> $(DIR_APP) && cd $(DIR_SRC) && tar jxf $(DIR_DL)/$(DL_FILE) - cd >> $(DIR_APP) && ./configure --prefix=3D/usr --sysconfdir=3D/etc >> --disable-gssapi --disable-ipv6 - cd $(DIR_APP) && make >> $(MAKETUNING) $(EXTRA_MAKE) + @rm -rf $(DIR_APP) && cd $(DIR_SRC) && >> tar axf $(DIR_DL)/$(DL_FILE) + cd $(DIR_APP) && ./configure >> --prefix=3D/usr \ + --sysconfdir=3D/etc \ + --disable-static \ + >> --disable-gssapi \ + --disable-ipv6 + cd $(DIR_APP) && make >> $(MAKETUNING) cd $(DIR_APP) && make install + mv -v >> /usr/lib/libtirpc.so.* /lib + ln -sfv /lib/libtirpc.so.3.0.0 >> /usr/lib/libtirpc.so >=20 > From my point of view are this 2 commands completely unnecessary, > because /usr is not on a separate partition. When /lib is available > /usr is also available. > So I would suggest removing this 2 commands and leave the libs where > they are installed. >=20 > Otherwise, the patch looks fine. >=20 >> @rm -rf $(DIR_APP) @$(POSTBUILD) >> -- 1.9.1 >=20 > regards Jonatan --===============5969599365454186987==--