From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] QoS: Do not try to unload any kernel modules
Date: Wed, 17 Nov 2021 20:15:38 +0000 [thread overview]
Message-ID: <a67d547d-6116-0ea7-603f-c2d3582636c6@ipfire.org> (raw)
In-Reply-To: <20211102105310.22809-1-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
Hello Michael,
could you elaborate more on this one?
From my basic understanding, QoS should not try to unload kernel modules indeed,
but I did not get why it was doing so in the first place.
Thanks, and best regards,
Peter Müller
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> config/qos/makeqosscripts.pl | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/config/qos/makeqosscripts.pl b/config/qos/makeqosscripts.pl
> index 0694bb78c..3234ab366 100644
> --- a/config/qos/makeqosscripts.pl
> +++ b/config/qos/makeqosscripts.pl
> @@ -510,8 +510,6 @@ print <<END
> iptables -t mangle --flush QOS-INC >/dev/null 2>&1
> iptables -t mangle --delete-chain QOS-INC >/dev/null 2>&1
>
> - rmmod sch_htb >/dev/null 2>&1
> -
> for i in \$(ls \$RRDLOG/class_*.rrd); do
> rrdtool update \$i \$(date +%s):
> done
>
next prev parent reply other threads:[~2021-11-17 20:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 10:53 Michael Tremer
2021-11-17 20:15 ` Peter Müller [this message]
2021-11-18 11:14 ` Michael Tremer
2021-11-19 6:26 ` Peter Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a67d547d-6116-0ea7-603f-c2d3582636c6@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox