From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] QoS: Do not try to unload any kernel modules
Date: Wed, 17 Nov 2021 20:15:38 +0000
Message-ID: <a67d547d-6116-0ea7-603f-c2d3582636c6@ipfire.org>
In-Reply-To: <20211102105310.22809-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3758874342518248913=="
List-Id: <development.lists.ipfire.org>

--===============3758874342518248913==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Michael,

could you elaborate more on this one?

 From my basic understanding, QoS should not try to unload kernel modules ind=
eed,
but I did not get why it was doing so in the first place.

Thanks, and best regards,
Peter M=C3=BCller


> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>   config/qos/makeqosscripts.pl | 2 --
>   1 file changed, 2 deletions(-)
>=20
> diff --git a/config/qos/makeqosscripts.pl b/config/qos/makeqosscripts.pl
> index 0694bb78c..3234ab366 100644
> --- a/config/qos/makeqosscripts.pl
> +++ b/config/qos/makeqosscripts.pl
> @@ -510,8 +510,6 @@ print <<END
>   	iptables -t mangle --flush  QOS-INC >/dev/null 2>&1
>   	iptables -t mangle --delete-chain QOS-INC >/dev/null 2>&1
>  =20
> -	rmmod sch_htb >/dev/null 2>&1
> -
>   	for i in \$(ls \$RRDLOG/class_*.rrd); do
>   		rrdtool update \$i \$(date +%s):
>   	done
>=20

--===============3758874342518248913==--