From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] embed background image in redirect template Date: Wed, 27 Jun 2018 23:10:00 +0200 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3542642950773020446==" List-Id: --===============3542642950773020446== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, is it okay for you if we insert the base64 encoded image into the HTML page during running a Pakfire build? That way, we won't need a CGI nor execute this sever-side multiple times. I thought of a sed-command in an lfs file... Best regards, Peter M=C3=BCller > Hello, >=20 > although I generally agree with the fix, this is not the best solution. When > ever the image file is changed, this needs to be manually changed, too. Tha= t's > not nice. >=20 > It would be better to read the image file when rendering the HTML output and > encoding it into base64 on the fly. >=20 > Best, > -Michael >=20 > On Sat, 2018-06-16 at 20:48 +0200, Peter M=C3=BCller wrote: >> Embed the IPFire background image into the redirect template >> directly via CSS instead of loading it from somewhere else. >=20 >> This is necessary because of Content Security Policy (CSP) and >> fixes #11650. >=20 >> Signed-off-by: Peter M=C3=BCller >> --- >> html/html/redirect-templates/legacy/template.html | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >=20 >> diff --git a/html/html/redirect-templates/legacy/template.html >> b/html/html/redirect-templates/legacy/template.html >> index b5fb61ebe..8a6a563a3 100644 >> --- a/html/html/redirect-templates/legacy/template.html >> +++ b/html/html/redirect-templates/legacy/template.html >> @@ -3,11 +3,17 @@ >> >> > charset=3Dutf-8">=20 >> ACCESS MESSAGE >> + >> >> >> >> >> - >> >>
> align=3D"center" background=3D"/images/backgrou= nd.gif"> >> + > align=3D"center" class=3D"image"> 
>> > width=3D'80%'> >=20 --=20 "We don't care. We don't have to. We're the Phone Company." --===============3542642950773020446== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ2dBZEZpRUV2UDRTaUdoRVlE SnlyUkxrMlVqeUQzMTduMmdGQWxzei9TZ0FDZ2tRMlVqeUQzMTcKbjJoRzh4QUFtK1lleTBaTnRT Q3BOMmRtV3NNWk40eHJQNzdVNDNYM2Q2YWZ3Yk55dGVpQ0ZHdkVINVRWbEV2TgpKVWFQRExpc3Jq MWRlTFpQTHd3WENZamtOM0RWa1RyeEt2NWxuWTF2bHA4SXBlUi9xZkJXNkVPdzhUS0pzcWMxCjNU NmQ5czlneXI2dURPc0R5U0pobllHSjdPU2ROYmI4NTV3dGJiYWg1TU5sWEtoeXFxTWtMa09NSWpm RnBHZHkKd2JVUlRHdk9MTElCcEtlcm02dFhiZU92V0dXQUxRMjZXRW1tVlVwSnZrWkZ0ZkgrbXVQ bXgvWmY0R09GUVUrSQpTaFZJVnoxenU2bnhVNjNHc2Rxbk9YcW5sOGxEaFFYRVFvbFREK3RLSzBR cW9sSWZvV0E1TGt3UXU0Vm5oT1VkCisxZWp2Mkdha1RSem9zQW1KT3U5NGgyZGw2QUs0MStrbHR3 RDUvZ3BOQkMwS1hCeWZDSlR4cDVGVXRrV3gyR24KWXBuU1pxVUcrRnhhU045Q1pOQzVDTVNsaGpu MnRtZVJJK2o1c0V2NTMvTWMxN2Ewd3R3ZlFOWmtmNE5GWUN1RQpDTXh4MjFtcDh0SWRCeVZuVmJr VFFRQWM2NmljNEROSklKTGdJZzJDeGlBeXNuanFDNFpjWU5Tck81eURreXR4Cktpbnc1eVM1TU9t akVXZ0dXWlpyb2pzZHFHaldPUnh1YWlOOGs4Zk8zREJRWlJEN2dsWXlKZzM5MVIrSnFvR0EKNldS d2FKc1RoVFF1MWJHTkg3NzYyWko4cnlpekJzNW9HWi9Pa24zcmJDUWgrZDdXUEdMRTgyd0IrWHIv czk5VAo0TzdCWmtEOHJIMXpXTUFJMjZkZFZES1BDVnVoOHJIeGo3MXAvR0FYRzlsVjFmMm9qc1U9 Cj14UGVlCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============3542642950773020446==--