public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: IPFire Italia <ipfire@ipfireitalia.it>
Cc: "IPFire: Development-List" <development@lists.ipfire.org>
Subject: Re: Modifications to the captive portal system
Date: Thu, 17 Sep 2026 13:08:23 +0200	[thread overview]
Message-ID: <a9129537-143d-43f4-8eaf-12cdde6d0192@ipfire.org> (raw)
In-Reply-To: <!&!AAAAAAAAAAAYAAAAAAAAABaDkl9PA2BMpKogWz19lUXCgAAAEAAAALDjoeLZUfBKpC2m6BU1jrIBAAAAAA==@ipfireitalia.it>

Hallo Umberto,

Sorry for my latish reply to your original development list email and your PM on the forum but I have been very involved in a lot of other things and have had limited time available.

In your PM and in the message below you have referred to doing your git work in github. You need to be using git and not github. All the IPFire documents are related to using git and not github.

I am using a desktop system for my git work but it could also be done on a server system with console or ssh access or on a laptop, or even on an IPFire system.

First you need to set up a build environment.

https://www.ipfire.org/docs/devel/ipfire-2-x/build-initial

then after having set that up you need to clone the IPFire-2.x git repo into the environment you have set up.

https://www.ipfire.org/docs/devel/ipfire-2-x/build-howto

Then in that cloned git tree you can make your branch for the captive project you are working on and then make the changes you want in that branch.

Then you carry out a commit on your ipfire repo with the command

git commit -sv


To be able to send your commit via email you need to edit the file .git/config and add the lines

[sendemail]
	to = development@lists.ipfire.org

to it and save.

For the global git settings follow the instructions in

https://www.ipfire.org/docs/devel/git/setup

which includes setting up how to send the email to the IPFire email system, using your IPFire People username and email address.

Once all the above is set up ( it takes less time than it has taken me to write it ) then when you have made your edits to captive.cgi in you git repo and run git commit -sv to add in your commit message explaining the changes then you run

git format-patch -1 -o /"path to where you want to save the patch file to be emailed"

The -1 means to create the formatted patch file using the single commit that was last made.

You will then end up with a .patch file containing the details of your changes in the directory that you specified.

Then run git send-email "path to the patch file that was saved".

A question will then be asked and the simplest is to enter a for All and it will then send that patch file to the IPFire email server as defined by the global settings defined earlier above.

Have a go with the above and come back with any questions that you have.

Regards,

Adolf.


On 17/09/2026 11:19, IPFire Italia wrote:
> Good morning everyone,
> 
> As indicated in the forum thread https://community.ipfire.org/t/modified-captive-system/16141 <https://community.ipfire.org/t/modified-captive-system/16141>, I have modified the pages that manage the captive portal system, adding features I felt were missing.
> 
> Three pages were modified:
> 
> /srv/web/ipfire/cgi-bin/captive.cgi
> 
> /srv/web/ipfire/cgi-bin/captive/index.cgi
> 
> /srv/web/ipfire/html/captive/template.html
> 
> The first file I am posting here is `captive.cgi`.
> 
> It includes a text box to specify the Wi-Fi network SSID, which is then printed on the PDF when exporting coupons.
> 
> I added a second language option for the terms of use: one version in the local language and a second in English.
> 
> There is also a new section allowing devices to be added without going through the coupon authentication page—useful for IoT devices and the like.
> 
> I have tested all the code on my home device with various mobile devices and PCs, and everything worked perfectly.
> 
> I am not familiar with Git,
> 
> https://github.com/ParmaU/IPFire_Captive/pull/1/changes
> 
> Umberto P.
> 



  reply	other threads:[~2026-09-17 11:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  9:19 IPFire Italia
2026-09-17 11:08 ` Adolf Belka [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-09-13 12:43 IPFire Italia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9129537-143d-43f4-8eaf-12cdde6d0192@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    --cc=ipfire@ipfireitalia.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox