Re: [PATCH 1/6] lldpd: New package

[Adolf Belka <adolf.belka@ipfire.org>]

Reviewed-by: Adolf Belka <adolf.belka@ipfire.org>

Hi Michael,

llpd has a configure option --disable-static to remove the .a file from the rootfile.

I am not sure if the doc and man files are doxygen based or not but if they are then there are also --disable-doxygen-doc and --disable-doxygen-man options, which would remove those from the rootfile also.

If you do edit the file then you could update the year for the LFS file from 2024 to 2025.

Regards,

Adolf.

On 06/11/2025 17:46, Michael Tremer wrote:
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>   config/rootfiles/common/lldpd | 25 ++++++++++
>   lfs/lldpd                     | 87 +++++++++++++++++++++++++++++++++++
>   make.sh                       |  1 +
>   3 files changed, 113 insertions(+)
>   create mode 100644 config/rootfiles/common/lldpd
>   create mode 100644 lfs/lldpd
> 
> diff --git a/config/rootfiles/common/lldpd b/config/rootfiles/common/lldpd
> new file mode 100644
> index 000000000..7ead3d00b
> --- /dev/null
> +++ b/config/rootfiles/common/lldpd
> @@ -0,0 +1,25 @@
> +#etc/lldpd.d
> +#etc/lldpd.d/README.conf
> +#usr/include/lldp-const.h
> +#usr/include/lldpctl.h
> +#usr/include/lldpctl.hpp
> +#usr/lib/liblldpctl.a
> +#usr/lib/liblldpctl.la
> +#usr/lib/liblldpctl.so
> +usr/lib/liblldpctl.so.4
> +usr/lib/liblldpctl.so.4.10.0
> +#usr/lib/pkgconfig/lldpctl.pc
> +usr/sbin/lldpcli
> +usr/sbin/lldpctl
> +usr/sbin/lldpd
> +#usr/share/bash-completion/completions/lldpcli
> +#usr/share/doc/lldpd
> +#usr/share/doc/lldpd/CONTRIBUTE.md
> +#usr/share/doc/lldpd/ChangeLog
> +#usr/share/doc/lldpd/LICENSE
> +#usr/share/doc/lldpd/NEWS
> +#usr/share/doc/lldpd/README.md
> +#usr/share/man/man8/lldpcli.8
> +#usr/share/man/man8/lldpctl.8
> +#usr/share/man/man8/lldpd.8
> +#usr/share/zsh/site-functions/_lldpcli
> diff --git a/lfs/lldpd b/lfs/lldpd
> new file mode 100644
> index 000000000..30302e823
> --- /dev/null
> +++ b/lfs/lldpd
> @@ -0,0 +1,87 @@
> +###############################################################################
> +#                                                                             #
> +# IPFire.org - A linux based firewall                                         #
> +# Copyright (C) 2007-2024  IPFire Team  <info@ipfire.org>                     #
> +#                                                                             #
> +# This program is free software: you can redistribute it and/or modify        #
> +# it under the terms of the GNU General Public License as published by        #
> +# the Free Software Foundation, either version 3 of the License, or           #
> +# (at your option) any later version.                                         #
> +#                                                                             #
> +# This program is distributed in the hope that it will be useful,             #
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
> +# GNU General Public License for more details.                                #
> +#                                                                             #
> +# You should have received a copy of the GNU General Public License           #
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
> +#                                                                             #
> +###############################################################################
> +
> +###############################################################################
> +# Definitions
> +###############################################################################
> +
> +include Config
> +
> +VER        = 1.0.20
> +
> +THISAPP    = lldpd-$(VER)
> +DL_FILE    = $(THISAPP).tar.gz
> +DL_FROM    = $(URL_IPFIRE)
> +DIR_APP    = $(DIR_SRC)/$(THISAPP)
> +TARGET     = $(DIR_INFO)/$(THISAPP)
> +
> +###############################################################################
> +# Top-level Rules
> +###############################################################################
> +
> +objects = $(DL_FILE)
> +
> +$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> +
> +$(DL_FILE)_BLAKE2 = 95743f28d9b3c8ad6f354f7def5f835d9b0668c151ad429dccfc7a249e29234a9ca1fda6b3bcc2890c424053b5adf2d4d9d7c0cb2887e97cc32b42577b91c63a
> +
> +install : $(TARGET)
> +
> +check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> +
> +download :$(patsubst %,$(DIR_DL)/%,$(objects))
> +
> +b2 : $(subst %,%_BLAKE2,$(objects))
> +
> +dist:
> +	$(PAK)
> +
> +###############################################################################
> +# Downloading, checking, b2sum
> +###############################################################################
> +
> +$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> +	@$(CHECK)
> +
> +$(patsubst %,$(DIR_DL)/%,$(objects)) :
> +	@$(LOAD)
> +
> +$(subst %,%_BLAKE2,$(objects)) :
> +	@$(B2SUM)
> +
> +###############################################################################
> +# Installation Details
> +###############################################################################
> +
> +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> +	@$(PREBUILD)
> +	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
> +	cd $(DIR_APP) && ./configure \
> +		--prefix=/usr \
> +		--sysconfdir=/etc \
> +		--localstatedir=/var \
> +		--with-seccomp \
> +		--with-privsep-user=nobody \
> +		--with-privsep-group=nobody \
> +		--without-embedded-libevent
> +	cd $(DIR_APP) && make $(MAKETUNING)
> +	cd $(DIR_APP) && make install
> +	@rm -rf $(DIR_APP)
> +	@$(POSTBUILD)
> diff --git a/make.sh b/make.sh
> index b17e90e13..c542c8173 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -2125,6 +2125,7 @@ build_system() {
>   	lfsmake2 fort-validator
>   	lfsmake2 arpwatch
>   	lfsmake2 suricata-reporter
> +	lfsmake2 lldpd
>   
>   	lfsmake2 linux
>   	lfsmake2 rtl8812au