From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4bW1k21WmMz33gn for ; Mon, 30 Jun 2025 09:55:22 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R11" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4bW1jy4k6Bz336v for ; Mon, 30 Jun 2025 09:55:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4bW1jx1tvVzGg; Mon, 30 Jun 2025 09:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1751277317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sKnbIEARJlUDg/xXAK6WDzQdi9DW8FriAeZ0ckEt5fs=; b=N3Ec1aKACbhxUrTBH/9RRlkt5rvZyYD57zwqNy/D0zqnnhbKJMc9jveQ0eW8ZU0emDYCKd gv/PX4DhIssrsV1E4Z6OFgmMaEkNoiB/J+a1pk3uDWdjIHZWQ81jrlbFCWrIIHNokfieJ3 MO3y4M8zRM+UUUtWK+mqXV7KBp7qWXi3vvU95W8ordRAM8RuJXhkHf6fIlE8kVwSjW8SpD 0LyWQbS0DVC31V0Pj1uPGDocZPEwEo7FnfTdea6mC4zmCwVg+3FcuUIx7RuelZjDxHhoW6 NFvbPQg0l0tAsIjuOp2LsJ8vqMRcsxxWnjmwBelekkx+4p0i9Tcwf/K9IowezA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1751277317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sKnbIEARJlUDg/xXAK6WDzQdi9DW8FriAeZ0ckEt5fs=; b=nM25x6svN5FGT8SNmEkfEMCgUyDx/qCwR+JBMLq6pbW+pqk568uzR5CfVB80Tli61FPePe KskgRSl0mIFdmGCg== Message-ID: Date: Mon, 30 Jun 2025 11:55:14 +0200 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Subject: Re: Feedback on the branch openvpn-rebase To: Michael Tremer References: <1396727E-BF73-4015-B853-B3F854806B28@ipfire.org> <7FE631A7-BAF8-4A92-AE02-A173D2C1E746@ipfire.org> Content-Language: en-GB Cc: "IPFire: Development-List" From: Adolf Belka In-Reply-To: <7FE631A7-BAF8-4A92-AE02-A173D2C1E746@ipfire.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michael, On 30/06/2025 10:46, Michael Tremer wrote: > Hello Adolf, > > The initscript works absolutely fine for me: Interesting. > > [root@ipfire-openvpn ipfire-2.x]# /etc/init.d/openvpn-rw status > /usr/sbin/openvpn is not running. > [root@ipfire-openvpn ipfire-2.x]# /etc/init.d/openvpn-rw start > Starting OpenVPN Roadwarrior Server... [ OK ] > Starting OpenVPN Authenticator... [ OK ] > [root@ipfire-openvpn ipfire-2.x]# /etc/init.d/openvpn-rw status > openvpn is running with Process ID(s) 27406. > [root@ipfire-openvpn ipfire-2.x]# ps aux | grep openvpn > nobody 27406 0.0 0.1 12052 7624 ? Ss 10:45 0:00 /usr/sbin/openvpn --config /var/ipfire/ovpn/server.conf > root 27446 0.0 0.2 16580 10740 ? S 10:45 0:00 /usr/bin/python3 /usr/sbin/openvpn-authenticator --daemon > root 27455 0.0 0.0 6660 2612 pts/1 S+ 10:45 0:00 grep openvpn > [root@ipfire-openvpn ipfire-2.x]# ll /var/run/openvpn* > -rw------- 1 root root 227 Jun 30 10:45 /var/run/openvpn-rw.log > -rw-r--r-- 1 root root 6 Jun 30 10:45 /var/run/openvpn-rw.pid > srwxrwxrwx 1 root root 0 Jun 30 10:45 /var/run/openvpn.sock > > /var/run/openvpn: > total 0 > [root@ipfire-openvpn ipfire-2.x]# /etc/init.d/openvpn-rw stop > Stopping OpenVPN Authenticator... [ OK ] > Stopping OpenVPN Roadwarrior Server... [ OK ] > [root@ipfire-openvpn ipfire-2.x]# ll /var/run/openvpn* > -rw------- 1 root root 227 Jun 30 10:45 /var/run/openvpn-rw.log > srwxrwxrwx 1 root root 0 Jun 30 10:45 /var/run/openvpn.sock > > /var/run/openvpn: > total 0 > [root@ipfire-openvpn ipfire-2.x]# /etc/init.d/openvpn-rw status > /usr/sbin/openvpn is not running. > > Can you confirm this on your system? Might the problem simply be that your OpenVPN RW server crashes and then the PID file does not get cleaned up properly? I already confirmed that because when it wouldn't start in the WUI again, I used the manual commands. The only difference I see in the commands is that I used /etc/rc.d/init.d/openvpn-rw My testing was also done on an install from the iso that you provided the link to. One thing I noticed is that your /var/run/openvpn/ directory is empty, so presumably no net 2 net config. I do have that, so I just disabled the n2n connection (not deleted) and now my stop command is working correctly. I then enabled the n2n connection again and the RW server can still be successfully enabled/started and disabled/stopped and enabled/started again. So whatever the problem is it was only present after I had restored IPFire so that I got the rw and n2n connections. However now, the n2n connection no longer shows DISCONNECTED in a red background but an empty space and now the n2n connection is no longer showing up in my ps aux | grep openvpn listing, whereas before it did. I will try doing a fresh install again and test out with a fresh config of the rw alone and then after that do a restore of my rw/n2n connections and see what happens then. Regards, Adolf. > > -Michael > >> On 30 Jun 2025, at 09:40, Michael Tremer wrote: >> >> Hello Adolf, >> >> Thank you very much for looking into this for me. >> >>> On 29 Jun 2025, at 11:51, Adolf Belka wrote: >>> >>> Hi All, >>> >>> Tested out the latest openvpn-rebase branch from @ms using the link to the iso that he provided from the latest fixes. >>> >>> The disable and enable checkbox now works. If you enable the checkbox and save then the box is enabled and if you then disable and save it the checkbox now is disabled so that previous issue is fixed. >> >> That is a good start. >> >>> Unfortunately the start and stop issue is still present. >> >> This is less good. I am sure that I tested that the sever gets properly started, restarted and stopped. I can look into this again. Hopefully this should not stop us from conducting any further testing. >> >>> When I start the system running with the openvpn server running and then I disable the server then it shows the server as stopped. >>> >>> If I then enable the server and save then the checkbox is enabled but the server stays stopped. >>> >>> On the command line the status shows >>> >>> /usr/sbin/openvpn is not running but /var/run/openvpn-rw.pid exists. >>> >>> So the server stopped but the pid was not removed. >>> >>> If I boot the system and the server was checked as enabled then everything starts properly. >>> >>> The boot screen shows >>> >>> Starting OpenVPN Roadwarrior Server... OK >>> Starting OpenVPN Authenticator... OK >>> Starting OpenVPN N2N connection 'ipfirenet2net'... OK >>> >>> then if I straight away reboot the shutdown screen shows >>> >>> >>> Stopping OpenVPN Authenticator... Not running WARN >>> Stopping OpenVPN Roadwarrior Server... FAIL >>> Stopping OpenVPN N2N connection 'ipfirenet2net'... OK >> >> Okay, this is interesting. The authenticator cannot run without the RW service being active. So this does not concern me at this point. >> >> The RW server should however be running if it is enabled. Is there anything in the logs that explains why it crashed? >> >>> The N2N connection starts and stops correctly and the pid is removed. >>> >>> I believe that this might be due to the variable PIDFILE being used for both the authenticator and the rw daemons and when the openvpn-rw daemon is being shutdown it has the authenticator pid in the PIDFILE variable and not the openvpn-rw.pid file name. >> >> Yes, I had to play around a lot with this. The initscripts are designed to deal with only one service and I hacked my way around it. >> >>> I have tried various ways to change this in the openvpn-rw initscript but I ended up fixing it for one thing but then creating a problem for another one. Basically I think because I don't understand how the whole initscript and pid process is running in IPFire. >> >> Neither do I :) It is all very broken there and so there won't be a very clean and obvious way ahead. >> >> I will look into it. >> >> Any other findings so far? >> >> -Michael >> >>> >>> Regards, >>> Adolf. > > >