Re: [PATCH] Core 152: the script "network-hotplug-bridges" now reads the variable ${ZONE}_STP from /var/ipfire/ethernet/settings so that STP can be turned on and off for each bridge

[Leo Hofmann <hofmann@leo-andres.de>]

[-- Attachment #1: Type: text/plain, Size: 4015 bytes --]

Hi Daniel,

a few days ago I finally submitted my patches for zoneconf.cgi and I
would now have time to work on this as well.

(By the way, I almost forgot, thanks @Michael for reviewing my patches!)

If you want me to take this on, it would be very helpful if you could
summarize how this should work. For example, which config parameters
need to be modified. Perhaps you could even paint a simple GUI mock-up
like you did last time?

Regards,
Leo

Am 20.11.2020 um 19:31 schrieb Daniel Weismüller:
> OK. ;-)
>
> The first step will be the introduction of the possibility to enable STP.
>
> The next step will be the implementation in the webif.
>
> I hope I find someone who can do that.
>
>
> -
> Daniel
>
> Am 20.11.2020 um 16:18 schrieb Kienker, Fred:
>> I'm with Michael on this one. If it deserves to be in IPFire, it
>> deserves to be on the web interface. Don't created exceptions which are
>> only available from a command line.
>>
>> Best regards,
>> Fred
>>
>> -----Original Message-----
>> From: Michael Tremer <michael.tremer(a)ipfire.org>
>> Sent: Friday, November 20, 2020 5:55 AM
>> To: Daniel Weismüller <daniel.weismueller(a)ipfire.org>
>> Cc: development(a)lists.ipfire.org
>> Subject: Re: [PATCH] Core 152: the script "network-hotplug-bridges" now
>> reads the variable ${ZONE}_STP from /var/ipfire/ethernet/settings so
>> that STP can be turned on and off for each bridge
>>
>> Hi,
>>
>>> On 20 Nov 2020, at 06:58, Daniel Weismüller
>> <daniel.weismueller(a)ipfire.org> wrote:
>>> Hello,
>>>
>>> In my opinion it is sufficient to be able to set these parameters via
>> command line.
>>
>> Why is that? IPFire is a distribution that is supposed to be managed
>> entirely by the web user interface.
>>
>>> It should only be made sure that the settings are persitend and not
>> overwritten by a reboot or the webif.
>>
>> They wont be as they are in /var/ipfire/ethernet/settings.
>>
>> Best,
>> -Michael
>>
>>> -
>>> Daniel
>>>
>>> Am 19.11.2020 um 15:56 schrieb Michael Tremer:
>>>> Hello Daniel,
>>>>
>>>> This patch looks good to me.
>>>>
>>>> I had assumed that we automatically enabled STP on all bridges, but
>> apparently we do not.
>>>> How do we process with this?
>>>>
>>>> I suppose it is not the most user-friendly way to ask the user to
>> edit the configuration file. This either must be documented somewhere or
>> the zoneconfig.cgi script needs to be extended to allow enabling STP.
>>>> Does anyone want to be able to change any STP parameters like
>> priority or cost of the ports?
>>>> Best,
>>>> -Michael
>>>>
>>>>> On 19 Nov 2020, at 13:18, Daniel Weismüller
>> <daniel.weismueller(a)ipfire.org> wrote:
>>>>> Signed-off-by: Daniel Weismüller <daniel.weismueller(a)ipfire.org>
>>>>> ---
>>>>> config/udev/network-hotplug-bridges | 4 +++-
>>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/config/udev/network-hotplug-bridges
>> b/config/udev/network-hotplug-bridges
>>>>> index 33d6d65ba..7431377bb 100644
>>>>> --- a/config/udev/network-hotplug-bridges
>>>>> +++ b/config/udev/network-hotplug-bridges
>>>>> @@ -81,6 +81,7 @@ MODE="$(get_value "${ZONE}_MODE")"
>>>>>
>>>>> # The name of the virtual bridge
>>>>> BRIDGE="$(get_value "${ZONE}_DEV")"
>>>>> +STP="$(get_value "${ZONE}_STP")"
>>>>>
>>>>> case "${MODE}" in
>>>>>     bridge)
>>>>> @@ -89,7 +90,8 @@ case "${MODE}" in
>>>>>
>>>>>         # We need to create the bridge if it doesn't exist, yet
>>>>>         if [ ! -d "/sys/class/net/${BRIDGE}" ]; then
>>>>> -            ip link add "${BRIDGE}" address "${ADDRESS}" type
>> bridge
>>>>> +            ip link add "${BRIDGE}" address "${ADDRESS}" type
>> bridge \
>>>>> +                $([ "${STP}" = "on" ] && echo "stp_state 1")
>>>>>             #ip link set "${BRIDGE}" up
>>>>>         fi
>>>>>
>>>>> -- 
>>>>> 2.28.0
>>>>>
>>
>>
>