From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: Incorrect naming convention used on the Core Update 170 download file.
Date: Sat, 17 Sep 2022 12:22:51 +0200
Message-ID: <adb5e6cf-1a6a-7cce-d6e9-c5f2c4294e41@ipfire.org>
In-Reply-To: <511781b6-6fcd-501c-3829-b0b7915d4833@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5391938056118784028=="
List-Id: <development.lists.ipfire.org>

--===============5391938056118784028==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Matthias,

On 17/09/2022 11:28, Matthias Fischer wrote:
> Hi,
>=20
> Confirmed. Somehow the name of the ISO has changed.
>=20
> But - correct me if I'm wrong! - the naming of the ISO file takes place
> in '/usr/local/bin/backupiso':
That is correct but before that occurs the first step is to download the=20
original iso from the IPFire download site and it looks in that download=20
site for an iso named ISO=3D"ipfire-$IPFVER.$arch-full-core$COREVER.iso"=20
which is fine for CU169 and earlier but CU170 has had the arch portion=20
moved to a different location in the filename.

Either the new filename structure for the IPFire CU170 download has been=20
changed accidentally or it has been done deliberately but forgotten to=20
change the template in backup.pl etc.

>=20
> Current is:
> ...
> ISO=3D"ipfire-$IPFVER.$arch-full-core$COREVER.iso"
> ...
>=20
> IMHO it could be sufficient to change this to:
> ...
> ISO=3D"ipfire-$IPFVER-core$CORVER-$arch.iso"
Changing that would fix the problem but only if the change of the=20
download filename on the IPFire server was changed deliberately.

Regards,
Adolf.
> ...
>=20
> I haven't searched for other occurences yet, but I think that could be
> the culprit...
>=20
> jm2c
>=20
> Matthias
>=20
> On 16.09.2022 16:24, Adolf Belka wrote:
>> Hi All,
>>
>> On 16/09/2022 16:02, Adolf Belka wrote:
>>> Hi everyone,
>>>
>>> On the forum there have been a couple of people who tried creating an iso=
 backup and it only showed a 0 byte file.
>>>
>>>
>>> I have confirmed with my vm testbed. The same thing works fine for CU169.
>>>
>>>
>>> After looking through code I have found that Core Update 169=C2=A0 and 17=
0 file name order is different. The arch is placed in a different location
>>>
>>>
>>> https://downloads.ipfire.org/releases/ipfire-2.x/2.27-core169/ipfire-2.27=
.x86_64-full-core169.iso
>>>
>>> https://downloads.ipfire.org/releases/ipfire-2.x/2.27-core170/ipfire-2.27=
-core170-x86_64.iso
>>>
>>> This means that backup.pl is not able to find the Core Update 170 iso fro=
m the downloads site.
>>>
>> If the change in iso file naming convention was intended then backup.pl al=
so needs to be modified for the iso naming convention.
>>
>>
>> Regards,
>>
>> Adolf.
>>
>>>
>>> Regards,
>>>
>>> Adolf.
>>>
>>>
>=20

--=20
Sent from my laptop

--===============5391938056118784028==--