* Problems trying to update lua-5.4.3 @ 2021-04-13 21:06 Adolf Belka 2021-04-14 9:08 ` Michael Tremer 0 siblings, 1 reply; 6+ messages in thread From: Adolf Belka @ 2021-04-13 21:06 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 1903 bytes --] Hi All, I have been working on updating lua from 5.3.5 to 5.4.3 I updated the autotoolize.patch and the shared_library-1.patch and found that 5.4.3 no longer has lbitlib.c in the tarball src directory I removed lbitlib.c from the liblua_la_SOURCES section in the diff for lua-5.3.5/src/Makefile.am ----------------------------------------------------------- +AM_CFLAGS = -Wall + +include_HEADERS = lua.h lualib.h lauxlib.h lua.hpp + +nodist_include_HEADERS = luaconf.h + +lib_LTLIBRARIES = liblua.la +liblua_la_LDFLAGS = -release @MAJOR_VERSION@ +liblua_la_SOURCES = \ + lapi.c lauxlib.c lbaselib.c lbitlib.c lcode.c lcorolib.c lctype.c ldblib.c \ + ldebug.c ldo.c ldump.c lfunc.c lgc.c linit.c liolib.c llex.c lmathlib.c lmem.c \ + loadlib.c lobject.c lopcodes.c loslib.c lparser.c lstate.c lstring.c lstrlib.c \ + ltable.c ltablib.c ltm.c lundump.c lutf8lib.c lvm.c lzio.c \ + lapi.h lcode.h lctype.h ldebug.h ldo.h lfunc.h lgc.h llex.h llimits.h \ + lmem.h lobject.h lopcodes.h lparser.h lstate.h lstring.h ltable.h ltm.h \ + lundump.h lvm.h lzio.h + ----------------------------------------------------------- and then lua built without any problems. So lua built successfully but looking at the files in the tarball src directory for 5.3.5 & 5.4.3 there are some differences The following files lua.c luac.c lua.h luaconf.h lualib.h lauxlib.h lprefix.h are in both 5.3.5 & 5.4.3 but not in the liblua_la_SOURCES section. This may be deliberate, I can't tell. However lbitlib.c is in 5.3.5 & liblua_la_SOURCES but not in 5.4.3 Is that a problem for IPFire's use of lua? ljumptab.h and lopnames.h are not in 5.3.5 or liblua_la_SOURCES but are in 5.4.3 Should these now be included somewhere in the Makefile.am or elsewhere or is it OK to ignore them for IPFire? Regards, Adolf. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Problems trying to update lua-5.4.3 2021-04-13 21:06 Problems trying to update lua-5.4.3 Adolf Belka @ 2021-04-14 9:08 ` Michael Tremer 2021-04-14 12:33 ` Adolf Belka 0 siblings, 1 reply; 6+ messages in thread From: Michael Tremer @ 2021-04-14 9:08 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 2271 bytes --] Hello, I think you can use this as inspiration: http://www.linuxfromscratch.org/blfs/view/svn/general/lua.html The patch should already be updated and should be working. -Michael > On 13 Apr 2021, at 22:06, Adolf Belka <adolf.belka(a)ipfire.org> wrote: > > Hi All, > > > I have been working on updating lua from 5.3.5 to 5.4.3 > > I updated the autotoolize.patch and the shared_library-1.patch and found that 5.4.3 no longer has lbitlib.c in the tarball src directory > > > I removed lbitlib.c from the liblua_la_SOURCES section in the diff for lua-5.3.5/src/Makefile.am > > ----------------------------------------------------------- > +AM_CFLAGS = -Wall > + > +include_HEADERS = lua.h lualib.h lauxlib.h lua.hpp > + > +nodist_include_HEADERS = luaconf.h > + > +lib_LTLIBRARIES = liblua.la > +liblua_la_LDFLAGS = -release @MAJOR_VERSION@ > +liblua_la_SOURCES = \ > + lapi.c lauxlib.c lbaselib.c lbitlib.c lcode.c lcorolib.c lctype.c ldblib.c \ > + ldebug.c ldo.c ldump.c lfunc.c lgc.c linit.c liolib.c llex.c lmathlib.c lmem.c \ > + loadlib.c lobject.c lopcodes.c loslib.c lparser.c lstate.c lstring.c lstrlib.c \ > + ltable.c ltablib.c ltm.c lundump.c lutf8lib.c lvm.c lzio.c \ > + lapi.h lcode.h lctype.h ldebug.h ldo.h lfunc.h lgc.h llex.h llimits.h \ > + lmem.h lobject.h lopcodes.h lparser.h lstate.h lstring.h ltable.h ltm.h \ > + lundump.h lvm.h lzio.h > + > > ----------------------------------------------------------- > > and then lua built without any problems. > > > So lua built successfully but looking at the files in the tarball src directory for 5.3.5 & 5.4.3 there are some differences > > The following files > lua.c > luac.c > lua.h > luaconf.h > lualib.h > lauxlib.h > lprefix.h > > are in both 5.3.5 & 5.4.3 but not in the liblua_la_SOURCES section. This may be deliberate, I can't tell. > > However lbitlib.c is in 5.3.5 & liblua_la_SOURCES but not in 5.4.3 Is that a problem for IPFire's use of lua? > > > ljumptab.h and lopnames.h are not in 5.3.5 or liblua_la_SOURCES but are in 5.4.3 Should these now be included somewhere in the Makefile.am or elsewhere or is it OK to ignore them for IPFire? > > > Regards, > > Adolf. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Problems trying to update lua-5.4.3 2021-04-14 9:08 ` Michael Tremer @ 2021-04-14 12:33 ` Adolf Belka 2021-04-14 18:02 ` Michael Tremer 0 siblings, 1 reply; 6+ messages in thread From: Adolf Belka @ 2021-04-14 12:33 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 2993 bytes --] Hallo, On 14/04/2021 11:08, Michael Tremer wrote: > Hello, > > I think you can use this as inspiration: > > http://www.linuxfromscratch.org/blfs/view/svn/general/lua.html > > The patch should already be updated and should be working. The patch there is the shared_library-1.patch I can certainly use it in my build but the patch I was having the questions about is the autotoolize.patch This is not mentioned in the Beyond Linux From Scratch link. Also not in the BLFS link for the previous version of lua-5.3.4 Searching I have found that this patch is designed to have the lua build use the standard autotools programs. However the locations in Fedora and other repositories I found seem to stop at lua-5.3.0 Any help with where to find a newer version of the autotoolize.patch that is meant for lua-5.4.3 Regards, Adolf > > -Michael > >> On 13 Apr 2021, at 22:06, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >> >> Hi All, >> >> >> I have been working on updating lua from 5.3.5 to 5.4.3 >> >> I updated the autotoolize.patch and the shared_library-1.patch and found that 5.4.3 no longer has lbitlib.c in the tarball src directory >> >> >> I removed lbitlib.c from the liblua_la_SOURCES section in the diff for lua-5.3.5/src/Makefile.am >> >> ----------------------------------------------------------- >> +AM_CFLAGS = -Wall >> + >> +include_HEADERS = lua.h lualib.h lauxlib.h lua.hpp >> + >> +nodist_include_HEADERS = luaconf.h >> + >> +lib_LTLIBRARIES = liblua.la >> +liblua_la_LDFLAGS = -release @MAJOR_VERSION@ >> +liblua_la_SOURCES = \ >> + lapi.c lauxlib.c lbaselib.c lbitlib.c lcode.c lcorolib.c lctype.c ldblib.c \ >> + ldebug.c ldo.c ldump.c lfunc.c lgc.c linit.c liolib.c llex.c lmathlib.c lmem.c \ >> + loadlib.c lobject.c lopcodes.c loslib.c lparser.c lstate.c lstring.c lstrlib.c \ >> + ltable.c ltablib.c ltm.c lundump.c lutf8lib.c lvm.c lzio.c \ >> + lapi.h lcode.h lctype.h ldebug.h ldo.h lfunc.h lgc.h llex.h llimits.h \ >> + lmem.h lobject.h lopcodes.h lparser.h lstate.h lstring.h ltable.h ltm.h \ >> + lundump.h lvm.h lzio.h >> + >> >> ----------------------------------------------------------- >> >> and then lua built without any problems. >> >> >> So lua built successfully but looking at the files in the tarball src directory for 5.3.5 & 5.4.3 there are some differences >> >> The following files >> lua.c >> luac.c >> lua.h >> luaconf.h >> lualib.h >> lauxlib.h >> lprefix.h >> >> are in both 5.3.5 & 5.4.3 but not in the liblua_la_SOURCES section. This may be deliberate, I can't tell. >> >> However lbitlib.c is in 5.3.5 & liblua_la_SOURCES but not in 5.4.3 Is that a problem for IPFire's use of lua? >> >> >> ljumptab.h and lopnames.h are not in 5.3.5 or liblua_la_SOURCES but are in 5.4.3 Should these now be included somewhere in the Makefile.am or elsewhere or is it OK to ignore them for IPFire? >> >> >> Regards, >> >> Adolf. >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Problems trying to update lua-5.4.3 2021-04-14 12:33 ` Adolf Belka @ 2021-04-14 18:02 ` Michael Tremer 2021-04-16 19:56 ` Adolf Belka 0 siblings, 1 reply; 6+ messages in thread From: Michael Tremer @ 2021-04-14 18:02 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 3498 bytes --] Hello, > On 14 Apr 2021, at 13:33, Adolf Belka <adolf.belka(a)ipfire.org> wrote: > > Hallo, > > On 14/04/2021 11:08, Michael Tremer wrote: >> Hello, >> I think you can use this as inspiration: >> http://www.linuxfromscratch.org/blfs/view/svn/general/lua.html >> The patch should already be updated and should be working. > The patch there is the shared_library-1.patch > > I can certainly use it in my build but the patch I was having the questions about is the autotoolize.patch This is not mentioned in the Beyond Linux From Scratch link. Also not in the BLFS link for the previous version of lua-5.3.4 > > Searching I have found that this patch is designed to have the lua build use the standard autotools programs. However the locations in Fedora and other repositories I found seem to stop at lua-5.3.0 Apart from Fedora, it is worth checking Gentoo because they are usually very up to date and should have patches. Archlinux is a good option, too, because they keep their patches to a minimum and are a rolling release as well. > Any help with where to find a newer version of the autotoolize.patch that is meant for lua-5.4.3 If there is none available, we can just use the steps without configure like BLFS. -Michael > > Regards, > > Adolf >> -Michael >>> On 13 Apr 2021, at 22:06, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >>> >>> Hi All, >>> >>> >>> I have been working on updating lua from 5.3.5 to 5.4.3 >>> >>> I updated the autotoolize.patch and the shared_library-1.patch and found that 5.4.3 no longer has lbitlib.c in the tarball src directory >>> >>> >>> I removed lbitlib.c from the liblua_la_SOURCES section in the diff for lua-5.3.5/src/Makefile.am >>> >>> ----------------------------------------------------------- >>> +AM_CFLAGS = -Wall >>> + >>> +include_HEADERS = lua.h lualib.h lauxlib.h lua.hpp >>> + >>> +nodist_include_HEADERS = luaconf.h >>> + >>> +lib_LTLIBRARIES = liblua.la >>> +liblua_la_LDFLAGS = -release @MAJOR_VERSION@ >>> +liblua_la_SOURCES = \ >>> + lapi.c lauxlib.c lbaselib.c lbitlib.c lcode.c lcorolib.c lctype.c ldblib.c \ >>> + ldebug.c ldo.c ldump.c lfunc.c lgc.c linit.c liolib.c llex.c lmathlib.c lmem.c \ >>> + loadlib.c lobject.c lopcodes.c loslib.c lparser.c lstate.c lstring.c lstrlib.c \ >>> + ltable.c ltablib.c ltm.c lundump.c lutf8lib.c lvm.c lzio.c \ >>> + lapi.h lcode.h lctype.h ldebug.h ldo.h lfunc.h lgc.h llex.h llimits.h \ >>> + lmem.h lobject.h lopcodes.h lparser.h lstate.h lstring.h ltable.h ltm.h \ >>> + lundump.h lvm.h lzio.h >>> + >>> >>> ----------------------------------------------------------- >>> >>> and then lua built without any problems. >>> >>> >>> So lua built successfully but looking at the files in the tarball src directory for 5.3.5 & 5.4.3 there are some differences >>> >>> The following files >>> lua.c >>> luac.c >>> lua.h >>> luaconf.h >>> lualib.h >>> lauxlib.h >>> lprefix.h >>> >>> are in both 5.3.5 & 5.4.3 but not in the liblua_la_SOURCES section. This may be deliberate, I can't tell. >>> >>> However lbitlib.c is in 5.3.5 & liblua_la_SOURCES but not in 5.4.3 Is that a problem for IPFire's use of lua? >>> >>> >>> ljumptab.h and lopnames.h are not in 5.3.5 or liblua_la_SOURCES but are in 5.4.3 Should these now be included somewhere in the Makefile.am or elsewhere or is it OK to ignore them for IPFire? >>> >>> >>> Regards, >>> >>> Adolf. >>> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Problems trying to update lua-5.4.3 2021-04-14 18:02 ` Michael Tremer @ 2021-04-16 19:56 ` Adolf Belka 2021-04-19 10:06 ` Michael Tremer 0 siblings, 1 reply; 6+ messages in thread From: Adolf Belka @ 2021-04-16 19:56 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 4126 bytes --] Hi Michael, On 14/04/2021 20:02, Michael Tremer wrote: > Hello, > >> On 14 Apr 2021, at 13:33, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >> >> Hallo, >> >> On 14/04/2021 11:08, Michael Tremer wrote: >>> Hello, >>> I think you can use this as inspiration: >>> http://www.linuxfromscratch.org/blfs/view/svn/general/lua.html >>> The patch should already be updated and should be working. >> The patch there is the shared_library-1.patch >> >> I can certainly use it in my build but the patch I was having the questions about is the autotoolize.patch This is not mentioned in the Beyond Linux From Scratch link. Also not in the BLFS link for the previous version of lua-5.3.4 >> >> Searching I have found that this patch is designed to have the lua build use the standard autotools programs. However the locations in Fedora and other repositories I found seem to stop at lua-5.3.0 > > Apart from Fedora, it is worth checking Gentoo because they are usually very up to date and should have patches. Archlinux is a good option, too, because they keep their patches to a minimum and are a rolling release as well. I checked Gentoo but they also seemed to have stopped at 5.3.1 Arch Linux have followed the BLFS process and have not autotoolized lua. > >> Any help with where to find a newer version of the autotoolize.patch that is meant for lua-5.4.3 > > If there is none available, we can just use the steps without configure like BLFS. So in the end I followed the BLFS process and it built successfully. One thing I noticed is that the old rootfile had the plain .so library uncommented and the .so.5.3 library commented out. This is the opposite of what is normally done. Is this correct for lua? Should I follow the same process for 5.4.3 or should I change it? Regards, Adolf. > > -Michael > >> >> Regards, >> >> Adolf >>> -Michael >>>> On 13 Apr 2021, at 22:06, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >>>> >>>> Hi All, >>>> >>>> >>>> I have been working on updating lua from 5.3.5 to 5.4.3 >>>> >>>> I updated the autotoolize.patch and the shared_library-1.patch and found that 5.4.3 no longer has lbitlib.c in the tarball src directory >>>> >>>> >>>> I removed lbitlib.c from the liblua_la_SOURCES section in the diff for lua-5.3.5/src/Makefile.am >>>> >>>> ----------------------------------------------------------- >>>> +AM_CFLAGS = -Wall >>>> + >>>> +include_HEADERS = lua.h lualib.h lauxlib.h lua.hpp >>>> + >>>> +nodist_include_HEADERS = luaconf.h >>>> + >>>> +lib_LTLIBRARIES = liblua.la >>>> +liblua_la_LDFLAGS = -release @MAJOR_VERSION@ >>>> +liblua_la_SOURCES = \ >>>> + lapi.c lauxlib.c lbaselib.c lbitlib.c lcode.c lcorolib.c lctype.c ldblib.c \ >>>> + ldebug.c ldo.c ldump.c lfunc.c lgc.c linit.c liolib.c llex.c lmathlib.c lmem.c \ >>>> + loadlib.c lobject.c lopcodes.c loslib.c lparser.c lstate.c lstring.c lstrlib.c \ >>>> + ltable.c ltablib.c ltm.c lundump.c lutf8lib.c lvm.c lzio.c \ >>>> + lapi.h lcode.h lctype.h ldebug.h ldo.h lfunc.h lgc.h llex.h llimits.h \ >>>> + lmem.h lobject.h lopcodes.h lparser.h lstate.h lstring.h ltable.h ltm.h \ >>>> + lundump.h lvm.h lzio.h >>>> + >>>> >>>> ----------------------------------------------------------- >>>> >>>> and then lua built without any problems. >>>> >>>> >>>> So lua built successfully but looking at the files in the tarball src directory for 5.3.5 & 5.4.3 there are some differences >>>> >>>> The following files >>>> lua.c >>>> luac.c >>>> lua.h >>>> luaconf.h >>>> lualib.h >>>> lauxlib.h >>>> lprefix.h >>>> >>>> are in both 5.3.5 & 5.4.3 but not in the liblua_la_SOURCES section. This may be deliberate, I can't tell. >>>> >>>> However lbitlib.c is in 5.3.5 & liblua_la_SOURCES but not in 5.4.3 Is that a problem for IPFire's use of lua? >>>> >>>> >>>> ljumptab.h and lopnames.h are not in 5.3.5 or liblua_la_SOURCES but are in 5.4.3 Should these now be included somewhere in the Makefile.am or elsewhere or is it OK to ignore them for IPFire? >>>> >>>> >>>> Regards, >>>> >>>> Adolf. >>>> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Problems trying to update lua-5.4.3 2021-04-16 19:56 ` Adolf Belka @ 2021-04-19 10:06 ` Michael Tremer 0 siblings, 0 replies; 6+ messages in thread From: Michael Tremer @ 2021-04-19 10:06 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 4854 bytes --] Hello, Some packages do not follow the standard naming process (which normally is indicated by autotools). That is normally not a good idea, but what can you do? They simply use the version number of the package (which normally isn’t the same as the library version) in the filename (liblua-5.3.so). liblua.so is a symlink to that file and that is it. There is no change to have a patch level library next to it. So we would just ship liblua-5.x.so and we will always have to ship all software that is linked against it. -Michael > On 16 Apr 2021, at 20:56, Adolf Belka <adolf.belka(a)ipfire.org> wrote: > > Hi Michael, > > On 14/04/2021 20:02, Michael Tremer wrote: >> Hello, >>> On 14 Apr 2021, at 13:33, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >>> >>> Hallo, >>> >>> On 14/04/2021 11:08, Michael Tremer wrote: >>>> Hello, >>>> I think you can use this as inspiration: >>>> http://www.linuxfromscratch.org/blfs/view/svn/general/lua.html >>>> The patch should already be updated and should be working. >>> The patch there is the shared_library-1.patch >>> >>> I can certainly use it in my build but the patch I was having the questions about is the autotoolize.patch This is not mentioned in the Beyond Linux >From Scratch link. Also not in the BLFS link for the previous version of lua-5.3.4 >>> >>> Searching I have found that this patch is designed to have the lua build use the standard autotools programs. However the locations in Fedora and other repositories I found seem to stop at lua-5.3.0 >> Apart from Fedora, it is worth checking Gentoo because they are usually very up to date and should have patches. Archlinux is a good option, too, because they keep their patches to a minimum and are a rolling release as well. > I checked Gentoo but they also seemed to have stopped at 5.3.1 > Arch Linux have followed the BLFS process and have not autotoolized lua. >>> Any help with where to find a newer version of the autotoolize.patch that is meant for lua-5.4.3 >> If there is none available, we can just use the steps without configure like BLFS. > So in the end I followed the BLFS process and it built successfully. > > One thing I noticed is that the old rootfile had the plain .so library uncommented and the .so.5.3 library commented out. This is the opposite of what is normally done. Is this correct for lua? Should I follow the same process for 5.4.3 or should I change it? > > Regards, > > Adolf. >> -Michael >>> >>> Regards, >>> >>> Adolf >>>> -Michael >>>>> On 13 Apr 2021, at 22:06, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >>>>> >>>>> Hi All, >>>>> >>>>> >>>>> I have been working on updating lua from 5.3.5 to 5.4.3 >>>>> >>>>> I updated the autotoolize.patch and the shared_library-1.patch and found that 5.4.3 no longer has lbitlib.c in the tarball src directory >>>>> >>>>> >>>>> I removed lbitlib.c from the liblua_la_SOURCES section in the diff for lua-5.3.5/src/Makefile.am >>>>> >>>>> ----------------------------------------------------------- >>>>> +AM_CFLAGS = -Wall >>>>> + >>>>> +include_HEADERS = lua.h lualib.h lauxlib.h lua.hpp >>>>> + >>>>> +nodist_include_HEADERS = luaconf.h >>>>> + >>>>> +lib_LTLIBRARIES = liblua.la >>>>> +liblua_la_LDFLAGS = -release @MAJOR_VERSION@ >>>>> +liblua_la_SOURCES = \ >>>>> + lapi.c lauxlib.c lbaselib.c lbitlib.c lcode.c lcorolib.c lctype.c ldblib.c \ >>>>> + ldebug.c ldo.c ldump.c lfunc.c lgc.c linit.c liolib.c llex.c lmathlib.c lmem.c \ >>>>> + loadlib.c lobject.c lopcodes.c loslib.c lparser.c lstate.c lstring.c lstrlib.c \ >>>>> + ltable.c ltablib.c ltm.c lundump.c lutf8lib.c lvm.c lzio.c \ >>>>> + lapi.h lcode.h lctype.h ldebug.h ldo.h lfunc.h lgc.h llex.h llimits.h \ >>>>> + lmem.h lobject.h lopcodes.h lparser.h lstate.h lstring.h ltable.h ltm.h \ >>>>> + lundump.h lvm.h lzio.h >>>>> + >>>>> >>>>> ----------------------------------------------------------- >>>>> >>>>> and then lua built without any problems. >>>>> >>>>> >>>>> So lua built successfully but looking at the files in the tarball src directory for 5.3.5 & 5.4.3 there are some differences >>>>> >>>>> The following files >>>>> lua.c >>>>> luac.c >>>>> lua.h >>>>> luaconf.h >>>>> lualib.h >>>>> lauxlib.h >>>>> lprefix.h >>>>> >>>>> are in both 5.3.5 & 5.4.3 but not in the liblua_la_SOURCES section. This may be deliberate, I can't tell. >>>>> >>>>> However lbitlib.c is in 5.3.5 & liblua_la_SOURCES but not in 5.4.3 Is that a problem for IPFire's use of lua? >>>>> >>>>> >>>>> ljumptab.h and lopnames.h are not in 5.3.5 or liblua_la_SOURCES but are in 5.4.3 Should these now be included somewhere in the Makefile.am or elsewhere or is it OK to ignore them for IPFire? >>>>> >>>>> >>>>> Regards, >>>>> >>>>> Adolf. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-19 10:06 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-13 21:06 Problems trying to update lua-5.4.3 Adolf Belka 2021-04-14 9:08 ` Michael Tremer 2021-04-14 12:33 ` Adolf Belka 2021-04-14 18:02 ` Michael Tremer 2021-04-16 19:56 ` Adolf Belka 2021-04-19 10:06 ` Michael Tremer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox