Re: Possible bug in OpenVPN, Core 65

Re: Possible bug in OpenVPN, Core 65

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1812 bytes --]

Thanks guys.

I merged the patch and it will ship with IPFire 2.13.

Best,
-Michael

On Mon, 2013-01-07 at 08:36 +0100, Alexander Marx wrote:
> Hi
> i can fully acknoledge this.
> Tried to reproduce your error and found the same problems.
> i will provide a patch for this.
> 
> 
> 
> Alexander Marx
> 
> 
> Fachinformatiker Systemintegration
> 
> 
> 
> 
> Am 07.01.2013 06:44, schrieb R. W. Rodolico:
> 
> > See http://forum.ipfire.org/index.php/topic,7365.0.html for information.
> > 
> > Turns out the CCD does not work if the user has embedded spaces in the
> > CN (field labeled "User's full name or system hostname:" on Road Warrior
> > creation screen). I don't remember exactly, but I believe OpenSSL or
> > OpenVPN itself converts spaces to underscores. You can test this by
> > creating a user, embedding spaces, and then on the server
> > cat /var/log/ovpnserver.log
> > 
> > You will note the Common Name has spaces converted to underscores.
> > 
> > The solution is to write the ccd file with underscores, ie
> > $filename =~ s/ /_/gi;
> > 
> > If someone will point me to the script that creates that, I will be
> > happy to patch and test, then send you the diff.
> > 
> > Rod
> > 
> > NOTE: I have spent a little time looking at this and solving it for an
> > existing installation, but I intend to pull an old router out and
> > reconfigure it for a controlled test, unless someone else can verify my
> > findings independently.
> > 
> > Rod
> > 
> > 
> > _______________________________________________
> > Development mailing list
> > Development(a)lists.ipfire.org
> > http://lists.ipfire.org/mailman/listinfo/development
> 
> _______________________________________________
> Development mailing list
> Development(a)lists.ipfire.org
> http://lists.ipfire.org/mailman/listinfo/development

Re: Possible bug in OpenVPN, Core 65

[R. W. Rodolico]

[-- Attachment #1: Type: text/plain, Size: 2383 bytes --]

Thank you Alexander, for checking and building the patch.

Michael, thank you for fixing it so rapidly.

And, I do apologize. I ran into this issue while testing several months
ago and apparently did not report it.

Rod

On 01/07/2013 05:37 AM, Michael Tremer wrote:
> Thanks guys.
> 
> I merged the patch and it will ship with IPFire 2.13.
> 
> Best,
> -Michael
> 
> On Mon, 2013-01-07 at 08:36 +0100, Alexander Marx wrote:
>> Hi
>> i can fully acknoledge this.
>> Tried to reproduce your error and found the same problems.
>> i will provide a patch for this.
>>
>>
>>
>> Alexander Marx
>>
>>
>> Fachinformatiker Systemintegration
>>
>>
>>
>>
>> Am 07.01.2013 06:44, schrieb R. W. Rodolico:
>>
>>> See http://forum.ipfire.org/index.php/topic,7365.0.html for information.
>>>
>>> Turns out the CCD does not work if the user has embedded spaces in the
>>> CN (field labeled "User's full name or system hostname:" on Road Warrior
>>> creation screen). I don't remember exactly, but I believe OpenSSL or
>>> OpenVPN itself converts spaces to underscores. You can test this by
>>> creating a user, embedding spaces, and then on the server
>>> cat /var/log/ovpnserver.log
>>>
>>> You will note the Common Name has spaces converted to underscores.
>>>
>>> The solution is to write the ccd file with underscores, ie
>>> $filename =~ s/ /_/gi;
>>>
>>> If someone will point me to the script that creates that, I will be
>>> happy to patch and test, then send you the diff.
>>>
>>> Rod
>>>
>>> NOTE: I have spent a little time looking at this and solving it for an
>>> existing installation, but I intend to pull an old router out and
>>> reconfigure it for a controlled test, unless someone else can verify my
>>> findings independently.
>>>
>>> Rod
>>>
>>>
>>> _______________________________________________
>>> Development mailing list
>>> Development(a)lists.ipfire.org
>>> http://lists.ipfire.org/mailman/listinfo/development
>>
>> _______________________________________________
>> Development mailing list
>> Development(a)lists.ipfire.org
>> http://lists.ipfire.org/mailman/listinfo/development
> 
> 
> _______________________________________________
> Development mailing list
> Development(a)lists.ipfire.org
> http://lists.ipfire.org/mailman/listinfo/development
> 

-- 
R. W. "Rod" Rodolico
Daily Data, Inc.
POB 140465
Dallas TX 75214-0465
http://www.dailydata.net
214.827.2170


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rodo.vcf --]
[-- Type: text/x-vcard, Size: 233 bytes --]

begin:vcard
fn:R. W. Rodolico
n:Rodolico;R. W.
org:Daily Data, Inc.
adr:;;POB 140465;Dallas;TX;75214-0465;US
email;internet:rodo@dailydata.net
title:President
tel;work:214.827.2170
url:http://www.dailydata.net
version:2.1
end:vcard

Possible bug in OpenVPN, Core 65

[R. W. Rodolico]

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

See http://forum.ipfire.org/index.php/topic,7365.0.html for information.

Turns out the CCD does not work if the user has embedded spaces in the
CN (field labeled "User's full name or system hostname:" on Road Warrior
creation screen). I don't remember exactly, but I believe OpenSSL or
OpenVPN itself converts spaces to underscores. You can test this by
creating a user, embedding spaces, and then on the server
cat /var/log/ovpnserver.log

You will note the Common Name has spaces converted to underscores.

The solution is to write the ccd file with underscores, ie
$filename =~ s/ /_/gi;

If someone will point me to the script that creates that, I will be
happy to patch and test, then send you the diff.

Rod

NOTE: I have spent a little time looking at this and solving it for an
existing installation, but I intend to pull an old router out and
reconfigure it for a controlled test, unless someone else can verify my
findings independently.

Rod
-- 
R. W. "Rod" Rodolico
Daily Data, Inc.
POB 140465
Dallas TX 75214-0465
http://www.dailydata.net
214.827.2170


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rodo.vcf --]
[-- Type: text/x-vcard, Size: 233 bytes --]

begin:vcard
fn:R. W. Rodolico
n:Rodolico;R. W.
org:Daily Data, Inc.
adr:;;POB 140465;Dallas;TX;75214-0465;US
email;internet:rodo@dailydata.net
title:President
tel;work:214.827.2170
url:http://www.dailydata.net
version:2.1
end:vcard