From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: How to test a solution for bug 12539 Date: Fri, 27 Nov 2020 18:24:13 +0100 Message-ID: In-Reply-To: <3990D1D7-44E1-492A-A5BB-3914FCC07371@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5864593415496483242==" List-Id: --===============5864593415496483242== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, That's great input. It would also mean that any future packages that had dupl= icate names at the start would not need the same fix. This would fix it perma= nently, whatever an add-on is called. Like it very much :-). It will also be testable by myself because the add-on names stay the same, th= e part that would be changed would be something I can install on my testbed a= nd test. Thanks very much for your help. Regards, Adolf. On 27/11/2020 17:55, Michael Tremer wrote: > Hey Adolf, >=20 > I think the fundamental problem here is that we are running a shell command= to edit a string. >=20 > https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dhtml/cgi-bin/servic= es.cgi;h=3D26ab4f3143fff36434287ec085aaa47993726ff1;hb=3DHEAD#l164 >=20 > Furthermore that shell command is returning what is the second element betw= een hyphens. This is not what we want. We actually simply want whatever comes= after =E2=80=9Cmeta-=E2=80=9C. >=20 > My suggestion is to change the call of =E2=80=9Cfind=E2=80=9D (line 164) so= that we use Perl-native code to list all files in that directory. >=20 > We then cut off the first five characters if they are =E2=80=9Cmeta-=E2=80= =9C. Otherwise we ignore the file. >=20 > We then have the correct name of the service we are looking for. >=20 > We should also change the second call to =E2=80=9Cfind=E2=80=9D (line 169) = which simply could be: >=20 > if (-e =E2=80=9C/etc/init.d/${service}=E2=80=9D) { =E2=80=A6 } >=20 > That way, the code would be more secure because any shell command injection= s are impossible. It would perform a lot quicker because it takes a very very= long time to launch a shell command. And last but not least it does what we = intend. >=20 > Is this what you were looking for? >=20 > -Michael >=20 >> On 26 Nov 2020, at 22:22, Adolf Belka wrote: >> >> Dear All, >> >> I have been working on a solution for bug 12539. >> >> With cups and cups-filters installed the services tab shows cups twice in = the add-on list. This is because the cut command from the installed meta file= s causes both meta-cups and meta-cups-filters to result in cups and therefore= shows up twice. >> >> The solution seems to be to rename the Prog name from cups-filters to cups= _filters. I made these changes in my local repo and everything built successf= ully. >> >> However I can not figure out how to test and confirm that it has worked. >> >> If I install the built ISO and then install cups and cups_filters from pak= fire they load the programs from the IPFire repo and therefore load the origi= nal versions which still have the problem and show up twice in the services t= ab. >> >> If I copy the cup and cups_filters ipfire packages and install them into m= y test bed system, the programs are installed and can be successfully started= but because they were not installed by pakfire they have not been added to t= he installed meta files in /opt/pakfire/db/installed/meta-* and therefore do = not show up in the services tab at all. >> >> Can anyone help me with advice on how to be able to install these modified= add-on packages so I can check that the original problem is actually solved = by my solution, or do I have to just submit a patch and the review of the pat= ch will tell me if I have done it correctly or not. >> >> Thanks for any help/advice, >> >> Adolf >> >=20 --===============5864593415496483242==--