From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Patches to be merged to be capable of removing python2 Date: Tue, 21 Sep 2021 12:23:16 +0200 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7821154617930479332==" List-Id: --===============7821154617930479332== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 21/09/2021 12:02, Michael Tremer wrote: > Hello, >=20 > I have outlined out Python 2 removal strategy in the release announcement: >=20 > https://blog.ipfire.org/post/ipfire-2-27-core-update-160-available-for-t= esting >=20 > Correct me in case I got something wrong. Not sure if it is a correction or just a status item. All my python2 removal patches except one made it into Core Update 160 for te= sting. The one that didn't is client175. It turned out that when Arne install= ed it the program would not start due to errors with some of the python conve= rsion using 2to3. I tried installing it again on my testbed vm and again I was able to get the = WUI page up but if I tried to start the client175 it also failed with python = module errors. I saw the client175 WUI page was created when I tested it but = I didn't realise the program had not started properly. It seems that just running 2to3 convertor on the python2 code does not give w= orking python3 code for this package. I am not sure what to do next with it. Arne was going to have a closer look a= fter Core Update 160 was dealt with. Regards, Adolf. >=20 > -Michael >=20 >> On 15 Sep 2021, at 17:32, Adolf Belka wrote: >> >> Hi Michael, >> >> On 15/09/2021 17:24, Michael Tremer wrote: >>> Hello, >>> This should all be back up and working again. >> Yes thanks. My patch is now in Patchwork, I see my emails in the dev maili= ng list and I have received my Bugzilla emails. >> >> Regards, >> Adolf. >>> -Michael >>>> On 13 Sep 2021, at 09:57, Arne Fitzenreiter wrote: >>>> >>>> I had already merged freeradius yesterday. >>>> >>>> At the moment patchwork is not working so you should wait antil the serv= er is up again. >>>> >>>> Arne >>>> >>>> >>>> >>>> Am 2021-09-13 10:41, schrieb Adolf Belka: >>>>> Hi Arne, >>>>> On 12/09/2021 21:36, Adolf Belka wrote: >>>>>> Hi Arne, >>>>>> On 12/09/2021 18:12, Arne Fitzenreiter wrote: >>>>>>> At the moment i have not merged all of this. (frr, alsa and freeradiu= s are missing) >>>>>>> but core160 is already large... >>>>>>> But at my test i merged the python2 remove by an accident and only fr= r has made problems. >>>>>>> So i think freeradus and alsa detect the missing python2 but of cours= e the patches should merged >>>>>>> but not in core160 because alsa is large. >>>>>> That's interesting. When I ran without python2 on Core Update 159, als= a and freeradius definitely would not build on my system. >>>>>> I will go back and have another test on my build system but with Core = Update 160 merged to current status to see what happens with python2 removed. >>>>> I ran the current updated next with python2 removed and alsa and >>>>> collectd both successfully built without any hiccups. That definitely >>>>> didn't happen when I did my original test which would have been back >>>>> when next was being put together for Core Update 158. >>>>> Probably I made some mistake. >>>>> Anyway with Core Update 160 as it currently is my patches for python >>>>> fixes for alsa and collectd are not needed and they should be dropped >>>>> from Patchwork. >>>>> I will test with frr and freeradius this morning. I will do a new >>>>> patch for frr anyway as that package was a bit out of date anyway. >>>>> Will report back later what I find. >>>>> EDIT:- >>>>> There was some infrastructure problem with IPFire, couldn't access any >>>>> IPFire location or send email, so I am able to edit this mail before >>>>> sending. >>>>> frr failed to build due to lack of python2, so it definitely needs to >>>>> be updated for the removal of python2 and because it is old. >>>>> freeradius built without a problem, so that is a third of my patches >>>>> that is not required to be merged now. Please drop that patch in >>>>> Patchwork. >>>>> Regards, >>>>> Adolf. >>>>>> Regards, >>>>>> Adolf. >>>>>>> Arne >>>>>>> Am 2021-09-10 08:57, schrieb Adolf Belka: >>>>>>>> Dear All, >>>>>>>> For clarification here is the list of the patches or patch series th= at >>>>>>>> need to be merged to get to the position where python2 is capable of >>>>>>>> being removed. >>>>>>>> alsa >>>>>>>> https://patchwork.ipfire.org/project/ipfire/patch/20210820200636.353= 5891-1-adolf.belka(a)ipfire.org/ >>>>>>>> ca-certificates https://patchwork.ipfire.org/project/ipfire/list/?se= ries=3D2282 >>>>>>>> collectd >>>>>>>> https://patchwork.ipfire.org/project/ipfire/patch/20210820200551.353= 5831-1-adolf.belka(a)ipfire.org/ >>>>>>>> crda https://patchwork.ipfire.org/project/ipfire/list/?series=3D2264 >>>>>>>> freeradius >>>>>>>> https://patchwork.ipfire.org/project/ipfire/patch/20210820200613.353= 5863-1-adolf.belka(a)ipfire.org/ >>>>>>>> frr https://patchwork.ipfire.org/project/ipfire/list/?series=3D2260 >>>>>>>> spice https://patchwork.ipfire.org/project/ipfire/list/?series=3D2296 >>>>>>>> Regards, >>>>>>>> Adolf. >=20 --===============7821154617930479332==--