public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/4] connections.cgi: Fix colour of destination country
Date: Fri, 06 Dec 2024 23:09:45 +0100	[thread overview]
Message-ID: <b1f440d3-c861-4b45-9bdd-5686d25441fd@ipfire.org> (raw)
In-Reply-To: <20241206164417.3840426-1-michael.tremer@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 879 bytes --]

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 06.12.2024 um 17:44 schrieb Michael Tremer:
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>   html/cgi-bin/connections.cgi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/connections.cgi b/html/cgi-bin/connections.cgi
> index badc1f395..af375effe 100644
> --- a/html/cgi-bin/connections.cgi
> +++ b/html/cgi-bin/connections.cgi
> @@ -439,7 +439,7 @@ foreach my $line (<CONNTRACK>) {
>   			</a>
>   			$dport_extra
>   		</td>
> -		<td style='text-align:center; background-color:$sip_colour;'>
> +		<td style='text-align:center; background-color:$dip_colour;'>
>   			<a href='country.cgi#$dstccode'><img src='$dst_flag_icon' border='0' align='absmiddle' alt='$dstccode' title='$dstccode' /></a>
>   		</td>
>   		<td class="text-right">


      parent reply	other threads:[~2024-12-06 22:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06 16:44 Michael Tremer
2024-12-06 16:44 ` [PATCH 2/4] connections.cgi: Ignore empty interfaces Michael Tremer
2024-12-07 23:56   ` Bernhard Bitsch
2024-12-09 11:30     ` Michael Tremer
2024-12-06 16:44 ` [PATCH 3/4] connections.cgi: Fix importing Wireguard peers Michael Tremer
2024-12-06 16:44 ` [PATCH 4/4] connections.cgi: Support CIDR notation Michael Tremer
2024-12-06 22:09 ` Bernhard Bitsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1f440d3-c861-4b45-9bdd-5686d25441fd@ipfire.org \
    --to=bbitsch@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox