Re: Question regarding rootfile warning "Error! '/aarch64' in rootfiles files found!"

[Adolf Belka <adolf.belka@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1659 bytes --]

Hi Peter,

Sorry, I had intended to send out a message about this when I submitted the patches for this but it slipped my mind till I saw your email.

On 05/12/2021 11:47, Peter Müller wrote:
> Hello *,
>
> while preparing Core Update 163, these messages are emitted at the end of a build on my workstation:
>
>> Error! '/aarch64' in rootfiles files found!
>> ./config/rootfiles/common/liburcu:#usr/include/urcu/arch/aarch64.h
>> ./config/rootfiles/common/liburcu:#usr/include/urcu/uatomic/aarch64.h
>> ./config/rootfiles/common/gdb:#usr/share/gdb/syscalls/aarch64-linux.xml
>> Replace by xxxMACHINExxx !
> While I get the intention of a check like this, these appear to be safe to ignore. However, I'd like
> to have someone more experienced on this to confirm that opinion.

I don't consider myself more experienced on this but I did have a look through the rootfile ff liburcu when I saw this message when I did the build.

There are a series of header files for each of the architectures. The 32 bit arm one is called arm.h, the 64 bit x86 is called x86.h. The one for the 64 bit arm architecture is called aarch64.h so this is the one that happens to use a filename the same as the names IPFire uses for architectures.

Replacing the name with xxxMACHINExxx would end up creating file names such as x86_64.h which would not work in the build because these names are not the result of the build but are the actual source files.

How should we deal with the situation where a source file filename happens to use an architecture name the same as an IPFire name.

Regards,

Adolf.

> Thanks, and best regards,
> Peter Müller