From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Question regarding rootfile warning "Error! '/aarch64' in rootfiles files found!" Date: Sun, 05 Dec 2021 12:45:50 +0100 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7267763768048435868==" List-Id: --===============7267763768048435868== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Peter, Sorry, I had intended to send out a message about this when I submitted the p= atches for this but it slipped my mind till I saw your email. On 05/12/2021 11:47, Peter M=C3=BCller wrote: > Hello *, > > while preparing Core Update 163, these messages are emitted at the end of a= build on my workstation: > >> Error! '/aarch64' in rootfiles files found! >> ./config/rootfiles/common/liburcu:#usr/include/urcu/arch/aarch64.h >> ./config/rootfiles/common/liburcu:#usr/include/urcu/uatomic/aarch64.h >> ./config/rootfiles/common/gdb:#usr/share/gdb/syscalls/aarch64-linux.xml >> Replace by xxxMACHINExxx ! > While I get the intention of a check like this, these appear to be safe to = ignore. However, I'd like > to have someone more experienced on this to confirm that opinion. I don't consider myself more experienced on this but I did have a look throug= h the rootfile ff liburcu when I saw this message when I did the build. There are a series of header files for each of the architectures. The 32 bit = arm one is called arm.h, the 64 bit x86 is called x86.h. The one for the 64 b= it arm architecture is called aarch64.h so this is the one that happens to us= e a filename the same as the names IPFire uses for architectures. Replacing the name with xxxMACHINExxx would end up creating file names such a= s x86_64.h which would not work in the build because these names are not the = result of the build but are the actual source files. How should we deal with the situation where a source file filename happens to= use an architecture name the same as an IPFire name. Regards, Adolf. > Thanks, and best regards, > Peter M=C3=BCller --===============7267763768048435868==--