public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2] cpufrequtils: Remove SERVICES entry for this package - fixes Bug#12933
Date: Wed, 21 Sep 2022 12:41:11 +0200	[thread overview]
Message-ID: <b40ee168-1536-fe4f-e1b3-51696f24e91a@ipfire.org> (raw)
In-Reply-To: <20220921103719.3810-1-adolf.belka@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 21.09.2022 um 12:37 schrieb Adolf Belka:
> - cpufrequtils is a set of "tools" to manage and set cpu freq settings.
> - There is an initscript but this is only loading the cpu dependent kernel modules that
>     are required by cpufrequtils.
> - Therefore cpufrequtils is not a service but a set of tools that are used when required.
> - SERVICES line made blank so that this addon does not show up in the services addon table.
> - Modified install initscript line to not use SERVICES variable
> 
> Fixes: Bug#12933
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   lfs/cpufrequtils | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lfs/cpufrequtils b/lfs/cpufrequtils
> index 752964198..dab254014 100644
> --- a/lfs/cpufrequtils
> +++ b/lfs/cpufrequtils
> @@ -34,11 +34,11 @@ DL_FROM    = $(URL_IPFIRE)
>   DIR_APP    = $(DIR_SRC)/$(THISAPP)
>   TARGET     = $(DIR_INFO)/$(THISAPP)
>   PROG       = cpufrequtils
> -PAK_VER    = 11
> +PAK_VER    = 12
>   
>   DEPS       =
>   
> -SERVICES   = cpufreq
> +SERVICES   =
>   
>   ###############################################################################
>   # Top-level Rules
> @@ -91,7 +91,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>   	cd $(DIR_APP) && make install
>   
>   	#install initscripts
> -	$(call INSTALL_INITSCRIPTS,$(SERVICES))
> +	$(call INSTALL_INITSCRIPTS,cpufreq)
>   
>   	@rm -rf $(DIR_APP)
>   	@$(POSTBUILD)

      reply	other threads:[~2022-09-21 10:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 10:37 Adolf Belka
2022-09-21 10:41 ` Bernhard Bitsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b40ee168-1536-fe4f-e1b3-51696f24e91a@ipfire.org \
    --to=bbitsch@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox