public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
* [PATCH v2] cpufrequtils: Remove SERVICES entry for this package - fixes Bug#12933
@ 2022-09-21 10:37 Adolf Belka
  2022-09-21 10:41 ` Bernhard Bitsch
  0 siblings, 1 reply; 2+ messages in thread
From: Adolf Belka @ 2022-09-21 10:37 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]

- cpufrequtils is a set of "tools" to manage and set cpu freq settings.
- There is an initscript but this is only loading the cpu dependent kernel modules that
   are required by cpufrequtils.
- Therefore cpufrequtils is not a service but a set of tools that are used when required.
- SERVICES line made blank so that this addon does not show up in the services addon table.
- Modified install initscript line to not use SERVICES variable

Fixes: Bug#12933
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
 lfs/cpufrequtils | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lfs/cpufrequtils b/lfs/cpufrequtils
index 752964198..dab254014 100644
--- a/lfs/cpufrequtils
+++ b/lfs/cpufrequtils
@@ -34,11 +34,11 @@ DL_FROM    = $(URL_IPFIRE)
 DIR_APP    = $(DIR_SRC)/$(THISAPP)
 TARGET     = $(DIR_INFO)/$(THISAPP)
 PROG       = cpufrequtils
-PAK_VER    = 11
+PAK_VER    = 12
 
 DEPS       =
 
-SERVICES   = cpufreq
+SERVICES   = 
 
 ###############################################################################
 # Top-level Rules
@@ -91,7 +91,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
 	cd $(DIR_APP) && make install
 
 	#install initscripts
-	$(call INSTALL_INITSCRIPTS,$(SERVICES))
+	$(call INSTALL_INITSCRIPTS,cpufreq)
 
 	@rm -rf $(DIR_APP)
 	@$(POSTBUILD)
-- 
2.37.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] cpufrequtils: Remove SERVICES entry for this package - fixes Bug#12933
  2022-09-21 10:37 [PATCH v2] cpufrequtils: Remove SERVICES entry for this package - fixes Bug#12933 Adolf Belka
@ 2022-09-21 10:41 ` Bernhard Bitsch
  0 siblings, 0 replies; 2+ messages in thread
From: Bernhard Bitsch @ 2022-09-21 10:41 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 21.09.2022 um 12:37 schrieb Adolf Belka:
> - cpufrequtils is a set of "tools" to manage and set cpu freq settings.
> - There is an initscript but this is only loading the cpu dependent kernel modules that
>     are required by cpufrequtils.
> - Therefore cpufrequtils is not a service but a set of tools that are used when required.
> - SERVICES line made blank so that this addon does not show up in the services addon table.
> - Modified install initscript line to not use SERVICES variable
> 
> Fixes: Bug#12933
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   lfs/cpufrequtils | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lfs/cpufrequtils b/lfs/cpufrequtils
> index 752964198..dab254014 100644
> --- a/lfs/cpufrequtils
> +++ b/lfs/cpufrequtils
> @@ -34,11 +34,11 @@ DL_FROM    = $(URL_IPFIRE)
>   DIR_APP    = $(DIR_SRC)/$(THISAPP)
>   TARGET     = $(DIR_INFO)/$(THISAPP)
>   PROG       = cpufrequtils
> -PAK_VER    = 11
> +PAK_VER    = 12
>   
>   DEPS       =
>   
> -SERVICES   = cpufreq
> +SERVICES   =
>   
>   ###############################################################################
>   # Top-level Rules
> @@ -91,7 +91,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>   	cd $(DIR_APP) && make install
>   
>   	#install initscripts
> -	$(call INSTALL_INITSCRIPTS,$(SERVICES))
> +	$(call INSTALL_INITSCRIPTS,cpufreq)
>   
>   	@rm -rf $(DIR_APP)
>   	@$(POSTBUILD)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-21 10:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-21 10:37 [PATCH v2] cpufrequtils: Remove SERVICES entry for this package - fixes Bug#12933 Adolf Belka
2022-09-21 10:41 ` Bernhard Bitsch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox