public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] wakeonlan.cgi: Fix meta refresh tag
Date: Sun, 24 Apr 2022 19:12:25 +0000	[thread overview]
Message-ID: <b53b637e-06e3-4111-c271-fb999ecbd270@ipfire.org> (raw)
In-Reply-To: <20220420121309.1590-1-hofmann@leo-andres.de>

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>

> This fixes an HTML error that is briefly visible
> on the "magic packet sent" page.
> 
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
>  html/cgi-bin/wakeonlan.cgi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/html/cgi-bin/wakeonlan.cgi b/html/cgi-bin/wakeonlan.cgi
> index c3c4c6911..e88448964 100644
> --- a/html/cgi-bin/wakeonlan.cgi
> +++ b/html/cgi-bin/wakeonlan.cgi
> @@ -173,10 +173,10 @@ if ( $cgiparams{'ACTION'} eq 'wakeup' )
>  
>    &General::system("/usr/sbin/etherwake", "-i", "$iface", "$mac");
>  
> -  # make a box with info, 'refresh' to normal screen after 5 seconds
> +  # make a box with info, 'refresh' to normal screen after 3 seconds
>    if ( $refresh eq 'yes' )
>    {
> -    &Header::openpage($Lang::tr{'WakeOnLan'}, 1, "<meta http-equiv='refresh' content='3;url=/cgi-bin/wakeonlan.cgi'");
> +    &Header::openpage($Lang::tr{'WakeOnLan'}, 1, "<meta http-equiv='refresh' content='3; url=/cgi-bin/wakeonlan.cgi'>");
>      &Header::openbigbox('100%', 'left');
>    }
>    &Header::openbox('100%', 'left', $Lang::tr{'WakeOnLan'});

      reply	other threads:[~2022-04-24 19:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 12:13 Leo-Andres Hofmann
2022-04-24 19:12 ` Peter Müller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b53b637e-06e3-4111-c271-fb999ecbd270@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox