public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2 5/5] services.cgi: add link to addon config if ui exists for it
Date: Thu, 06 Oct 2022 20:48:39 +0200	[thread overview]
Message-ID: <b5bc6f57-9d5d-5127-1bdd-116ce26d86fa@ipfire.org> (raw)
In-Reply-To: <20221006175958.11036-6-robin.roevens@disroot.org>

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 06.10.2022 um 19:59 schrieb Robin Roevens:
> * If a cgi file exists with the same name as an addon, the
>    displayed service will be a link to that cgi file.
> 
> Signed-off-by: Robin Roevens <robin.roevens(a)disroot.org>
> ---
>   html/cgi-bin/services.cgi | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi
> index 4b379251e..14ed01c50 100644
> --- a/html/cgi-bin/services.cgi
> +++ b/html/cgi-bin/services.cgi
> @@ -192,6 +192,10 @@ END
>   
>   				# Add addon name to displayname of service if servicename differs from addon
>   				my $displayname = ($pak ne $service) ? "$service ($pak)" : $service;
> +				if ( -e "/srv/web/ipfire/cgi-bin/$pak.cgi" ) {
> +					$displayname = ($pak ne $service) ? "$service (<a href=\'$pak.cgi\'>$pak</a>)" : "<a href=\'$pak.cgi\'>$service</a>";
> +				}
> +
>   				print "<td align='left' $col width='31%'>$displayname</td> ";
>   
>   				my $status = isautorun($pak,$service,$col);

      reply	other threads:[~2022-10-06 18:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 17:59 [PATCH v2 0/5] Fix Bug#12935 + cosmetic changes/enhancements Robin Roevens
2022-10-06 17:59 ` [PATCH v2 1/5] misc-progs: addonctrl: Add support for 'Services' metadata Robin Roevens
2022-10-07 15:01   ` Michael Tremer
2022-10-08 23:09     ` Robin Roevens
2022-10-10 10:04       ` Michael Tremer
2022-10-10 12:27         ` Robin Roevens
2022-10-10 13:27           ` Michael Tremer
2022-10-06 17:59 ` [PATCH v2 2/5] services.cgi: Fix status/actions on services with name != addon name Robin Roevens
2022-10-06 17:59 ` [PATCH v2 3/5] services.cgi: minor cosmetics Robin Roevens
2022-10-06 18:52   ` Bernhard Bitsch
2022-10-06 17:59 ` [PATCH v2 4/5] services.cgi: add restart action and restrict action usage Robin Roevens
2022-10-06 17:59 ` [PATCH v2 5/5] services.cgi: add link to addon config if ui exists for it Robin Roevens
2022-10-06 18:48   ` Bernhard Bitsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5bc6f57-9d5d-5127-1bdd-116ce26d86fa@ipfire.org \
    --to=bbitsch@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox