From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH v2 5/5] services.cgi: add link to addon config if ui exists for it
Date: Thu, 06 Oct 2022 20:48:39 +0200
Message-ID: <b5bc6f57-9d5d-5127-1bdd-116ce26d86fa@ipfire.org>
In-Reply-To: <20221006175958.11036-6-robin.roevens@disroot.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3989343459557650147=="
List-Id: <development.lists.ipfire.org>

--===============3989343459557650147==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 06.10.2022 um 19:59 schrieb Robin Roevens:
> * If a cgi file exists with the same name as an addon, the
>    displayed service will be a link to that cgi file.
>=20
> Signed-off-by: Robin Roevens <robin.roevens(a)disroot.org>
> ---
>   html/cgi-bin/services.cgi | 4 ++++
>   1 file changed, 4 insertions(+)
>=20
> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi
> index 4b379251e..14ed01c50 100644
> --- a/html/cgi-bin/services.cgi
> +++ b/html/cgi-bin/services.cgi
> @@ -192,6 +192,10 @@ END
>  =20
>   				# Add addon name to displayname of service if servicename differs fro=
m addon
>   				my $displayname =3D ($pak ne $service) ? "$service ($pak)" : $service;
> +				if ( -e "/srv/web/ipfire/cgi-bin/$pak.cgi" ) {
> +					$displayname =3D ($pak ne $service) ? "$service (<a href=3D\'$pak.cgi=
\'>$pak</a>)" : "<a href=3D\'$pak.cgi\'>$service</a>";
> +				}
> +
>   				print "<td align=3D'left' $col width=3D'31%'>$displayname</td> ";
>  =20
>   				my $status =3D isautorun($pak,$service,$col);

--===============3989343459557650147==--