public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Feedback regarding version 8 of the "IDS multiple provider" feature
Date: Sun, 09 Jan 2022 09:45:08 +0100	[thread overview]
Message-ID: <b60ce58f-2492-e093-4931-2e114a66d21f@ipfire.org> (raw)
In-Reply-To: <ee5659c5e83b6c056ba75ccb910fc038d7607d96.camel@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 4848 bytes --]

Hello Stefan,

thanks for your reply.

Version 9 now looks good to me. I had to grant executable file permissions to the convert
script, but that's not a big deal:

[root(a)maverick ~]# /usr/sbin/convert-ids-multiple-providers
-bash: /usr/sbin/convert-ids-multiple-providers: Permission denied
[root(a)maverick ~]# chmod +x /usr/sbin/convert-ids-multiple-providers
[root(a)maverick ~]# /usr/sbin/convert-ids-multiple-providers

Since the script already ran on that machine, I had to execute

chown nobody:nobody /var/ipfire/suricata/suricata-default-rules.yaml

myself. Every functionality provided by the WebUI seems to work fine, and I was unable to
break anything. :-)

(With URLhaus enabled, Suricata takes ages to reload on my testing machine, I am curious
how many people will enable this provider despite the performance impact... We'll see.)

As soon as there is a testing announcement for Core Update 163, I will start a temporary
branch for Core Update 164 and merge https://git.ipfire.org/?p=people/stevee/ipfire-2.x.git;a=shortlog;h=refs/heads/master-IDSv3
into it.

Thanks, and best regards,
Peter Müller


> Hello Peter,
> 
> a big thanks for having a look and sharing your issues here.
> 
> I've fixed both bugs and uploaded a new test package (009).
> 
> https://people.ipfire.org/~stevee/ids-multiple-providers/ids-multiple-providers-009.tar.gz
> 
> Please re-test and report any remain or new issues.
> 
> A big thanks in advance,
> 
> -Stefan
> 
>  
>> Hello Stefan,
>>
>> as discussed on Monday
>> (https://wiki.ipfire.org/devel/telco/2022-01-03), I tested version 8
>> of the "IDS multiple provider" feature you developed. First of all,
>> thank you very much for
>> all the efforts you have put into this!
>>
>> As you told me on the phone the other day, I downloaded the .tar.gz
>> file, and extracted it
>> directly into / :
>>
>> [root(a)maverick ~]# sha256sum ids-multiple-providers-008.tar.gz 
>> 8fc42820a833f4a096c311d3e21a28f4a8dac7d772ca9b72ec0fbbbaad65be82 
>> ids-multiple-providers-008.tar.gz
>> [root(a)maverick ~]# tar xvzf ids-multiple-providers-008.tar.gz -C /
>> usr/share/suricata/rules/app-layer-events.rules
>> var/ipfire/langs/
>> etc/
>> var/ipfire/backup/
>> usr/share/suricata/rules/stream-events.rules
>> usr/share/suricata/rules/files.rules
>> usr/share/suricata/rules/http-events.rules
>> usr/share/
>> usr/share/suricata/classification.config
>> var/ipfire/suricata/oinkmaster.conf
>> usr/share/suricata/rules/decoder-events.rules
>> srv/
>> usr/share/suricata/rules/nfs-events.rules
>> usr/
>> usr/local/bin/update-ids-ruleset
>> etc/suricata/suricata.yaml
>> usr/share/suricata/threshold.config
>> var/ipfire/langs/de.pl
>> var/ipfire/backup/bin/backup.pl
>> usr/local/
>> usr/share/suricata/rules/smb-events.rules
>> var/ipfire/backup/bin/
>> usr/share/suricata/rules/dhcp-events.rules
>> usr/local/bin/
>> usr/share/suricata/rules/modbus-events.rules
>> var/ipfire/ids-functions.pl
>> usr/share/suricata/rules/ntp-events.rules
>> var/ipfire/langs/en.pl
>> var/ipfire/suricata/
>> usr/share/suricata/rules/dnp3-events.rules
>> usr/share/suricata/reference.config
>> usr/share/suricata/rules/smtp-events.rules
>> usr/share/suricata/rules/
>> var/ipfire/backup/include
>> srv/web/ipfire/
>> usr/share/suricata/rules/kerberos-events.rules
>> usr/sbin/convert-ids-multiple-providers
>> usr/share/suricata/
>> srv/web/
>> usr/share/suricata/rules/ipsec-events.rules
>> srv/web/ipfire/cgi-bin/ids.cgi
>> usr/sbin/convert-snort
>> srv/web/ipfire/cgi-bin/
>> var/ipfire/
>> usr/sbin/
>> usr/share/suricata/rules/tls-events.rules
>> var/
>> etc/suricata/
>> usr/share/suricata/rules/dns-events.rules
>> var/ipfire/suricata/ruleset-sources
>>
>> Afterwards, I updated the language cache and ran the convert script:
>>
>> [root(a)maverick ~]# update-lang-cache 
>> [root(a)maverick ~]# /usr/sbin/convert-ids-multiple-providers
>> The  does not exist. Cannot change the ownership!
>>
>> Aside from the message emitted by /usr/sbin/convert-ids-multiple-
>> providers (bug #12758 has been filed for
>> investigating on this one), I came across a file permission error
>> while writing /var/ipfire/suricata/suricata-default-rules.yaml
>> (see bug #12759 for details).
>>
>> Apart from these, the CGI looks good, is sufficiently translated
>> (sometimes, "zurück" is spelled in capital
>> letters, sometimes, it is not - but that's merely an aesthetic
>> issue), and behaves like expected. So, I'd
>> treat it al almost being ready for production. :-)
>>
>> Please take a look at bug #12758 and #12759, and reply to me there if
>> I shall provide further information.
>>
>> Thank you in advance for your efforts.
>>
>> Thanks, and best regards,
>> Peter Müller
> 
> 

      reply	other threads:[~2022-01-09  8:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-08 10:37 Peter Müller
2022-01-08 15:35 ` Stefan Schantl
2022-01-09  8:45   ` Peter Müller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b60ce58f-2492-e093-4931-2e114a66d21f@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox