From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] vpnmain.cgi: set SubjectAlternativeName default during root, certificate generation
Date: Sun, 05 Jan 2020 17:54:00 +0000 [thread overview]
Message-ID: <b67cba4c-38e6-7477-2ac2-e2a4df87680a@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]
Some IPsec implementations such as OpenIKED require SubjectAlternativeName
data on certificates and refuse to establish connections otherwise.
The StrongSwan project also recommends it (see:
https://wiki.strongswan.org/projects/strongswan/wiki/SimpleCA) although
it is currently not enforced by their IPsec software.
For convenience purposes and to raise awareness, this patch adds a default
SubjectAlternativeName based on the machines hostname or IP address. Existing
certificates remain unchanged for obvious reasons.
Fixes #11594
Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
html/cgi-bin/vpnmain.cgi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/html/cgi-bin/vpnmain.cgi b/html/cgi-bin/vpnmain.cgi
index 33b504bc9..9b7bd81ca 100644
--- a/html/cgi-bin/vpnmain.cgi
+++ b/html/cgi-bin/vpnmain.cgi
@@ -822,8 +822,10 @@ END
close IPADDR;
chomp ($ipaddr);
$cgiparams{'ROOTCERT_HOSTNAME'} = (gethostbyaddr(pack("C4", split(/\./, $ipaddr)), 2))[0];
+ $cgiparams{'SUBJECTALTNAME'} = "DNS:" . (gethostbyaddr(pack("C4", split(/\./, $ipaddr)), 2))[0];
if ($cgiparams{'ROOTCERT_HOSTNAME'} eq '') {
$cgiparams{'ROOTCERT_HOSTNAME'} = $ipaddr;
+ $cgiparams{'SUBJECTALTNAME'} = "IP:" . $ipaddr;
}
}
$cgiparams{'ROOTCERT_COUNTRY'} = $vpnsettings{'ROOTCERT_COUNTRY'} if (!$cgiparams{'ROOTCERT_COUNTRY'});
--
2.16.4
next reply other threads:[~2020-01-05 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 17:54 Peter Müller [this message]
2020-01-05 18:11 ` [PATCH v2] vpnmain.cgi: set SubjectAlternativeName default during root " Peter Müller
2020-01-06 11:15 ` Michael Tremer
2020-01-06 19:26 ` Peter Müller
2020-01-07 21:47 ` [PATCH v3 1/3] " Peter Müller
2020-01-07 21:47 ` [PATCH v3 2/3] update translation files for vpnmain.cgi changes Peter Müller
2020-01-07 21:48 ` [PATCH v3 3/3] Core Update 140: ship changed vpnmain.cgi Peter Müller
2020-01-08 10:58 ` [PATCH v3 1/3] vpnmain.cgi: set SubjectAlternativeName default during root certificate generation Michael Tremer
2020-01-09 15:20 ` Peter Müller
2020-01-13 12:37 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b67cba4c-38e6-7477-2ac2-e2a4df87680a@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox