From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] proxy.cgi: Even more cosmetics for lazy ones (V3)
Date: Mon, 09 Oct 2017 20:38:11 +0200 [thread overview]
Message-ID: <b70d327a-23e5-cb59-93fc-de6a1a62223b@ipfire.org> (raw)
In-Reply-To: <1507559675.4045.21.camel@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]
Hi,
On 09.10.2017 16:34, Michael Tremer wrote:
> Hi,
>
> On Fri, 2017-09-29 at 11:08 +0200, Matthias Fischer wrote:
>> Another clickable link, this time for the 'Cache Manager Interface' - this one
>> opens in a new window.
>>
>> Best,
>> Matthias
>>
>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>> ---
>> html/cgi-bin/proxy.cgi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi
>> index dd83bba73..ab490c3d3 100644
>> --- a/html/cgi-bin/proxy.cgi
>> +++ b/html/cgi-bin/proxy.cgi
>> @@ -1118,7 +1118,7 @@ print <<END
>> <td colspan='4'><b>$Lang::tr{'advproxy cache management'}</b></td>
>> </tr>
>> <tr>
>> - <td class='base'>$Lang::tr{'proxy cachemgr'}:</td>
>> + <td class='base'><a href='/cgi-bin/cachemgr.cgi\'
>> target=\'_blank\'>$Lang::tr{'proxy cachemgr'}</a>:</td>
>> <td><input type='checkbox' name='CACHEMGR' $checked{'CACHEMGR'}{'on'}
>> /></td>
>
> Why do you escape the '?
No good reason just one too many.
>> <td class='base'>$Lang::tr{'advproxy admin mail'}:</td>
>> <td><input type='text' name='ADMIN_MAIL_ADDRESS'
>> value='$proxysettings{'ADMIN_MAIL_ADDRESS'}' /></td>
>
> -Michael
>
prev parent reply other threads:[~2017-10-09 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 9:08 Matthias Fischer
2017-10-09 14:34 ` Michael Tremer
2017-10-09 18:38 ` Matthias Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b70d327a-23e5-cb59-93fc-de6a1a62223b@ipfire.org \
--to=matthias.fischer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox