From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] proxy.cgi: Even more cosmetics for lazy ones (V3)
Date: Mon, 09 Oct 2017 20:38:11 +0200
Message-ID: <b70d327a-23e5-cb59-93fc-de6a1a62223b@ipfire.org>
In-Reply-To: <1507559675.4045.21.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5653605322677841690=="
List-Id: <development.lists.ipfire.org>

--===============5653605322677841690==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On 09.10.2017 16:34, Michael Tremer wrote:
> Hi,
>=20
> On Fri, 2017-09-29 at 11:08 +0200, Matthias Fischer wrote:
>> Another clickable link, this time for the 'Cache Manager Interface' - this=
 one
>> opens in a new window.
>>=20
>> Best,
>> Matthias
>>=20
>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>> ---
>>  html/cgi-bin/proxy.cgi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi
>> index dd83bba73..ab490c3d3 100644
>> --- a/html/cgi-bin/proxy.cgi
>> +++ b/html/cgi-bin/proxy.cgi
>> @@ -1118,7 +1118,7 @@ print <<END
>>  	<td colspan=3D'4'><b>$Lang::tr{'advproxy cache management'}</b></td>
>>  </tr>
>>  <tr>
>> -	<td class=3D'base'>$Lang::tr{'proxy cachemgr'}:</td>
>> +	<td class=3D'base'><a href=3D'/cgi-bin/cachemgr.cgi\'
>> target=3D\'_blank\'>$Lang::tr{'proxy cachemgr'}</a>:</td>
>>  	<td><input type=3D'checkbox' name=3D'CACHEMGR' $checked{'CACHEMGR'}{'on'}
>> /></td>
>=20
> Why do you escape the '?

No good reason just one too many.

>>  	<td class=3D'base'>$Lang::tr{'advproxy admin mail'}:</td>
>>  	<td><input type=3D'text' name=3D'ADMIN_MAIL_ADDRESS'
>> value=3D'$proxysettings{'ADMIN_MAIL_ADDRESS'}' /></td>
>=20
> -Michael
>=20


--===============5653605322677841690==--