From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH 5/5] suricata: Use DNS_SERVERS declaration from external file.
Date: Tue, 05 Nov 2019 13:45:54 +0100
Message-ID: <b73393f33c33952a30238235d69ed7885d38747b.camel@ipfire.org>
In-Reply-To: <BDF46745-4B7C-4259-834A-6DEE9380FC3F@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4348092752071378092=="
List-Id: <development.lists.ipfire.org>

--===============4348092752071378092==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hello Michael,
> Hi,
> 
> Shouldn’t HOME_NET still be in DNS_SERVERS for users who are running
> a DNS server behind their firewall?

set HOME_NET here would result in DNS related intrusion rules which
will only match if DNS requests will be sent to a internal DNS server,
which was the default in the past.

The current approach is to set this value to the used DNS servers, or
if unbound is used in recursor mode to every external address
(!HOME_NET).

Best regards,

-Stefan
> 
> > On 5 Nov 2019, at 09:32, Stefan Schantl <stefan.schantl(a)ipfire.org>
> > wrote:
> > 
> > These settings now will be read from
> > /var/ipfire/suricata/suricata-dns-servers.yaml, which will be
> > generated by the generate_dns_servers_file() function, located in
> > ids-functions.pl and called by various scripts.
> > 
> > Fixes #12166.
> > 
> > Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> > ---
> > config/suricata/suricata.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/config/suricata/suricata.yaml
> > b/config/suricata/suricata.yaml
> > index e921781cf..af9cb75a9 100644
> > --- a/config/suricata/suricata.yaml
> > +++ b/config/suricata/suricata.yaml
> > @@ -11,12 +11,14 @@ vars:
> >     # Include HOME_NET declaration from external file.
> >     include: /var/ipfire/suricata/suricata-homenet.yaml
> > 
> > +    # Include DNS_SERVERS declaration from external file.
> > +    include: /var/ipfire/suricata/suricata-dns-servers.yaml
> > +
> >     EXTERNAL_NET: "any"
> > 
> >     HTTP_SERVERS: "$HOME_NET"
> >     SMTP_SERVERS: "$HOME_NET"
> >     SQL_SERVERS: "$HOME_NET"
> > -    DNS_SERVERS: "$HOME_NET"
> >     TELNET_SERVERS: "$HOME_NET"
> >     AIM_SERVERS: "$EXTERNAL_NET"
> >     DC_SERVERS: "$HOME_NET"
> > -- 
> > 2.20.1
> > 


--===============4348092752071378092==--