From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Krieger To: development@lists.ipfire.org Subject: Re: [PATCH] ddns: Add provider Feste-IP.Net Date: Thu, 20 May 2021 16:51:57 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4533215065515219662==" List-Id: --===============4533215065515219662== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, this is my latest improvement: From c745be038550bf66f2c233ff9de1348bcfd99080 Mon Sep 17 00:00:00 2001 From: Martin Krieger Date: Tue, 18 May 2021 19:42:44 +0200 Subject: [PATCH] ddns: Add provider Feste-IP.Net Provider supports IPv4, IPv6 & DS (Dual-Stack). Required url parameter myip for IPv4 or IPv6. Optional url parameter myip2 for DS which holds IPv4 or IPv6. Url parameters myip & myip2 will not hold the same record type. --- README | 1 + src/ddns/providers.py | 40 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+) diff --git a/README b/README index b6decb35c338..fa6ce5e598b8 100644 --- a/README +++ b/README @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: easydns.com enom.com entrydns.net + feste-ip.net freedns.afraid.org inwx.com|de|at|ch|es itsdns.de diff --git a/src/ddns/providers.py b/src/ddns/providers.py index 56e6620c78ab..8c6da69b6e50 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -1179,6 +1179,46 @@ class DDNSProviderEntryDNS(DDNSProvider): raise DDNSUpdateError +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider): + handle =3D "feste-ip.net" + name =3D "Feste-IP.Net" + website =3D "https://www.feste-ip.net/" + + # Information about the format of the request is to be found + # https://forum.feste-ip.net/viewtopic.php?f=3D13&t=3D469 + + # myip is required and holds IPv4 or IPv6 + # myip2 is optional for DS and holds IPv4 or Ipv6 but opposite record=20 type of myip + myips =3D ("myip","myip2") + + url =3D "https://members.feste-ip.net/nic/update/" + + def update(self): + data =3D { + "hostname" : self.hostname + } + + # idx sets index of myips and checks for required url parameter myip + idx =3D 0 + # Loop through DDNSProvider.protocols list + for proto in DDNSProvider.protocols: + idx =3D 0 + tmpip =3D self.get_address(proto) + # Save only valid address response of protocol proto to the actual=20 url parameter... + # and increase idx + if tmpip: + data[self.myips[idx]] =3D tmpip + idx +=3D 1 + + # Send DynDNS2 update request if the required url parameter myip is given + if idx: + self.send_request(data) + return + + # Raise error if the required if the required url parameter myip gets=20 no valid address + raise DDNSUpdateError + + class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): handle =3D "freedns.afraid.org" name =3D "freedns.afraid.org" --=20 2.31.0 Based on your correct comment idx =3D 0 was on the wrong line, it moved=20 outside the loop over the protocols (IPv4 & IPv6). Pure IPv4 is tested & works as expected. As stated several times I have=20 no option to test IPv6 and DS on my system. The provider serves a test possibility=20 (https://www.feste-ip.net/ddns-service/faq-ddns/): "Kann Ich den Dienst testen ohne mich extra anzumelden? Ja. Um zu testen ob Ihr Router bzw. Ihr Updateclient mit unserem Dienst=20 funktioniert k=C3=B6nnen Sie folgende Testdaten verwenden: DNS-Name: test.feste-ip.net HOST-ID : 13135 Passwort: 7sN2KS6L8W Bitte beachten Sie dass diese Daten u.U. von mehreren Testern verwendet=20 werden. Ob Ihr Update erfolgreich war k=C3=B6nnen Sie mit der zeitnahen Eingabe von=20 "nslookup -query=3Dtxt test.feste-ip.net" pr=C3=BCfen." Could please anybody in the development-team who has the right technical=20 conditions (IPv6 or DS) do test for these cases? That would be nice. Thanks. Should I mark my faulty patch on the ipfire git server as superseded? Regards, Martin Krieger Michael Tremer: > Hello, >=20 >> On 20 May 2021, at 12:02, Martin Krieger wrote: >> >> Hello Michael, >> >> got it. You are right, sorry for confusion. >> >> But I really read the process description and have read your comments as w= ell as looking in providers.py for examples. >> >> What should I do? Remove anything, improve it,...? >=20 > Yes, please improve the patch. If there is anything unclear, you should=20 ask those questions first before sending a fixed version of that patch. >=20 >> Simply issue a request to you to implement that? >=20 > No, this won=E2=80=99t work because we don=E2=80=99t have an account with t= his provider to test it. >=20 >> One general question: Should a patch be send as uncommited diff from the s= taging area in before for revision instead of a commited one? >=20 > No, you should have a branch in your local git repository and commit to=20 that. You can use =E2=80=9Cgit commit =E2=80=94-amend=E2=80=9D if you need to= edit an existing commit. >=20 > Best, > -Michael >=20 >> >> Regards, >> >> Martin Krieger >> >> >> >> Am 20. Mai 2021 12:00:26 MESZ schrieb Michael Tremer : >> Hello Martin, >> >> Thanks for working on ddns, but *please* read Peter=E2=80=99s email. >> >> This is now the third patch (I don=E2=80=99t know why you are at number 6 = already) and the idea of the review process is to submit something that at le= ast works. You can ask all sorts of questions about anything you need to know= , but you will have to listen to what people answer. >> >> This patch is fundamentally broken. I will comment on that further below. >> >> Secondly, we cannot even think about merging something that isn=E2=80=99t = tested at all. >> >> So I would urge you to look at any of the other providers, because what yo= u are trying to implement has already been implemented here for example: >> >> https://git.ipfire.org/?p=3Dddns.git;a=3Dblob;f=3Dsrc/ddns/providers.py= ;h=3D56e6620c78ab3d9de1c945147f86e70a8d8614d7;hb=3DHEAD#l975 >> >> @Stefan: We might want to have a class variable in the DynDNS protocol=20 that adds the IPv6 address to a field that is named in that variable. That wa= y, we avoid any code duplication. >> >> On 18 May 2021, at 19:49, Martin Krieger wrote: >> >> From 37fb0237932fb12bdd635e9cb5e01b0bf9f03dda Mon Sep 17 00:00:00 2001 >> From: Martin Krieger >> Date: Tue, 18 May 2021 19:42:44 +0200 >> Subject: [PATCH v6 1/1] ddns: Add provider Feste-IP.Net >> >> Comments: >> Provider supports IPv4, IPv6 & DS (Dual-Stack) >> >> Changelog: >> >> 18.05.2021 >> Improved failure handling. >> IPv6 & DS still not checked, because my network connection is pure IPv4. >> >> 17.05.2021 >> 5th attempt ([PATCH v5 1/1]) >> >> 16.05.2021 >> 4th attempt ([PATCH v4 1/1]) >> >> 08.05.2021 >> 3rd attempt ([PATCH v3 1/1]) >> >> 06.05.2021 >> 2nd attempt ([PATCH v2 1/1]) >> >> 05.05.2021 >> 1st attempt ([PATCH v1 1/1]) >> >> Signed-off-by: Martin Krieger .. >> README | 1 + >> src/ddns/providers.py | 31 +++++++++++++++++++++++++++++++ >> 2 files changed, 32 insertions(+) >> >> diff --git a/README b/README >> index b6decb35c338..fa6ce5e598b8 100644 >> --- a/README >> +++ b/README >> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: >> easydns.com >> enom.com >> entrydns.net >> + feste-ip.net >> freedns.afraid.org >> inwx.com|de|at|ch|es >> itsdns.de >> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >> index 56e6620c78ab..b7e14482a0b1 100644 >> --- a/src/ddns/providers.py >> +++ b/src/ddns/providers.py >> @@ -1179,6 +1179,37 @@ class DDNSProviderEntryDNS(DDNSProvider): >> raise DDNSUpdateError >> >> >> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider): >> + handle =3D "feste-ip.net" >> + name =3D "Feste-IP.Net" >> + website =3D "https://www.feste-ip.net/" >> + >> + # Information about the format of the request is to be found >> + # https://forum.feste-ip.net/viewtopic.php?f=3D13&t=3D469 >> + >> + myips =3D ("myip","myip2") >> + >> + url =3D "https://members.feste-ip.net/nic/update/" >> + >> + def update(self): >> + data =3D { >> + "hostname" : self.hostname >> + } >> + >> + for proto in DDNSProvider.protocols: >> + idx =3D 0 >> + tmpip =3D self.get_address(proto) >> + if tmpip: >> + data[self.myips[idx]] =3D tmpip >> + idx +=3D 1 >> >> Setting idx is useless here. You will reset to zero in every iteration=20 of the loop. Since it is being incremented last and then reset to zero, idx w= ill *always* be zero. >> >> + >> + if self.myips[0] in data: >> + self.send_request(data) >> + return# >> >> You will only send one request here and only if it contains an IPv4 addres= s. Why? What happens to systems that only have IPv6? >> >> -Michael >> >> + >> + raise DDNSUpdateError >> + >> + >> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >> handle =3D "freedns.afraid.org" >> name =3D "freedns.afraid.org" >> --=20 >> 2.31.0 >> >> >> >> >> >> --=20 >> Diese Nachricht wurde von meinem Android-Ger=C3=A4t mit K-9 Mail gesendet. >=20 --===============4533215065515219662== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="OpenPGP_signature.sig" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ2dBZEZpRUVuV0tqZ2ZoSXBr anh4Tm1BRWV2RUVOYVpqR01GQW1DbWs2NEFDZ2tRRWV2RUVOYVoKakdPMlFBLy9hdWVvTHRDcGVB SzZRaEhuWVFKcHlhZHhuZGJHdjNib1gxNFZ1Z2ZadnY5aEdwZVgzUzRiUnFoNApVeVFOTkRaZW55 SUVXZzJqN25Wem5lTUY3ZDdRMGRWcjZtNmhKOFJFSENHUE11QjgwOW5oNi9JdHdEOWtPK1JYCjBk bStQeVd5WmpRcjhsYnhybnFWSHlSRVFpY0hYeVA5VHVYOGlid2I3SzVSK01xTjhhYzVyRzI0L1Z3 OG9NNWIKRUFBY3pRK2FaTGdIclF2eFRDVTNudjZvTGwwSUlnV1VNRnpmMEdUanU5bTZpM0traHJW NHNTVGkxa3UvdmpUcApnQ0tadlZqS0kxcFpBNWdRMVdPcFk5enlGblRlZHJNMkFzcGtGMEVJYUdn MnVUMHh3YTJFVHJNeWdTOElUMktJCnRKMWhZNTIremQ3MGZ0ejNxU01GZGNPWU5aWmhONm83alFw NXh3SC9PcHRQTFN4N0ZIaXJjOFVXQnFmOUpvTkoKbzZrUjBGY0pqRi9WbktyUHcyMlhYMVpJVlVj azVZZVhXMFRrZUUvR05HKzVCZVNrc1oydW1EVHpvOXFnR0pHRwpWWGdaSUxmWWdsb1NRTXVxdHAv MjBNU1VtdHR2NTFFZG5YbHprdEJzWEtnQUIybW5vbnJZUDZqckQ0WXFyeS9JCi9UZkRjQ0Vmbzlp Qzl1a1NHc01WcUFKRlAzaVUyYkJVbkNFa2huNGJER1FYUDgyV3lmVWZnSnNOc2FnYWI2Y3IKOVVG b0NXQUFjTi95cWdIQnZUdHQ2QnBCelJSZ2cwRWpLRGZZMTF1R1ppNVpDY21nbFh0bTVhZHR3Y0dn eEw4ZAo4RGM0ZkswRGpML2pWWUs5Slp4QStWQVhIVUpLTFpvY1l6aExMRXJIOEh3OFFpZG9tVHM9 Cj0xWG9ZCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============4533215065515219662==--